erc.cpp

Go to the documentation of this file.

/*
 * This program source code file is part of KiCad, a free EDA CAD application.
 *
 * Copyright (C) 2015 Jean-Pierre Charras, jp.charras at wanadoo.fr
 * Copyright (C) 2011 Wayne Stambaugh <[email protected]>
 * Copyright The KiCad Developers, see AUTHORS.txt for contributors.
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
#include <algorithm>
#include <map>
#include <numeric>
#include <set>
 
#include "connection_graph.h"
#include "kiface_ids.h"
#include <advanced_config.h>
#include <common.h>     // for ExpandEnvVarSubstitutions
#include <erc/erc.h>
#include <erc/erc_sch_pin_context.h>
#include <gal/graphics_abstraction_layer.h>
#include <string_utils.h>
#include <sch_pin.h>
#include <project_sch.h>
#include <project/project_file.h>
#include <project/net_settings.h>
#include <sch_bus_entry.h>
#include <sch_edit_frame.h>
#include <sch_marker.h>
#include <sch_reference_list.h>
#include <sch_rule_area.h>
#include <sch_sheet.h>
#include <sch_sheet_pin.h>
#include <sch_pin.h>
#include <sch_textbox.h>
#include <sch_line.h>
#include <schematic.h>
#include <lib_symbol.h>
#include <sch_symbol.h>
#include <pin_map.h>
#include <drawing_sheet/ds_draw_item.h>
#include <drawing_sheet/ds_proxy_view_item.h>
#include <vector>
#include <wx/ffile.h>
#include <sim/sim_lib_mgr.h>
#include <progress_reporter.h>
#include <kiway.h>
#include <pgm_base.h>
#include <libraries/symbol_library_adapter.h>
#include <trace_helpers.h>
#include <variant_symbol_utils.h>
 
 
/* ERC tests :
 *  1 - conflicts between connected pins ( example: 2 connected outputs )
 *  2 - minimal connections requirements ( 1 input *must* be connected to an
 * output, or a passive pin )
 */
 
/*
 *  Minimal ERC requirements:
 *  All pins *must* be connected (except ELECTRICAL_PINTYPE::PT_NC).
 *  When a pin is not connected in schematic, the user must place a "non
 * connected" symbol to this pin.
 *  This ensures a forgotten connection will be detected.
 */
 
// Messages for matrix rows:
const wxString CommentERC_H[] =
{
    _( "Input Pin" ),
    _( "Output Pin" ),
    _( "Bidirectional Pin" ),
    _( "Tri-State Pin" ),
    _( "Passive Pin" ),
    _( "Free Pin" ),
    _( "Unspecified Pin" ),
    _( "Power Input Pin" ),
    _( "Power Output Pin" ),
    _( "Open Collector" ),
    _( "Open Emitter" ),
    _( "No Connection" )
};
 
// Messages for matrix columns
const wxString CommentERC_V[] =
{
    _( "Input Pin" ),
    _( "Output Pin" ),
    _( "Bidirectional Pin" ),
    _( "Tri-State Pin" ),
    _( "Passive Pin" ),
    _( "Free Pin" ),
    _( "Unspecified Pin" ),
    _( "Power Input Pin" ),
    _( "Power Output Pin" ),
    _( "Open Collector" ),
    _( "Open Emitter" ),
    _( "No Connection" )
};
 
 
// List of pin types that are considered drivers for usual input pins
// i.e. pin type = ELECTRICAL_PINTYPE::PT_INPUT, but not PT_POWER_IN
// that need only a PT_POWER_OUT pin type to be driven
const std::set<ELECTRICAL_PINTYPE> DrivingPinTypes =
{
    ELECTRICAL_PINTYPE::PT_OUTPUT,
    ELECTRICAL_PINTYPE::PT_POWER_OUT,
    ELECTRICAL_PINTYPE::PT_PASSIVE,
    ELECTRICAL_PINTYPE::PT_TRISTATE,
    ELECTRICAL_PINTYPE::PT_BIDI
};
 
// List of pin types that are considered drivers for power pins
// In fact only a ELECTRICAL_PINTYPE::PT_POWER_OUT pin type can drive
// power input pins
const std::set<ELECTRICAL_PINTYPE> DrivingPowerPinTypes =
{
    ELECTRICAL_PINTYPE::PT_POWER_OUT
};
 
// List of pin types that require a driver elsewhere on the net
const std::set<ELECTRICAL_PINTYPE> DrivenPinTypes =
{
    ELECTRICAL_PINTYPE::PT_INPUT,
    ELECTRICAL_PINTYPE::PT_POWER_IN
};
 
extern void CheckDuplicatePins( LIB_SYMBOL* aSymbol, std::vector<wxString>& aMessages,
                                UNITS_PROVIDER* aUnitsProvider );
 
int ERC_TESTER::TestDuplicateSheetNames( bool aCreateMarker )
{
    int err_count = 0;
 
    for( SCH_SCREEN* screen = m_screens.GetFirst(); screen; screen = m_screens.GetNext() )
    {
        std::vector<SCH_SHEET*> list;
 
        for( SCH_ITEM* item : screen->Items().OfType( SCH_SHEET_T ) )
            list.push_back( static_cast<SCH_SHEET*>( item ) );
 
        for( size_t i = 0; i < list.size(); i++ )
        {
            SCH_SHEET* sheet = list[i];
 
            for( size_t j = i + 1; j < list.size(); j++ )
            {
                SCH_SHEET* test_item = list[j];
 
                // We have found a second sheet: compare names
                // we are using case insensitive comparison to avoid mistakes between
                // similar names like Mysheet and mysheet
                if( sheet->GetShownName( false ).IsSameAs( test_item->GetShownName( false ), false ) )
                {
                    if( aCreateMarker )
                    {
                        auto ercItem = ERC_ITEM::Create( ERCE_DUPLICATE_SHEET_NAME );
                        ercItem->SetItems( sheet, test_item );
 
                        SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), sheet->GetPosition() );
                        screen->Append( marker );
                    }
 
                    err_count++;
                }
            }
        }
    }
 
    return err_count;
}
 
 
int ERC_TESTER::TestPinMap( KIFACE* aCvPcb, PROJECT* aProject )
{
    int        errors = 0;
    const bool checkStale = m_settings.IsTestEnabled( ERCE_PIN_MAP_STALE_PIN );
    const bool checkDuplicate = m_settings.IsTestEnabled( ERCE_PIN_MAP_DUPLICATE_PAD );
    const bool checkBadPad = m_settings.IsTestEnabled( ERCE_PIN_MAP_BAD_PAD );
 
    typedef void ( *PAD_NUMBERS_FN_PTR )( const wxString&, PROJECT*, std::set<wxString>& );
 
    PAD_NUMBERS_FN_PTR padFetcher =
            aCvPcb ? (PAD_NUMBERS_FN_PTR) aCvPcb->IfaceOrAddress( KIFACE_FOOTPRINT_PAD_NUMBERS ) : nullptr;
 
    std::map<wxString, std::set<wxString>> padCache;
 
    auto getPads = [&]( const wxString& aFootprintId ) -> const std::set<wxString>&
    {
        auto it = padCache.find( aFootprintId );
 
        if( it != padCache.end() )
            return it->second;
 
        std::set<wxString>& pads = padCache[aFootprintId];
 
        if( padFetcher && !aFootprintId.IsEmpty() )
            padFetcher( aFootprintId, aProject, pads );
 
        return pads;
    };
 
    // Pin maps and the symbol's pin numbers are library-symbol properties, so iterate unique
    // screens (not sheet paths) to avoid double-reporting on reused hierarchical sheets.
    for( SCH_SCREEN* screen = m_screens.GetFirst(); screen; screen = m_screens.GetNext() )
    {
        for( SCH_ITEM* item : screen->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
            LIB_SYMBOL* lib = symbol->GetLibSymbolRef().get();
 
            if( !lib )
                continue;
 
            const PIN_MAP_SET& maps = lib->GetEffectivePinMaps();
 
            if( maps.IsEmpty() )
                continue;
 
            std::set<wxString> pinNumbers;
 
            for( const SCH_PIN* pin : lib->GetPins() )
                pinNumbers.insert( pin->GetNumber() );
 
            const std::vector<std::set<wxString>>& jumperGroups = lib->JumperPinGroups();
 
            auto sharesJumperGroup = [&]( const wxString& aPinA, const wxString& aPinB )
            {
                for( const std::set<wxString>& group : jumperGroups )
                {
                    if( group.count( aPinA ) && group.count( aPinB ) )
                        return true;
                }
 
                return false;
            };
 
            for( const PIN_MAP& map : maps.GetAll() )
            {
                if( checkStale )
                {
                    for( const PIN_MAP_ENTRY& entry : map.GetEntries() )
                    {
                        if( pinNumbers.count( entry.m_PinNumber ) )
                            continue;
 
                        std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_PIN_MAP_STALE_PIN );
                        ercItem->SetItems( symbol );
                        ercItem->SetErrorMessage(
                                wxString::Format( _( "Pin map '%s' references unknown symbol pin '%s'" ), map.GetName(),
                                                  entry.m_PinNumber ) );
                        screen->Append( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
                        errors++;
                    }
                }
 
                // A single pin stacked across several pads is allowed. Two pins on one pad is not.
                if( checkDuplicate )
                {
                    std::map<wxString, wxString> padToPin;
 
                    for( const PIN_MAP_ENTRY& entry : map.GetEntries() )
                    {
                        for( const wxString& pad : ExpandStackedPinNotation( entry.m_PadNumber ) )
                        {
                            auto it = padToPin.find( pad );
 
                            if( it == padToPin.end() )
                            {
                                padToPin[pad] = entry.m_PinNumber;
                            }
                            else if( it->second != entry.m_PinNumber
                                     && !sharesJumperGroup( it->second, entry.m_PinNumber ) )
                            {
                                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_PIN_MAP_DUPLICATE_PAD );
                                ercItem->SetItems( symbol );
                                ercItem->SetErrorMessage(
                                        wxString::Format( _( "Symbol pins '%s' and '%s' both map to pad '%s'" ),
                                                          it->second, entry.m_PinNumber, pad ) );
                                screen->Append( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
                                errors++;
                            }
                        }
                    }
                }
            }
 
            if( checkBadPad && padFetcher )
            {
                for( const ASSOCIATED_FOOTPRINT& assoc : lib->GetEffectiveAssociatedFootprints() )
                {
                    const PIN_MAP* boundMap = maps.FindByName( assoc.m_MapName );
 
                    if( !boundMap )
                        continue;
 
                    const std::set<wxString>& pads = getPads( assoc.m_FootprintLibId.GetUniStringLibId() );
 
                    if( pads.empty() )
                        continue;
 
                    for( const PIN_MAP_ENTRY& entry : boundMap->GetEntries() )
                    {
                        for( const wxString& pad : ExpandStackedPinNotation( entry.m_PadNumber ) )
                        {
                            if( pads.count( pad ) )
                                continue;
 
                            std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_PIN_MAP_BAD_PAD );
                            ercItem->SetItems( symbol );
                            ercItem->SetErrorMessage( wxString::Format(
                                    _( "Pin map '%s' references pad '%s' not present on footprint '%s'" ),
                                    boundMap->GetName(), pad, assoc.m_FootprintLibId.GetUniStringLibId() ) );
                            screen->Append( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
                            errors++;
                        }
                    }
                }
            }
        }
    }
 
    if( m_settings.IsTestEnabled( ERCE_PIN_MAP_UNMAPPED_PIN ) && padFetcher )
    {
        const wxString variant = m_schematic ? m_schematic->GetCurrentVariant() : wxString();
 
        for( SCH_SHEET_PATH& sheet : m_sheetList )
        {
            for( SCH_ITEM* item : sheet.LastScreen()->Items().OfType( SCH_SYMBOL_T ) )
            {
                SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
                LIB_SYMBOL* lib = symbol->GetLibSymbolRef().get();
 
                if( !lib || lib->GetEffectiveAssociatedFootprints().empty() )
                    continue;
 
                wxString fpText = symbol->GetFootprintFieldText( true, &sheet, false );
                LIB_ID   fpId;
 
                if( fpText.IsEmpty() || fpId.Parse( fpText, true ) >= 0 )
                    continue;
 
                const std::set<wxString>& pads = getPads( fpId.GetUniStringLibId() );
 
                if( pads.empty() )
                    continue;
 
                for( SCH_PIN* pin : symbol->GetPins( &sheet ) )
                {
                    if( pin->IsDangling() )
                        continue;
 
                    SCH_PIN::PAD_RESOLUTION state = SCH_PIN::PAD_RESOLUTION::MAPPED;
                    pin->GetEffectivePadNumber( sheet, variant, fpId, &pads, &state );
 
                    if( state != SCH_PIN::PAD_RESOLUTION::UNMAPPED )
                        continue;
 
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_PIN_MAP_UNMAPPED_PIN );
                    ercItem->SetItems( pin );
                    ercItem->SetErrorMessage(
                            wxString::Format( _( "Pin '%s' is connected but maps to no pad on footprint '%s'" ),
                                              pin->GetNumber(), fpText ) );
                    sheet.LastScreen()->Append( new SCH_MARKER( std::move( ercItem ), pin->GetPosition() ) );
                    errors++;
                }
            }
        }
    }
 
    return errors;
}
 
 
void ERC_TESTER::TestTextVars( DS_PROXY_VIEW_ITEM* aDrawingSheet )
{
    DS_DRAW_ITEM_LIST wsItems( schIUScale, FOR_ERC_DRC );
 
    auto unresolved =
            [this]( wxString str )
            {
                str = ExpandEnvVarSubstitutions( str, &m_schematic->Project() );
                return str.Matches( wxS( "*${*}*" ) );
            };
 
    auto testAssertion =
            []( const SCH_ITEM* item, const SCH_SHEET_PATH& sheet, SCH_SCREEN* screen,
                const wxString& text, const VECTOR2I& pos )
            {
                // Match anywhere in the text so users can embed ${ERC_ERROR ...}
                // or ${ERC_WARNING ...} inside placeholder strings rather than
                // only at the start of the field.  The leading "(^|[^\\\\])"
                // group requires the marker to start the string or follow a
                // non-backslash, so `\${ERC_ERROR ...}` stays inert; the
                // captured message is group 2.
                static wxRegEx warningExpr( wxS( "(^|[^\\\\])\\$\\{ERC_WARNING\\s*([^}]*)\\}" ) );
                static wxRegEx errorExpr( wxS( "(^|[^\\\\])\\$\\{ERC_ERROR\\s*([^}]*)\\}" ) );
 
                auto reportEach =
                        [&]( wxRegEx& aExpr, int aErrorCode )
                        {
                            // Return true on any *match*, not only when a marker is appended,
                            // so the caller-side unresolved-variable suppression stays
                            // correct even if the limit-exceeded short-circuit lands here in
                            // the future.
                            bool     found = false;
                            wxString remaining = text;
 
                            while( aExpr.Matches( remaining ) )
                            {
                                found = true;
 
                                wxString ercText = aExpr.GetMatch( remaining, 2 );
 
                                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( aErrorCode );
 
                                if( item )
                                    ercItem->SetItems( item );
                                else
                                    ercText += _( " (in drawing sheet)" );
 
                                ercItem->SetSheetSpecificPath( sheet );
                                ercItem->SetErrorMessage( ercText );
 
                                SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pos );
                                screen->Append( marker );
 
                                size_t start = 0;
                                size_t len = 0;
 
                                if( !aExpr.GetMatch( &start, &len, 0 ) || len == 0 )
                                    break;
 
                                remaining = remaining.Mid( start + len );
                            }
 
                            return found;
                        };
 
                bool foundWarning = reportEach( warningExpr, ERCE_GENERIC_WARNING );
                bool foundError = reportEach( errorExpr, ERCE_GENERIC_ERROR );
 
                return foundWarning || foundError;
            };
 
    if( aDrawingSheet )
    {
        wsItems.SetPageNumber( wxS( "1" ) );
        wsItems.SetSheetCount( 1 );
        wsItems.SetFileName( wxS( "dummyFilename" ) );
        wsItems.SetSheetName( wxS( "dummySheet" ) );
        wsItems.SetSheetLayer( wxS( "dummyLayer" ) );
        wsItems.SetProject( &m_schematic->Project() );
        wsItems.BuildDrawItemsList( aDrawingSheet->GetPageInfo(), aDrawingSheet->GetTitleBlock() );
    }
 
    for( const SCH_SHEET_PATH& sheet : m_sheetList )
    {
        SCH_SCREEN* screen = sheet.LastScreen();
 
        for( SCH_ITEM* item : screen->Items().OfType( SCH_LOCATE_ANY_T ) )
        {
            if( item->Type() == SCH_SYMBOL_T )
            {
                SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
 
                for( SCH_FIELD& field : symbol->GetFields() )
                {
                    if( testAssertion( &field, sheet, screen, field.GetText(), field.GetPosition() ) )
                    {
                        // Don't run unresolved test
                    }
                    else if( unresolved( field.GetShownText( &sheet, true ) ) )
                    {
                        auto ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
                        ercItem->SetItems( symbol );
                        ercItem->SetSheetSpecificPath( sheet );
 
                        SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), field.GetPosition() );
                        screen->Append( marker );
                    }
                }
 
                if( symbol->GetLibSymbolRef() )
                {
                    symbol->GetLibSymbolRef()->RunOnChildren(
                            [&]( SCH_ITEM* child )
                            {
                                if( child->Type() == SCH_FIELD_T )
                                {
                                    // test only SCH_SYMBOL fields, not LIB_SYMBOL fields
                                }
                                else if( child->Type() == SCH_TEXT_T )
                                {
                                    SCH_TEXT* textItem = static_cast<SCH_TEXT*>( child );
 
                                    if( testAssertion( symbol, sheet, screen, textItem->GetText(),
                                                       textItem->GetPosition() ) )
                                    {
                                        // Don't run unresolved test
                                    }
                                    else if( unresolved( textItem->GetShownText( &sheet, true ) ) )
                                    {
                                        auto ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
                                        ercItem->SetItems( symbol );
                                        ercItem->SetSheetSpecificPath( sheet );
 
                                        BOX2I bbox = textItem->GetBoundingBox();
                                        bbox = symbol->GetTransform().TransformCoordinate( bbox );
                                        VECTOR2I pos = bbox.Centre() + symbol->GetPosition();
 
                                        SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pos );
                                        screen->Append( marker );
                                    }
                                }
                                else if( child->Type() == SCH_TEXTBOX_T )
                                {
                                    SCH_TEXTBOX* textboxItem = static_cast<SCH_TEXTBOX*>( child );
 
                                    if( testAssertion( symbol, sheet, screen, textboxItem->GetText(),
                                                       textboxItem->GetPosition() ) )
                                    {
                                        // Don't run unresolved test
                                    }
                                    else if( unresolved( textboxItem->GetShownText( nullptr, &sheet,
                                                                                    true ) ) )
                                    {
                                        auto ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
                                        ercItem->SetItems( symbol );
                                        ercItem->SetSheetSpecificPath( sheet );
 
                                        BOX2I bbox = textboxItem->GetBoundingBox();
                                        bbox = symbol->GetTransform().TransformCoordinate( bbox );
                                        VECTOR2I pos = bbox.Centre() + symbol->GetPosition();
 
                                        SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pos );
                                        screen->Append( marker );
                                    }
                                }
                            },
                            RECURSE_MODE::NO_RECURSE );
                }
            }
            else if( SCH_LABEL_BASE* label = dynamic_cast<SCH_LABEL_BASE*>( item ) )
            {
                for( SCH_FIELD& field : label->GetFields() )
                {
                    if( testAssertion( &field, sheet, screen, field.GetText(), field.GetPosition() ) )
                    {
                        // Don't run unresolved test
                    }
                    else if( unresolved( field.GetShownText( &sheet, true ) ) )
                    {
                        auto ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
                        ercItem->SetItems( label );
                        ercItem->SetSheetSpecificPath( sheet );
 
                        SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), field.GetPosition() );
                        screen->Append( marker );
                    }
                }
            }
            else if( item->Type() == SCH_SHEET_T )
            {
                SCH_SHEET* subSheet = static_cast<SCH_SHEET*>( item );
 
                for( SCH_FIELD& field : subSheet->GetFields() )
                {
                    if( testAssertion( &field, sheet, screen, field.GetText(), field.GetPosition() ) )
                    {
                        // Don't run unresolved test
                    }
                    else if( unresolved( field.GetShownText( &sheet, true ) ) )
                    {
                        auto ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
                        ercItem->SetItems( subSheet );
                        ercItem->SetSheetSpecificPath( sheet );
 
                        SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), field.GetPosition() );
                        screen->Append( marker );
                    }
                }
 
                SCH_SHEET_PATH subSheetPath = sheet;
                subSheetPath.push_back( subSheet );
 
                for( SCH_SHEET_PIN* pin : subSheet->GetPins() )
                {
                    if( pin->GetShownText( &subSheetPath, true ).Matches( wxS( "*${*}*" ) ) )
                    {
                        auto ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
                        ercItem->SetItems( pin );
                        ercItem->SetSheetSpecificPath( sheet );
 
                        SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pin->GetPosition() );
                        screen->Append( marker );
                    }
                }
            }
            else if( SCH_TEXT* text = dynamic_cast<SCH_TEXT*>( item ) )
            {
                if( testAssertion( text, sheet, screen, text->GetText(), text->GetPosition() ) )
                {
                    // Don't run unresolved test
                }
                else if( text->GetShownText( &sheet, true ).Matches( wxS( "*${*}*" ) ) )
                {
                    auto ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
                    ercItem->SetItems( text );
                    ercItem->SetSheetSpecificPath( sheet );
 
                    SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), text->GetPosition() );
                    screen->Append( marker );
                }
            }
            else if( SCH_TEXTBOX* textBox = dynamic_cast<SCH_TEXTBOX*>( item ) )
            {
                if( testAssertion( textBox, sheet, screen, textBox->GetText(),
                                   textBox->GetPosition() ) )
                {
                    // Don't run unresolved test
                }
                else if( textBox->GetShownText( nullptr, &sheet, true ).Matches( wxS( "*${*}*" ) ) )
                {
                    auto ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
                    ercItem->SetItems( textBox );
                    ercItem->SetSheetSpecificPath( sheet );
 
                    SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), textBox->GetPosition() );
                    screen->Append( marker );
                }
            }
        }
 
        for( DS_DRAW_ITEM_BASE* item = wsItems.GetFirst(); item; item = wsItems.GetNext() )
        {
            if( DS_DRAW_ITEM_TEXT* text = dynamic_cast<DS_DRAW_ITEM_TEXT*>( item ) )
            {
                if( testAssertion( nullptr, sheet, screen, text->GetText(), text->GetPosition() ) )
                {
                    // Don't run unresolved test
                }
                else if( text->GetShownText( true ).Matches( wxS( "*${*}*" ) ) )
                {
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_UNRESOLVED_VARIABLE );
                    ercItem->SetErrorMessage( _( "Unresolved text variable in drawing sheet" ) );
                    ercItem->SetSheetSpecificPath( sheet );
 
                    SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), text->GetPosition() );
                    screen->Append( marker );
                }
            }
        }
    }
}
 
 
int ERC_TESTER::TestEmptyLabelNames()
{
    int errors = 0;
 
    // No directive labels, they carry no text (the netclass lives in a field)
    static const KICAD_T labelTypes[] = { SCH_LABEL_T, SCH_GLOBAL_LABEL_T, SCH_HIER_LABEL_T };
 
    for( const SCH_SHEET_PATH& sheet : m_sheetList )
    {
        SCH_SCREEN* screen = sheet.LastScreen();
 
        for( KICAD_T labelType : labelTypes )
        {
            for( SCH_ITEM* item : screen->Items().OfType( labelType ) )
            {
                SCH_LABEL_BASE* label = static_cast<SCH_LABEL_BASE*>( item );
 
                wxString text = label->GetText();
                text.Trim( false ).Trim( true );
 
                if( text.IsEmpty() )
                {
                    auto ercItem = ERC_ITEM::Create( ERCE_EMPTY_LABEL_NAME );
                    ercItem->SetItems( label );
                    ercItem->SetItemsSheetPaths( sheet );
                    ercItem->SetSheetSpecificPath( sheet );
 
                    SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), label->GetPosition() );
                    screen->Append( marker );
                    errors++;
                }
            }
        }
    }
 
    return errors;
}
 
 
int ERC_TESTER::TestFieldNameWhitespace()
{
    int warnings = 0;
 
    for( const SCH_SHEET_PATH& sheet : m_sheetList )
    {
        SCH_SCREEN* screen = sheet.LastScreen();
 
        for( SCH_ITEM* item : screen->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
 
            for( SCH_FIELD& field : symbol->GetFields() )
            {
                wxString trimmedFieldName = field.GetName();
                trimmedFieldName.Trim();
                trimmedFieldName.Trim( false );
 
                if( field.GetName() != trimmedFieldName )
                {
                    auto ercItem = ERC_ITEM::Create( ERCE_FIELD_NAME_WHITESPACE );
                    ercItem->SetItems( symbol, &field );
                    ercItem->SetItemsSheetPaths( sheet, sheet );
                    ercItem->SetSheetSpecificPath( sheet );
                    ercItem->SetErrorMessage(
                            wxString::Format(
                                    _( "Field name has leading or trailing whitespace: '%s'" ),
                                    field.GetName() ) );
 
                    SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), field.GetPosition() );
                    screen->Append( marker );
                    warnings++;
                }
            }
        }
 
        for( SCH_ITEM* item : screen->Items().OfType( SCH_SHEET_T ) )
        {
            SCH_SHEET* subSheet = static_cast<SCH_SHEET*>( item );
 
            for( SCH_FIELD& field : subSheet->GetFields() )
            {
                wxString trimmedFieldName = field.GetName();
                trimmedFieldName.Trim();
                trimmedFieldName.Trim( false );
 
                if( field.GetName() != trimmedFieldName )
                {
                    auto ercItem = ERC_ITEM::Create( ERCE_FIELD_NAME_WHITESPACE );
                    ercItem->SetItems( subSheet, &field );
                    ercItem->SetItemsSheetPaths( sheet, sheet );
                    ercItem->SetSheetSpecificPath( sheet );
                    ercItem->SetErrorMessage(
                            wxString::Format(
                                    _( "Field name has leading or trailing whitespace: '%s'" ),
                                    field.GetName() ) );
 
                    SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), field.GetPosition() );
                    screen->Append( marker );
                    warnings++;
                }
            }
        }
    }
 
    return warnings;
}
 
 
int ERC_TESTER::TestMultiunitFootprints()
{
    int errors = 0;
 
    for( std::pair<const wxString, SCH_REFERENCE_LIST>& symbol : m_refMap )
    {
        SCH_REFERENCE_LIST& refList = symbol.second;
 
        if( refList.GetCount() == 0 )
        {
            wxFAIL;   // it should not happen
            continue;
        }
 
        // Reference footprint
        SCH_SYMBOL* unit = nullptr;
        wxString    unitName;
        wxString    unitFP;
 
        for( size_t ii = 0; ii < refList.GetCount(); ++ii )
        {
            SCH_SHEET_PATH sheetPath = refList.GetItem( ii ).GetSheetPath();
            unitFP = refList.GetItem( ii ).GetFootprint();
 
            if( !unitFP.IsEmpty() )
            {
                unit = refList.GetItem( ii ).GetSymbol();
                unitName = unit->GetRef( &sheetPath, true );
                break;
            }
        }
 
        for( size_t ii = 0; ii < refList.GetCount(); ++ii )
        {
            SCH_REFERENCE& secondRef = refList.GetItem( ii );
            SCH_SYMBOL*    secondUnit = secondRef.GetSymbol();
            wxString       secondName = secondUnit->GetRef( &secondRef.GetSheetPath(), true );
            const wxString secondFp = secondRef.GetFootprint();
            wxString       msg;
 
            if( unit && !secondFp.IsEmpty() && unitFP != secondFp )
            {
                msg.Printf( _( "Different footprints assigned to %s and %s" ),
                            unitName, secondName );
 
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_DIFFERENT_UNIT_FP );
                ercItem->SetErrorMessage( msg );
                ercItem->SetItems( unit, secondUnit );
 
                SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), secondUnit->GetPosition() );
                secondRef.GetSheetPath().LastScreen()->Append( marker );
 
                ++errors;
            }
        }
    }
 
    return errors;
}
 
 
int ERC_TESTER::TestMissingUnits()
{
    int errors = 0;
 
    for( std::pair<const wxString, SCH_REFERENCE_LIST>& symbol : m_refMap )
    {
        SCH_REFERENCE_LIST& refList = symbol.second;
 
        wxCHECK2( refList.GetCount(), continue );
 
        // Reference unit
        SCH_REFERENCE& base_ref = refList.GetItem( 0 );
        SCH_SYMBOL* unit = base_ref.GetSymbol();
        LIB_SYMBOL* libSymbol = base_ref.GetLibPart();
 
        if( static_cast<ssize_t>( refList.GetCount() ) == libSymbol->GetUnitCount() )
            continue;
 
        std::set<int> lib_units;
        std::set<int> instance_units;
        std::set<int> missing_units;
 
        auto report =
                [&]( std::set<int>& aMissingUnits, const wxString& aErrorMsg, int aErrorCode )
                {
                    wxString msg;
                    wxString missing_pin_units = wxS( "[ " );
                    int ii = 0;
 
                    for( int missing_unit : aMissingUnits )
                    {
                        if( ii++ == 3 )
                        {
                            missing_pin_units += wxS( "..." );
                            break;
                        }
 
                        missing_pin_units += libSymbol->GetUnitDisplayName( missing_unit, false ) + ", " ;
                    }
 
                    missing_pin_units.Truncate( missing_pin_units.length() - 2 );
                    missing_pin_units += wxS( " ]" );
 
                    msg.Printf( aErrorMsg, symbol.first, missing_pin_units );
 
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( aErrorCode );
                    ercItem->SetErrorMessage( msg );
                    ercItem->SetItems( unit );
                    ercItem->SetSheetSpecificPath( base_ref.GetSheetPath() );
                    ercItem->SetItemsSheetPaths( base_ref.GetSheetPath() );
 
                    SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), unit->GetPosition() );
                    base_ref.GetSheetPath().LastScreen()->Append( marker );
 
                    ++errors;
                };
 
        for( int ii = 1; ii <= libSymbol->GetUnitCount(); ++ii )
            lib_units.insert( lib_units.end(), ii );
 
        for( size_t ii = 0; ii < refList.GetCount(); ++ii )
            instance_units.insert( instance_units.end(), refList.GetItem( ii ).GetUnit() );
 
        std::set_difference( lib_units.begin(), lib_units.end(),
                             instance_units.begin(), instance_units.end(),
                             std::inserter( missing_units, missing_units.begin() ) );
 
        if( !missing_units.empty() && m_settings.IsTestEnabled( ERCE_MISSING_UNIT ) )
        {
            report( missing_units, _( "Symbol %s has unplaced units %s" ), ERCE_MISSING_UNIT );
        }
 
        std::set<int> missing_power;
        std::set<int> missing_input;
        std::set<int> missing_bidi;
 
        for( int missing_unit : missing_units )
        {
            int bodyStyle = 0;
 
            for( size_t ii = 0; ii < refList.GetCount(); ++ii )
            {
                if( refList.GetItem( ii ).GetUnit() == missing_unit )
                {
                    bodyStyle = refList.GetItem( ii ).GetSymbol()->GetBodyStyle();
                    break;
                }
            }
 
            for( SCH_PIN* pin : libSymbol->GetGraphicalPins( missing_unit, bodyStyle ) )
            {
                switch( pin->GetType() )
                {
                case ELECTRICAL_PINTYPE::PT_POWER_IN:
                    missing_power.insert( missing_unit );
                    break;
 
                case ELECTRICAL_PINTYPE::PT_BIDI:
                    missing_bidi.insert( missing_unit );
                    break;
 
                case ELECTRICAL_PINTYPE::PT_INPUT:
                    missing_input.insert( missing_unit );
                    break;
 
                default:
                    break;
                }
            }
        }
 
        if( !missing_power.empty() && m_settings.IsTestEnabled( ERCE_MISSING_POWER_INPUT_PIN ) )
        {
            report( missing_power, _( "Symbol %s has input power pins in units %s that are not placed" ),
                    ERCE_MISSING_POWER_INPUT_PIN );
        }
 
        if( !missing_input.empty() && m_settings.IsTestEnabled( ERCE_MISSING_INPUT_PIN ) )
        {
           report( missing_input, _( "Symbol %s has input pins in units %s that are not placed" ),
                   ERCE_MISSING_INPUT_PIN );
        }
 
        if( !missing_bidi.empty() && m_settings.IsTestEnabled( ERCE_MISSING_BIDI_PIN ) )
        {
            report( missing_bidi, _( "Symbol %s has bidirectional pins in units %s that are not placed" ),
                    ERCE_MISSING_BIDI_PIN );
        }
    }
 
    return errors;
}
 
 
int ERC_TESTER::TestMissingNetclasses()
{
    int                            err_count = 0;
    std::shared_ptr<NET_SETTINGS>& settings = m_schematic->Project().GetProjectFile().NetSettings();
    wxString                       defaultNetclass = settings->GetDefaultNetclass()->GetName();
 
    auto logError =
            [&]( const SCH_SHEET_PATH& sheet, SCH_ITEM* item, const wxString& netclass )
            {
                err_count++;
 
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_UNDEFINED_NETCLASS );
 
                ercItem->SetItems( item );
                ercItem->SetErrorMessage( wxString::Format( _( "Netclass %s is not defined" ), netclass ) );
 
                SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), item->GetPosition() );
                sheet.LastScreen()->Append( marker );
            };
 
    for( const SCH_SHEET_PATH& sheet : m_sheetList )
    {
        for( SCH_ITEM* item : sheet.LastScreen()->Items() )
        {
            item->RunOnChildren(
                    [&]( SCH_ITEM* aChild )
                    {
                        if( aChild->Type() == SCH_FIELD_T )
                        {
                            SCH_FIELD* field = static_cast<SCH_FIELD*>( aChild );
 
                            if( field->GetCanonicalName() == wxT( "Netclass" ) )
                            {
                                wxString netclass = field->GetShownText( &sheet, false );
 
                                if( !netclass.empty() && !netclass.IsSameAs( defaultNetclass )
                                    && !settings->HasNetclass( netclass ) )
                                {
                                    logError( sheet, item, netclass );
                                }
                            }
                        }
 
                        return true;
                    },
                RECURSE_MODE::NO_RECURSE );
        }
    }
 
    return err_count;
}
 
 
int ERC_TESTER::TestLabelMultipleWires()
{
    int err_count = 0;
 
    for( const SCH_SHEET_PATH& sheet : m_sheetList )
    {
        std::map<VECTOR2I, std::vector<SCH_ITEM*>> connMap;
 
        for( SCH_ITEM* item : sheet.LastScreen()->Items().OfType( SCH_LABEL_T ) )
        {
            SCH_LABEL* label = static_cast<SCH_LABEL*>( item );
 
            for( const VECTOR2I& pt : label->GetConnectionPoints() )
                connMap[pt].emplace_back( label );
        }
 
        for( const std::pair<const VECTOR2I, std::vector<SCH_ITEM*>>& pair : connMap )
        {
            std::vector<SCH_ITEM*> lines;
 
            for( SCH_ITEM* item : sheet.LastScreen()->Items().Overlapping( SCH_LINE_T, pair.first ) )
            {
                SCH_LINE* line = static_cast<SCH_LINE*>( item );
 
                if( line->IsGraphicLine() )
                    continue;
 
                // If the line is connected at the endpoint, then there will be a junction
                if( !line->IsEndPoint( pair.first ) )
                    lines.emplace_back( line );
            }
 
            if( lines.size() > 1 )
            {
                err_count++;
                lines.resize( 3 ); // Only show the first 3 lines and if there are only two, adds a nullptr
 
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_LABEL_MULTIPLE_WIRES );
                wxString msg = wxString::Format( _( "Label connects more than one wire at %d, %d" ),
                                                 pair.first.x, pair.first.y );
 
                ercItem->SetItems( pair.second.front(), lines[0], lines[1], lines[2] );
                ercItem->SetErrorMessage( msg );
                ercItem->SetSheetSpecificPath( sheet );
 
                SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pair.first );
                sheet.LastScreen()->Append( marker );
            }
        }
    }
 
    return err_count;
}
 
 
int ERC_TESTER::TestFourWayJunction()
{
    int err_count = 0;
 
    auto pinStackAlreadyRepresented =
            []( SCH_PIN* pin, std::vector<SCH_ITEM*>& collection ) -> bool
            {
                for( SCH_ITEM*& item : collection )
                {
                    if( item->Type() == SCH_PIN_T && item->GetParentSymbol() == pin->GetParentSymbol() )
                    {
                        if( pin->IsVisible() && !static_cast<SCH_PIN*>( item )->IsVisible() )
                            item = pin;
 
                        return true;
                    }
                }
 
                return false;
            };
 
    for( const SCH_SHEET_PATH& sheet : m_sheetList )
    {
        std::map<VECTOR2I, std::vector<SCH_ITEM*>> connMap;
        SCH_SCREEN* screen = sheet.LastScreen();
 
        for( SCH_ITEM* item : screen->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
 
            for( SCH_PIN* pin : symbol->GetPins( &sheet ) )
            {
                std::vector<SCH_ITEM*>& entry = connMap[pin->GetPosition()];
 
                // Only one pin per pin-stack.
                if( pinStackAlreadyRepresented( pin, entry ) )
                    continue;
 
                entry.emplace_back( pin );
            }
        }
 
        for( SCH_ITEM* item : screen->Items().OfType( SCH_LINE_T ) )
        {
            SCH_LINE* line = static_cast<SCH_LINE*>( item );
 
            if( line->IsGraphicLine() )
                continue;
 
            for( const VECTOR2I& pt : line->GetConnectionPoints() )
                connMap[pt].emplace_back( line );
        }
 
        for( const std::pair<const VECTOR2I, std::vector<SCH_ITEM*>>& pair : connMap )
        {
            if( pair.second.size() >= 4 )
            {
                err_count++;
 
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_FOUR_WAY_JUNCTION );
 
                ercItem->SetItems( pair.second[0], pair.second[1], pair.second[2], pair.second[3] );
 
                wxString msg = wxString::Format( _( "Four items connected at %d, %d" ),
                                                 pair.first.x, pair.first.y );
                ercItem->SetErrorMessage( msg );
 
                ercItem->SetSheetSpecificPath( sheet );
 
                SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pair.first );
                sheet.LastScreen()->Append( marker );
            }
        }
    }
 
    return err_count;
}
 
 
int ERC_TESTER::TestNoConnectPins()
{
    int err_count = 0;
 
    for( const SCH_SHEET_PATH& sheet : m_sheetList )
    {
        std::map<VECTOR2I, std::vector<SCH_ITEM*>> pinMap;
 
        auto addOther =
                [&]( const VECTOR2I& pt, SCH_ITEM* aOther )
                {
                    if( pinMap.count( pt ) )
                        pinMap[pt].emplace_back( aOther );
                };
 
        for( SCH_ITEM* item : sheet.LastScreen()->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
 
            for( SCH_PIN* pin : symbol->GetPins( &sheet ) )
            {
                if( pin->GetType() == ELECTRICAL_PINTYPE::PT_NC )
                    pinMap[pin->GetPosition()].emplace_back( pin );
            }
        }
 
        for( SCH_ITEM* item : sheet.LastScreen()->Items() )
        {
            if( item->Type() == SCH_SYMBOL_T )
            {
                SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
 
                for( SCH_PIN* pin : symbol->GetPins( &sheet ) )
                {
                    if( pin->GetType() != ELECTRICAL_PINTYPE::PT_NC )
                        addOther( pin->GetPosition(), pin );
                }
            }
            else if( item->IsConnectable() && item->Type() != SCH_NO_CONNECT_T )
            {
                for( const VECTOR2I& pt : item->GetConnectionPoints() )
                    addOther( pt, item );
            }
        }
 
        for( const std::pair<const VECTOR2I, std::vector<SCH_ITEM*>>& pair : pinMap )
        {
            if( pair.second.size() > 1 )
            {
                bool all_nc = true;
 
                for( SCH_ITEM* item : pair.second )
                {
                    if( item->Type() != SCH_PIN_T )
                    {
                        all_nc = false;
                        break;
                    }
 
                    SCH_PIN* pin = static_cast<SCH_PIN*>( item );
 
                    if( pin->GetType() != ELECTRICAL_PINTYPE::PT_NC )
                    {
                        all_nc = false;
                        break;
                    }
                }
 
                if( all_nc )
                    continue;
 
                err_count++;
 
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_NOCONNECT_CONNECTED );
 
                ercItem->SetItems( pair.second[0], pair.second[1],
                                   pair.second.size() > 2 ? pair.second[2] : nullptr,
                                   pair.second.size() > 3 ? pair.second[3] : nullptr );
                ercItem->SetErrorMessage( _( "Pin with 'no connection' type is connected" ) );
                ercItem->SetSheetSpecificPath( sheet );
 
                SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pair.first );
                sheet.LastScreen()->Append( marker );
            }
        }
    }
 
    return err_count;
}
 
 
int ERC_TESTER::TestPinToPin()
{
    int errors = 0;
 
    // Map each net name to the pins (with sheet context) found on that net so we can later
    // perform cross-net compatibility checks for grouped net chains.
    std::unordered_map<wxString, std::vector<ERC_SCH_PIN_CONTEXT>> netToPins;
 
    for( const std::pair<NET_NAME_CODE_CACHE_KEY, std::vector<CONNECTION_SUBGRAPH*>> net : m_nets )
    {
        using iterator_t = std::vector<ERC_SCH_PIN_CONTEXT>::iterator;
        std::vector<ERC_SCH_PIN_CONTEXT>           pins;
        std::unordered_map<EDA_ITEM*, SCH_SCREEN*> pinToScreenMap;
        bool has_noconnect = false;
 
        for( CONNECTION_SUBGRAPH* subgraph: net.second )
        {
            if( subgraph->GetNoConnect() )
                has_noconnect = true;
 
            for( SCH_ITEM* item : subgraph->GetItems() )
            {
                if( item->Type() == SCH_PIN_T )
                {
                    pins.emplace_back( static_cast<SCH_PIN*>( item ), subgraph->GetSheet() );
                    netToPins[ net.first.Name ].emplace_back( static_cast<SCH_PIN*>( item ), subgraph->GetSheet() );
                    pinToScreenMap[item] = subgraph->GetSheet().LastScreen();
                }
            }
        }
 
        std::sort( pins.begin(), pins.end(),
                   []( const ERC_SCH_PIN_CONTEXT& lhs, const ERC_SCH_PIN_CONTEXT& rhs )
                   {
                       int ret = StrNumCmp( lhs.Pin()->GetParentSymbol()->GetRef( &lhs.Sheet() ),
                                            rhs.Pin()->GetParentSymbol()->GetRef( &rhs.Sheet() ) );
 
                       if( ret == 0 )
                           ret = StrNumCmp( lhs.Pin()->GetNumber(), rhs.Pin()->GetNumber() );
 
                       if( ret == 0 )
                           ret = lhs < rhs; // Fallback to hash to guarantee deterministic sort
 
                       return ret < 0;
                   } );
 
        ERC_SCH_PIN_CONTEXT needsDriver;
        ELECTRICAL_PINTYPE  needsDriverType = ELECTRICAL_PINTYPE::PT_UNSPECIFIED;
        bool                hasDriver = false;
        std::vector<ERC_SCH_PIN_CONTEXT*> pinsNeedingDrivers;
        std::vector<ERC_SCH_PIN_CONTEXT*> nonPowerPinsNeedingDrivers;
        std::vector<ERC_SCH_PIN_CONTEXT*> powerInPinsNeedingDrivers;
 
        // We need different drivers for power nets and normal nets.
        // A power net has at least one pin having the ELECTRICAL_PINTYPE::PT_POWER_IN
        // and power nets can be driven only by ELECTRICAL_PINTYPE::PT_POWER_OUT pins
        bool     ispowerNet  = false;
 
        for( ERC_SCH_PIN_CONTEXT& refPin : pins )
        {
            if( refPin.Pin()->GetType() == ELECTRICAL_PINTYPE::PT_POWER_IN )
            {
                ispowerNet = true;
                break;
            }
        }
 
        std::vector<std::tuple<iterator_t, iterator_t, PIN_ERROR>> pin_mismatches;
        std::map<iterator_t, int>                                  pin_mismatch_counts;
 
        for( auto refIt = pins.begin(); refIt != pins.end(); ++refIt )
        {
            ERC_SCH_PIN_CONTEXT& refPin = *refIt;
            ELECTRICAL_PINTYPE refType = refPin.Pin()->GetType();
 
            if( DrivenPinTypes.contains( refType ) )
            {
                // needsDriver will be the pin shown in the error report eventually, so try to
                // upgrade to a "better" pin if possible: something visible and only a power symbol
                // if this net needs a power driver
                pinsNeedingDrivers.push_back( &refPin );
 
                if( !refPin.Pin()->IsPower() )
                    nonPowerPinsNeedingDrivers.push_back( &refPin );
 
                if( refType == ELECTRICAL_PINTYPE::PT_POWER_IN )
                    powerInPinsNeedingDrivers.push_back( &refPin );
 
                if( !needsDriver.Pin()
                    || ( !needsDriver.Pin()->IsVisible() && refPin.Pin()->IsVisible() )
                    || ( ispowerNet != ( needsDriverType == ELECTRICAL_PINTYPE::PT_POWER_IN )
                         && ispowerNet == ( refType == ELECTRICAL_PINTYPE::PT_POWER_IN ) ) )
                {
                    needsDriver = refPin;
                    needsDriverType = needsDriver.Pin()->GetType();
                }
            }
 
            if( ispowerNet )
                hasDriver |= ( DrivingPowerPinTypes.count( refType ) != 0 );
            else
                hasDriver |= ( DrivingPinTypes.count( refType ) != 0 );
 
            for( auto testIt = refIt + 1; testIt != pins.end(); ++testIt )
            {
                ERC_SCH_PIN_CONTEXT& testPin = *testIt;
 
                // Multiple pins in the same symbol that share a type,
                // name and position are considered
                // "stacked" and shouldn't trigger ERC errors
                if( refPin.Pin()->IsStacked( testPin.Pin() ) && refPin.Sheet() == testPin.Sheet() )
                    continue;
 
                ELECTRICAL_PINTYPE testType = testPin.Pin()->GetType();
 
                if( ispowerNet )
                    hasDriver |= DrivingPowerPinTypes.contains( testType );
                else
                    hasDriver |= DrivingPinTypes.contains( testType );
 
                PIN_ERROR erc = m_settings.GetPinMapValue( refType, testType );
 
                ERCE_T ercCode = ( erc == PIN_ERROR::WARNING ) ? ERCE_PIN_TO_PIN_WARNING
                                                                       : ERCE_PIN_TO_PIN_ERROR;
 
                if( erc != PIN_ERROR::OK && m_settings.IsTestEnabled( ercCode ) )
                {
                    pin_mismatches.emplace_back( std::tuple<iterator_t, iterator_t, PIN_ERROR>{ refIt, testIt, erc } );
 
                    if( m_settings.GetERCSortingMetric() == ERC_PIN_SORTING_METRIC::SM_HEURISTICS )
                    {
                        pin_mismatch_counts[refIt] = m_settings.GetPinTypeWeight( ( *refIt ).Pin()->GetType() );
                        pin_mismatch_counts[testIt] = m_settings.GetPinTypeWeight( ( *testIt ).Pin()->GetType() );
                    }
                    else
                    {
                        if( !pin_mismatch_counts.contains( testIt ) )
                            pin_mismatch_counts.emplace( testIt, 1 );
                        else
                            pin_mismatch_counts[testIt]++;
 
                        if( !pin_mismatch_counts.contains( refIt ) )
                            pin_mismatch_counts.emplace( refIt, 1 );
                        else
                            pin_mismatch_counts[refIt]++;
                    }
                }
            }
        }
 
        std::multimap<size_t, iterator_t, std::greater<size_t>> pins_dsc;
 
        std::transform( pin_mismatch_counts.begin(), pin_mismatch_counts.end(),
                        std::inserter( pins_dsc, pins_dsc.begin() ),
                        []( const auto& p )
                        {
                            return std::pair<size_t, iterator_t>( p.second, p.first );
                        } );
 
        for( const auto& [amount, pinItBind] : pins_dsc )
        {
            auto& pinIt = pinItBind;
 
            if( pin_mismatches.empty() )
                break;
 
            SCH_PIN* pin = ( *pinIt ).Pin();
            VECTOR2I position = pin->GetPosition();
 
            iterator_t nearest_pin = pins.end();
            double     smallest_distance = std::numeric_limits<double>::infinity();
            PIN_ERROR  erc;
 
            std::erase_if(
                    pin_mismatches,
                    [&]( const auto& tuple )
                    {
                        iterator_t other;
 
                        if( pinIt == std::get<0>( tuple ) )
                            other = std::get<1>( tuple );
                        else if( pinIt == std::get<1>( tuple ) )
                            other = std::get<0>( tuple );
                        else
                            return false;
 
                        if( ( *pinIt ).Sheet().Cmp( ( *other ).Sheet() ) != 0 )
                        {
                            if( std::isinf( smallest_distance ) )
                            {
                                nearest_pin = other;
                                erc = std::get<2>( tuple );
                            }
                        }
                        else
                        {
                            double distance = position.Distance( ( *other ).Pin()->GetPosition() );
 
                            if( std::isinf( smallest_distance ) || distance < smallest_distance )
                            {
                                smallest_distance = distance;
                                nearest_pin = other;
                                erc = std::get<2>( tuple );
                            }
                        }
 
                        return true;
                    } );
 
            if( nearest_pin != pins.end() )
            {
                SCH_PIN* other_pin = ( *nearest_pin ).Pin();
 
                auto ercItem = ERC_ITEM::Create( erc == PIN_ERROR::WARNING ? ERCE_PIN_TO_PIN_WARNING
                                                                           : ERCE_PIN_TO_PIN_ERROR );
                ercItem->SetItems( pin, other_pin );
                ercItem->SetSheetSpecificPath( ( *pinIt ).Sheet() );
                ercItem->SetItemsSheetPaths( ( *pinIt ).Sheet(), ( *nearest_pin ).Sheet() );
 
                ercItem->SetErrorMessage( wxString::Format( _( "Pins of type %s and %s are connected" ),
                                                            ElectricalPinTypeGetText( pin->GetType() ),
                                                            ElectricalPinTypeGetText( other_pin->GetType() ) ) );
 
                SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pin->GetPosition() );
                pinToScreenMap[pin]->Append( marker );
                errors++;
            }
        }
 
        if( needsDriver.Pin() && !hasDriver && !has_noconnect )
        {
            int err_code = ispowerNet ? ERCE_POWERPIN_NOT_DRIVEN : ERCE_PIN_NOT_DRIVEN;
 
            // NEW: For power nets, before reporting a not-driven error, look across the
            // net chain (multi-net chain formed via passives) to see if there is a
            // power driver pin on any other net in the same chain. If so, suppress the
            // error because the net chain as a whole is driven.
            bool suppressForNetChainDriver = false;
 
            if( ispowerNet && m_schematic && m_schematic->ConnectionGraph() )
            {
                const wxString& thisNetName = net.first.Name;
                const auto& netChains = m_schematic->ConnectionGraph()->GetCommittedNetChains();
 
                auto netHasPowerDriver = [&]( const wxString& aNetName ) -> bool
                {
                    // Scan m_nets for the named net and test its pins for a power driver type.
                    for( const auto& n : m_nets )
                    {
                        if( n.first.Name != aNetName )
                            continue;
 
                        for( CONNECTION_SUBGRAPH* sg : n.second )
                        {
                            for( SCH_ITEM* item : sg->GetItems() )
                            {
                                if( item->Type() == SCH_PIN_T )
                                {
                                    SCH_PIN* p = static_cast<SCH_PIN*>( item );
                                    if( DrivingPowerPinTypes.contains( p->GetType() ) )
                                        return true;
                                }
                            }
                        }
 
                        break; // found matching net (whether driver or not)
                    }
 
                    return false;
                };
 
                for( const auto& sig : netChains )
                {
                    if( !sig )
                        continue;
 
                    const auto& sigNets = sig->GetNets();
                    bool containsThisNet = std::find( sigNets.begin(), sigNets.end(), thisNetName ) != sigNets.end();
 
                    if( !containsThisNet )
                        continue;
 
                    // Look for a different net in this chain that has a power driver.
                    for( const wxString& otherNet : sigNets )
                    {
                        if( otherNet == thisNetName )
                            continue; // skip same net (we already know it lacks a driver)
 
                        if( netHasPowerDriver( otherNet ) )
                        {
                            suppressForNetChainDriver = true;
                            break;
                        }
                    }
 
                    break; // examined the containing chain
                }
            }
 
            if( !suppressForNetChainDriver && m_settings.IsTestEnabled( err_code ) )
            {
                std::vector<ERC_SCH_PIN_CONTEXT*> pinsToMark;
 
                // The marker should land on a pin matching the error message: for an
                // ERCE_POWERPIN_NOT_DRIVEN error mark a PT_POWER_IN pin (which is what the
                // error refers to), for ERCE_PIN_NOT_DRIVEN prefer a pin that is not on a
                // power symbol so the marker is anchored to the consuming pin rather than
                // a power flag.
                if( m_showAllErrors )
                {
                    if( ispowerNet && !powerInPinsNeedingDrivers.empty() )
                        pinsToMark = powerInPinsNeedingDrivers;
                    else if( !nonPowerPinsNeedingDrivers.empty() )
                        pinsToMark = nonPowerPinsNeedingDrivers;
                    else
                        pinsToMark = pinsNeedingDrivers;
                }
                else
                {
                    if( ispowerNet && !powerInPinsNeedingDrivers.empty() )
                        pinsToMark.push_back( powerInPinsNeedingDrivers.front() );
                    else
                        pinsToMark.push_back( &needsDriver );
                }
 
                for( ERC_SCH_PIN_CONTEXT* pinCtx : pinsToMark )
                {
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( err_code );
 
                    ercItem->SetItems( pinCtx->Pin() );
                    ercItem->SetSheetSpecificPath( pinCtx->Sheet() );
                    ercItem->SetItemsSheetPaths( pinCtx->Sheet() );
 
                    SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pinCtx->Pin()->GetPosition() );
                    pinToScreenMap[pinCtx->Pin()]->Append( marker );
                    errors++;
                }
            }
        }
    }
 
    // --- Additional net-chain-level checking ---
    // If a pin participates in a grouped net chain (spanning multiple nets via passives), ensure
    // that all other pins reachable through that chain are electrically compatible even if
    // they reside on different nets.
    // We only consider pairs on DIFFERENT nets here to avoid duplicating existing net-level
    // mismatches already reported above.
    if( m_schematic && m_schematic->ConnectionGraph() )
    {
        auto& netChains = m_schematic->ConnectionGraph()->GetCommittedNetChains();
        wxLogTrace( traceSchNetChain, "ERC TestPinToPin: cross-chain phase start chains=%zu",
                    netChains.size() );
 
        for( const auto& sig : netChains )
        {
            if( !sig )
                continue;
 
            const wxString chainName = sig->GetName();
            const auto& sigNets = sig->GetNets();
 
            // Collect all pin contexts across the nets in this chain.
            std::vector<ERC_SCH_PIN_CONTEXT> netChainPins;
            netChainPins.reserve( sigNets.size() * 4 );
 
            for( const wxString& n : sigNets )
            {
                auto it = netToPins.find( n );
                if( it != netToPins.end() )
                {
                    const auto& vec = it->second;
                    netChainPins.insert( netChainPins.end(), vec.begin(), vec.end() );
                }
            }
 
            if( netChainPins.size() < 2 )
                continue; // nothing to compare
 
            wxLogTrace( traceSchNetChain,
                        "ERC TestPinToPin: chain '%s' nets=%zu collectedPins=%zu",
                        TO_UTF8( chainName ), sigNets.size(), netChainPins.size() );
 
            // For deterministic behavior, sort by reference/pin number similar to earlier pass.
            std::sort( netChainPins.begin(), netChainPins.end(),
                       []( const ERC_SCH_PIN_CONTEXT& lhs, const ERC_SCH_PIN_CONTEXT& rhs )
                       {
                           int ret = StrNumCmp( lhs.Pin()->GetParentSymbol()->GetRef( &lhs.Sheet() ),
                                                rhs.Pin()->GetParentSymbol()->GetRef( &rhs.Sheet() ) );
                           if( ret == 0 )
                               ret = StrNumCmp( lhs.Pin()->GetNumber(), rhs.Pin()->GetNumber() );
                           if( ret == 0 )
                               ret = lhs < rhs;
                           return ret < 0;
                       } );
 
            // Build a quick map from pin -> net name for skipping intra-net pairs.
            std::unordered_map<SCH_PIN*, wxString> pinNet;
            for( const auto& netEntry : netToPins )
                for( const auto& ctx : netEntry.second )
                    pinNet[ ctx.Pin() ] = netEntry.first;
 
            for( size_t i = 0; i < netChainPins.size(); ++i )
            {
                SCH_PIN* aPin = netChainPins[i].Pin();
                ELECTRICAL_PINTYPE aType = aPin->GetType();
                const wxString& aNet = pinNet[aPin];
 
                for( size_t j = i + 1; j < netChainPins.size(); ++j )
                {
                    SCH_PIN* bPin = netChainPins[j].Pin();
                    const wxString& bNet = pinNet[bPin];
 
                    if( aNet == bNet )
                        continue; // already handled at net-level
 
                    ELECTRICAL_PINTYPE bType = bPin->GetType();
                    PIN_ERROR erc = m_settings.GetPinMapValue( aType, bType );
 
                    ERCE_T ercCode = ( erc == PIN_ERROR::WARNING ) ? ERCE_PIN_TO_PIN_WARNING
                                                                           : ERCE_PIN_TO_PIN_ERROR;
 
                    if( erc != PIN_ERROR::OK && m_settings.IsTestEnabled( ercCode ) )
                    {
                        std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ercCode );
 
                        ercItem->SetItems( aPin, bPin );
                        ercItem->SetSheetSpecificPath( netChainPins[i].Sheet() );
                        ercItem->SetItemsSheetPaths( netChainPins[i].Sheet(), netChainPins[j].Sheet() );
                        ercItem->SetErrorMessage( wxString::Format(
                                _( "Pins of type %s and %s are connected via net chain %s" ),
                                ElectricalPinTypeGetText( aType ),
                                ElectricalPinTypeGetText( bType ), chainName ) );
 
                        SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), aPin->GetPosition() );
                        netChainPins[i].Sheet().LastScreen()->Append( marker );
                        errors++;
                    }
                }
            }
        }
    }
 
    return errors;
}
 
 
int ERC_TESTER::TestMultUnitPinConflicts()
{
    int errors = 0;
 
    std::unordered_map<wxString, std::pair<wxString, SCH_PIN*>> pinToNetMap;
 
    for( const std::pair<NET_NAME_CODE_CACHE_KEY, std::vector<CONNECTION_SUBGRAPH*>> net : m_nets )
    {
        const wxString& netName = net.first.Name;
 
        for( CONNECTION_SUBGRAPH* subgraph : net.second )
        {
            for( SCH_ITEM* item : subgraph->GetItems() )
            {
                if( item->Type() == SCH_PIN_T )
                {
                    SCH_PIN* pin = static_cast<SCH_PIN*>( item );
                    const SCH_SHEET_PATH& sheet = subgraph->GetSheet();
 
                    if( !pin->GetParentSymbol()->IsMultiUnit() )
                        continue;
 
                    wxString name = pin->GetParentSymbol()->GetRef( &sheet ) + ":" + pin->GetShownNumber();
 
                    if( !pinToNetMap.count( name ) )
                    {
                        pinToNetMap[name] = std::make_pair( netName, pin );
                    }
                    else if( pinToNetMap[name].first != netName )
                    {
                        std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_DIFFERENT_UNIT_NET );
 
                        ercItem->SetErrorMessage( wxString::Format( _( "Pin %s is connected to both %s and %s" ),
                                                                    pin->GetShownNumber(),
                                                                    netName,
                                                                    pinToNetMap[name].first ) );
 
                        ercItem->SetItems( pin, pinToNetMap[name].second );
                        ercItem->SetSheetSpecificPath( sheet );
                        ercItem->SetItemsSheetPaths( sheet, sheet );
 
                        SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pin->GetPosition() );
                        sheet.LastScreen()->Append( marker );
                        errors += 1;
                    }
                }
            }
        }
    }
 
    return errors;
}
 
 
int ERC_TESTER::TestDuplicatePinNets()
{
    int errors = 0;
 
    for( const SCH_SHEET_PATH& sheet : m_sheetList )
    {
        SCH_SCREEN* screen = sheet.LastScreen();
 
        for( SCH_ITEM* item : screen->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
            LIB_SYMBOL* libSymbol = symbol->GetLibSymbolRef().get();
 
            if( !libSymbol )
                continue;
 
            if( libSymbol->GetDuplicatePinNumbersAreJumpers() )
                continue;
 
            std::vector<SCH_PIN*> pins = symbol->GetPins( &sheet );
 
            std::map<wxString, std::vector<std::pair<SCH_PIN*, wxString>>> pinsByNumber;
 
            for( SCH_PIN* pin : pins )
            {
                SCH_CONNECTION* conn = pin->Connection( &sheet );
                wxString        netName = conn ? conn->GetNetName() : wxString();
 
                pinsByNumber[pin->GetNumber()].emplace_back( pin, netName );
            }
 
            for( const auto& [pinNumber, pinNetPairs] : pinsByNumber )
            {
                if( pinNetPairs.size() < 2 )
                    continue;
 
                wxString firstNet = pinNetPairs[0].second;
                bool     hasDifferentNets = false;
                SCH_PIN* conflictPin = nullptr;
 
                for( size_t i = 1; i < pinNetPairs.size(); i++ )
                {
                    if( pinNetPairs[i].second != firstNet )
                    {
                        hasDifferentNets = true;
                        conflictPin = pinNetPairs[i].first;
                        break;
                    }
                }
 
                if( hasDifferentNets )
                {
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_DUPLICATE_PIN_ERROR );
                    wxString msg;
 
                    msg.Printf( _( "Pin %s on symbol '%s' is connected to different nets: %s and %s" ),
                                pinNumber,
                                symbol->GetRef( &sheet ),
                                firstNet.IsEmpty() ? _( "<no net>" ) : firstNet,
                                pinNetPairs[1].second.IsEmpty() ? _( "<no net>" ) : pinNetPairs[1].second );
 
                    ercItem->SetErrorMessage( msg );
                    ercItem->SetItems( pinNetPairs[0].first, conflictPin );
                    ercItem->SetSheetSpecificPath( sheet );
                    ercItem->SetItemsSheetPaths( sheet, sheet );
 
                    SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ),
                                                         pinNetPairs[0].first->GetPosition() );
                    screen->Append( marker );
                    errors++;
                }
            }
        }
    }
 
    return errors;
}
 
 
int ERC_TESTER::TestGroundPins()
{
    int errors = 0;
 
    auto isGround =
            []( const wxString& txt )
            {
                wxString upper = txt.Upper();
 
                return upper.Contains( wxT( "GND" ) )
                       || upper == wxT( "EARTH" ) || upper.StartsWith( wxT( "EARTH_" ) )
                       || upper == wxT( "VSS" ) || upper == wxT( "VSSA" );
            };
 
    for( const SCH_SHEET_PATH& sheet : m_sheetList )
    {
        SCH_SCREEN* screen = sheet.LastScreen();
 
        for( SCH_ITEM* item : screen->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
            bool        hasGroundNet = false;
            std::vector<SCH_PIN*> mismatched;
 
            for( SCH_PIN* pin : symbol->GetPins( &sheet ) )
            {
                SCH_CONNECTION* conn = pin->Connection( &sheet );
                wxString        net = conn ? conn->GetNetName() : wxString();
                bool            netIsGround = isGround( net );
 
                // We are only interested in power pins
                if( pin->GetType() != ELECTRICAL_PINTYPE::PT_POWER_OUT
                    && pin->GetType() != ELECTRICAL_PINTYPE::PT_POWER_IN )
                {
                    continue;
                }
 
                if( netIsGround )
                    hasGroundNet = true;
 
                if( isGround( pin->GetShownName() ) && !netIsGround )
                    mismatched.push_back( pin );
            }
 
            if( hasGroundNet )
            {
                for( SCH_PIN* pin : mismatched )
                {
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_GROUND_PIN_NOT_GROUND );
 
                    ercItem->SetErrorMessage( wxString::Format( _( "Pin %s not connected to ground net" ),
                                                                pin->GetShownName() ) );
                    ercItem->SetItems( pin );
                    ercItem->SetSheetSpecificPath( sheet );
                    ercItem->SetItemsSheetPaths( sheet );
 
                    SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pin->GetPosition() );
                    screen->Append( marker );
                    errors++;
                }
            }
        }
    }
 
    return errors;
}
 
 
int ERC_TESTER::TestStackedPinNotation()
{
    int warnings = 0;
 
    for( const SCH_SHEET_PATH& sheet : m_sheetList )
    {
        SCH_SCREEN* screen = sheet.LastScreen();
 
        for( SCH_ITEM* item : screen->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
 
            for( SCH_PIN* pin : symbol->GetPins( &sheet ) )
            {
                bool valid;
                pin->GetStackedPinNumbers( &valid );
 
                if( !valid )
                {
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_STACKED_PIN_SYNTAX );
                    ercItem->SetItems( pin );
                    ercItem->SetSheetSpecificPath( sheet );
                    ercItem->SetItemsSheetPaths( sheet );
 
                    SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), pin->GetPosition() );
                    screen->Append( marker );
                    warnings++;
                }
            }
        }
    }
 
    return warnings;
}
 
 
int ERC_TESTER::TestSameLocalGlobalLabel()
{
    int errCount = 0;
 
    std::unordered_map<wxString, std::pair<SCH_ITEM*, SCH_SHEET_PATH>> globalLabels;
    std::unordered_map<wxString, std::pair<SCH_ITEM*, SCH_SHEET_PATH>> localLabels;
 
    for( const std::pair<NET_NAME_CODE_CACHE_KEY, std::vector<CONNECTION_SUBGRAPH*>> net : m_nets )
    {
        for( CONNECTION_SUBGRAPH* subgraph : net.second )
        {
            const SCH_SHEET_PATH& sheet = subgraph->GetSheet();
 
            for( SCH_ITEM* item : subgraph->GetItems() )
            {
                if( item->Type() == SCH_LABEL_T || item->Type() == SCH_GLOBAL_LABEL_T )
                {
                    SCH_LABEL_BASE* label = static_cast<SCH_LABEL_BASE*>( item );
                    wxString        text = label->GetShownText( &sheet, false );
 
                    auto& map = item->Type() == SCH_LABEL_T ? localLabels : globalLabels;
 
                    if( !map.count( text ) )
                    {
                        map[text] = std::make_pair( label, sheet );
                    }
                }
                else if( item->Type() == SCH_PIN_T )
                {
                    SCH_PIN* pin = static_cast<SCH_PIN*>( item );
 
                    if( !pin->IsPower() )
                        continue;
 
                    SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( pin->GetParentSymbol() );
 
                    if( !symbol )
                        continue;
 
                    wxString text = ( pin->IsGlobalPower() && !symbol->IsGlobalPower() )
                                            ? pin->GetShownName()
                                            : symbol->GetValue( true, &sheet, false );
 
                    auto& map = pin->IsGlobalPower() ? globalLabels : localLabels;
 
                    if( !map.count( text ) )
                    {
                        map[text] = std::make_pair( pin, sheet );
                    }
                }
            }
        }
    }
 
    for( auto& [globalText, globalItem] : globalLabels )
    {
        for( auto& [localText, localItem] : localLabels )
        {
            if( globalText == localText )
            {
                ERCE_T errorCode = ( globalItem.first->Type() == SCH_PIN_T && localItem.first->Type() == SCH_PIN_T )
                                           ? ERCE_SAME_LOCAL_GLOBAL_POWER
                                           : ERCE_SAME_LOCAL_GLOBAL_LABEL;
 
                if( !m_settings.IsTestEnabled( errorCode ) )
                    continue;
 
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( errorCode );
                ercItem->SetItems( globalItem.first, localItem.first );
                ercItem->SetSheetSpecificPath( globalItem.second );
                ercItem->SetItemsSheetPaths( globalItem.second, localItem.second );
 
                SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), globalItem.first->GetPosition() );
                globalItem.second.LastScreen()->Append( marker );
 
                errCount++;
            }
        }
    }
 
    return errCount;
}
 
 
int ERC_TESTER::TestSimilarLabels()
{
    int errors = 0;
    std::unordered_map<wxString, std::vector<std::tuple<wxString, SCH_ITEM*, SCH_SHEET_PATH>>> generalMap;
 
    auto logError =
            [&]( const wxString& normalized, SCH_ITEM* item, const SCH_SHEET_PATH& sheet,
                 const std::tuple<wxString, SCH_ITEM*, SCH_SHEET_PATH>& other )
            {
                auto& [otherText, otherItem, otherSheet] = other;
                ERCE_T typeOfWarning = ERCE_SIMILAR_LABELS;
 
                if( item->Type() == SCH_PIN_T && otherItem->Type() == SCH_PIN_T )
                {
                    //Two Pins
                    typeOfWarning = ERCE_SIMILAR_POWER;
                }
                else if( item->Type() == SCH_PIN_T || otherItem->Type() == SCH_PIN_T )
                {
                    //Pin and Label
                    typeOfWarning = ERCE_SIMILAR_LABEL_AND_POWER;
                }
                else
                {
                    //Two Labels
                    typeOfWarning = ERCE_SIMILAR_LABELS;
                }
 
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( typeOfWarning );
                ercItem->SetItems( item, otherItem );
                ercItem->SetSheetSpecificPath( sheet );
                ercItem->SetItemsSheetPaths( sheet, otherSheet );
 
                SCH_MARKER* marker = new SCH_MARKER( std::move( ercItem ), item->GetPosition() );
                sheet.LastScreen()->Append( marker );
            };
 
    for( const std::pair<NET_NAME_CODE_CACHE_KEY, std::vector<CONNECTION_SUBGRAPH*>> net : m_nets )
    {
        for( CONNECTION_SUBGRAPH* subgraph : net.second )
        {
            const SCH_SHEET_PATH& sheet = subgraph->GetSheet();
 
            for( SCH_ITEM* item : subgraph->GetItems() )
            {
                switch( item->Type() )
                {
                case SCH_LABEL_T:
                case SCH_HIER_LABEL_T:
                case SCH_GLOBAL_LABEL_T:
                {
                    SCH_LABEL_BASE* label = static_cast<SCH_LABEL_BASE*>( item );
                    wxString        unnormalized = label->GetShownText( &sheet, false );
                    wxString        normalized = unnormalized.Lower();
 
                    generalMap[normalized].emplace_back( std::make_tuple( unnormalized, label, sheet ) );
 
                    for( const auto& otherTuple : generalMap.at( normalized ) )
                    {
                        const auto& [otherText, otherItem, otherSheet] = otherTuple;
 
                        if( unnormalized != otherText )
                        {
                            // Similar local labels on different sheets are fine
                            if( item->Type() == SCH_LABEL_T && otherItem->Type() == SCH_LABEL_T
                                    && sheet != otherSheet )
                            {
                                continue;
                            }
 
                            logError( normalized, label, sheet, otherTuple );
                            errors += 1;
                        }
                    }
 
                    break;
                }
                case SCH_PIN_T:
                {
                    SCH_PIN* pin = static_cast<SCH_PIN*>( item );
 
                    if( !pin->IsPower() )
                        continue;
 
                    SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( pin->GetParentSymbol() );
                    wxString    unnormalized = symbol->GetValue( true, &sheet, false );
                    wxString    normalized = unnormalized.Lower();
 
                    generalMap[normalized].emplace_back( std::make_tuple( unnormalized, pin, sheet ) );
 
                    for( const auto& otherTuple : generalMap.at( normalized ) )
                    {
                        const auto& [otherText, otherItem, otherSheet] = otherTuple;
 
                        if( unnormalized != otherText )
                        {
                            logError( normalized, pin, sheet, otherTuple );
                            errors += 1;
                        }
                    }
 
                    break;
                }
 
                default:
                    break;
                }
            }
        }
    }
 
    return errors;
}
 
 
int ERC_TESTER::TestLibSymbolIssues()
{
    wxCHECK( m_schematic, 0 );
 
    LIBRARY_MANAGER& manager = Pgm().GetLibraryManager();
    SYMBOL_LIBRARY_ADAPTER* adapter = PROJECT_SCH::SymbolLibAdapter( &m_schematic->Project() );
    wxString          msg;
    int               err_count = 0;
 
    for( SCH_SCREEN* screen = m_screens.GetFirst(); screen; screen = m_screens.GetNext() )
    {
        std::vector<SCH_MARKER*> markers;
 
        for( SCH_ITEM* item : screen->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
            LIB_SYMBOL* libSymbolInSchematic = symbol->GetLibSymbolRef().get();
 
            if( !libSymbolInSchematic )
                continue;
 
            wxString libName = symbol->GetLibId().GetLibNickname();
 
            std::optional<const LIBRARY_TABLE_ROW*> optRow =
                    manager.GetRow( LIBRARY_TABLE_TYPE::SYMBOL, libName );
 
            if( !optRow || ( *optRow )->Disabled() )
            {
                if( m_settings.IsTestEnabled( ERCE_LIB_SYMBOL_ISSUES ) )
                {
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_LIB_SYMBOL_ISSUES );
                    ercItem->SetItems( symbol );
                    msg.Printf( _( "The current configuration does not include the symbol library '%s'" ),
                                UnescapeString( libName ) );
                    ercItem->SetErrorMessage( msg );
 
                    markers.emplace_back( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
                }
 
                continue;
            }
            else if( !adapter->IsLibraryLoaded( libName ) )
            {
                if( m_settings.IsTestEnabled( ERCE_LIB_SYMBOL_ISSUES ) )
                {
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_LIB_SYMBOL_ISSUES );
                    std::optional<wxString> uri =
                            manager.GetFullURI( LIBRARY_TABLE_TYPE::SYMBOL, libName, true );
                    wxCHECK2( uri.has_value(), uri = wxEmptyString );
                    ercItem->SetItems( symbol );
                    msg.Printf( _( "The symbol library '%s' was not found at '%s'" ),
                                UnescapeString( libName ), *uri );
                    ercItem->SetErrorMessage( msg );
 
                    markers.emplace_back( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
                }
 
                continue;
            }
 
            wxString    symbolName = symbol->GetLibId().GetLibItemName();
            LIB_SYMBOL* libSymbol = adapter->LoadSymbol( symbol->GetLibId() );
 
            if( libSymbol == nullptr )
            {
                if( m_settings.IsTestEnabled( ERCE_LIB_SYMBOL_ISSUES ) )
                {
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_LIB_SYMBOL_ISSUES );
                    ercItem->SetItems( symbol );
                    msg.Printf( _( "Symbol '%s' not found in symbol library '%s'" ),
                                UnescapeString( symbolName ),
                                UnescapeString( libName ) );
                    ercItem->SetErrorMessage( msg );
 
                    markers.emplace_back( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
                }
 
                continue;
            }
 
            std::unique_ptr<LIB_SYMBOL> flattenedSymbol = libSymbol->Flatten();
            constexpr int flags = SCH_ITEM::COMPARE_FLAGS::EQUALITY | SCH_ITEM::COMPARE_FLAGS::ERC;
 
            if( m_settings.IsTestEnabled( ERCE_LIB_SYMBOL_MISMATCH ) )
            {
                // We have to check for duplicate pins first as they will cause Compare() to fail.
                // Symbols with duplicate pins are valid if those pins share the same net, so we
                // only skip the comparison here. The actual error checking for duplicate pins on
                // different nets is done in TestDuplicatePinNets().
                std::vector<wxString> messages;
 
                if( !libSymbolInSchematic->GetDuplicatePinNumbersAreJumpers() )
                {
                    UNITS_PROVIDER unitsProvider( schIUScale, EDA_UNITS::MILS );
                    CheckDuplicatePins( libSymbolInSchematic, messages, &unitsProvider );
                }
 
                if( messages.empty() && flattenedSymbol->Compare( *libSymbolInSchematic, flags ) != 0 )
                {
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_LIB_SYMBOL_MISMATCH );
                    ercItem->SetItems( symbol );
                    msg.Printf( _( "Symbol '%s' doesn't match copy in library '%s'" ),
                                UnescapeString( symbolName ),
                                UnescapeString( libName ) );
                    ercItem->SetErrorMessage( msg );
 
                    markers.emplace_back( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
                }
            }
        }
 
        for( SCH_MARKER* marker : markers )
        {
            screen->Append( marker );
            err_count += 1;
        }
    }
 
    return err_count;
}
 
 
int ERC_TESTER::TestFootprintLinkIssues( KIFACE* aCvPcb, PROJECT* aProject )
{
    wxCHECK( m_schematic, 0 );
 
    if( std::optional<LIBRARY_MANAGER_ADAPTER*> adapter =
                Pgm().GetLibraryManager().Adapter( LIBRARY_TABLE_TYPE::FOOTPRINT ) )
    {
        ( *adapter )->BlockUntilLoaded();
    }
 
    wxString msg;
    int      err_count = 0;
 
    typedef int (*TESTER_FN_PTR)( const wxString&, PROJECT* );
 
    TESTER_FN_PTR linkTester = (TESTER_FN_PTR) aCvPcb->IfaceOrAddress( KIFACE_TEST_FOOTPRINT_LINK );
 
    for( SCH_SHEET_PATH& sheet : m_sheetList )
    {
        std::vector<SCH_MARKER*> markers;
 
        for( SCH_ITEM* item : sheet.LastScreen()->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
            wxString    footprint = symbol->GetFootprintFieldText( true, &sheet, false );
 
            if( footprint.IsEmpty() )
                continue;
 
            LIB_ID fpID;
 
            if( fpID.Parse( footprint, true ) >= 0 )
            {
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_FOOTPRINT_LINK_ISSUES );
                msg.Printf( _( "'%s' is not a valid footprint identifier" ), footprint );
                ercItem->SetErrorMessage( msg );
                ercItem->SetItems( symbol );
                markers.emplace_back( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
                continue;
            }
 
            wxString libName = fpID.GetLibNickname();
            wxString fpName = fpID.GetLibItemName();
            int      ret = (linkTester)( footprint, aProject );
 
            if( ret == KIFACE_TEST_FOOTPRINT_LINK_NO_LIBRARY )
            {
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_FOOTPRINT_LINK_ISSUES );
                msg.Printf( _( "The current configuration does not include the footprint library '%s'" ),
                            libName );
                ercItem->SetErrorMessage( msg );
                ercItem->SetItems( symbol );
                markers.emplace_back( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
            }
            else if( ret == KIFACE_TEST_FOOTPRINT_LINK_LIBRARY_NOT_ENABLED )
            {
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_FOOTPRINT_LINK_ISSUES );
                msg.Printf( _( "The footprint library '%s' is not enabled in the current configuration" ),
                            libName );
                ercItem->SetErrorMessage( msg );
                ercItem->SetItems( symbol );
                markers.emplace_back( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
            }
            else if( ret == KIFACE_TEST_FOOTPRINT_LINK_NO_FOOTPRINT )
            {
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_FOOTPRINT_LINK_ISSUES );
                msg.Printf( _( "Footprint '%s' not found in library '%s'" ),
                            fpName,
                            libName );
                ercItem->SetErrorMessage( msg );
                ercItem->SetItems( symbol );
                markers.emplace_back( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
            }
        }
 
        for( SCH_MARKER* marker : markers )
        {
            sheet.LastScreen()->Append( marker );
            err_count += 1;
        }
    }
 
    return err_count;
}
 
 
int ERC_TESTER::TestFootprintFilters()
{
    wxCHECK( m_schematic, 0 );
 
    wxString msg;
    int      err_count = 0;
 
    for( SCH_SHEET_PATH& sheet : m_sheetList )
    {
        std::vector<SCH_MARKER*> markers;
 
        for( SCH_ITEM* item : sheet.LastScreen()->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL*                  sch_symbol = static_cast<SCH_SYMBOL*>( item );
            std::unique_ptr<LIB_SYMBOL>& lib_symbol = sch_symbol->GetLibSymbolRef();
 
            if( !lib_symbol )
                continue;
 
            wxArrayString filters = lib_symbol->GetFPFilters();
 
            if( filters.empty() )
                continue;
 
            wxString lowerId = sch_symbol->GetFootprintFieldText( true, &sheet, false ).Lower();
            LIB_ID   footprint;
 
            if( footprint.Parse( lowerId ) > 0 )
                continue;
 
            wxString lowerItemName = footprint.GetUniStringLibItemName().Lower();
            bool     found = false;
 
            for( wxString filter : filters )
            {
                filter.LowerCase();
 
                // If the filter contains a ':' character, include the library name in the pattern
                if( filter.Contains( wxS( ":" ) ) )
                    found |= lowerId.Matches( filter );
                else
                    found |= lowerItemName.Matches( filter );
 
                if( found )
                    break;
            }
 
            if( !found )
            {
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_FOOTPRINT_FILTERS );
                msg.Printf( _( "Assigned footprint (%s) doesn't match footprint filters (%s)" ),
                            footprint.GetUniStringLibItemName(),
                            wxJoin( filters, ' ' ) );
                ercItem->SetErrorMessage( msg );
                ercItem->SetItems( sch_symbol );
                markers.emplace_back( new SCH_MARKER( std::move( ercItem ), sch_symbol->GetPosition() ) );
            }
        }
 
        for( SCH_MARKER* marker : markers )
        {
            sheet.LastScreen()->Append( marker );
            err_count += 1;
        }
    }
 
    return err_count;
}
 
 
int ERC_TESTER::TestOffGridEndpoints()
{
    const int gridSize = m_schematic->Settings().m_ConnectionGridSize;
    int       err_count = 0;
 
    for( SCH_SCREEN* screen = m_screens.GetFirst(); screen; screen = m_screens.GetNext() )
    {
        std::vector<SCH_MARKER*> markers;
 
        for( SCH_ITEM* item : screen->Items() )
        {
            if( item->Type() == SCH_LINE_T && item->IsConnectable() )
            {
                SCH_LINE* line = static_cast<SCH_LINE*>( item );
 
                if( ( line->GetStartPoint().x % gridSize ) != 0
                        || ( line->GetStartPoint().y % gridSize ) != 0 )
                {
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_ENDPOINT_OFF_GRID );
                    ercItem->SetItems( line );
 
                    markers.emplace_back( new SCH_MARKER( std::move( ercItem ), line->GetStartPoint() ) );
                }
                else if( ( line->GetEndPoint().x % gridSize ) != 0
                            || ( line->GetEndPoint().y % gridSize ) != 0 )
                {
                    std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_ENDPOINT_OFF_GRID );
                    ercItem->SetItems( line );
 
                    markers.emplace_back( new SCH_MARKER( std::move( ercItem ), line->GetEndPoint() ) );
                }
            }
            if( item->Type() == SCH_BUS_WIRE_ENTRY_T )
            {
                SCH_BUS_WIRE_ENTRY* entry = static_cast<SCH_BUS_WIRE_ENTRY*>( item );
 
                for( const VECTOR2I& point : entry->GetConnectionPoints() )
                {
                    if( ( point.x % gridSize ) != 0
                        || ( point.y % gridSize ) != 0 )
                    {
                        std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_ENDPOINT_OFF_GRID );
                        ercItem->SetItems( entry );
 
                        markers.emplace_back( new SCH_MARKER( std::move( ercItem ), point ) );
                    }
                }
            }
            else if( item->Type() == SCH_SYMBOL_T )
            {
                SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
 
                for( SCH_PIN* pin : symbol->GetPins( nullptr ) )
                {
                    if( pin->GetType() == ELECTRICAL_PINTYPE::PT_NC )
                        continue;
 
                    VECTOR2I pinPos = pin->GetPosition();
 
                    if( ( pinPos.x % gridSize ) != 0 || ( pinPos.y % gridSize ) != 0 )
                    {
                        std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_ENDPOINT_OFF_GRID );
                        ercItem->SetItems( pin );
 
                        markers.emplace_back( new SCH_MARKER( std::move( ercItem ), pinPos ) );
                        break;
                    }
                }
            }
        }
 
        for( SCH_MARKER* marker : markers )
        {
            screen->Append( marker );
            err_count += 1;
        }
    }
 
    return err_count;
}
 
 
int ERC_TESTER::TestSimModelIssues()
{
    WX_STRING_REPORTER reporter;
    int                err_count = 0;
    SIM_LIB_MGR        libMgr( &m_schematic->Project() );
    wxString           variant = m_schematic->GetCurrentVariant();
 
    for( SCH_SHEET_PATH& sheet : m_sheetList )
    {
        if( sheet.GetExcludedFromSim( variant ) )
            continue;
 
        std::vector<SCH_MARKER*> markers;
 
        for( SCH_ITEM* item : sheet.LastScreen()->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
 
            // Power symbols and other symbols which have the reference starting with "#" are
            // not included in simulation
            if( symbol->GetRef( &sheet ).StartsWith( '#' ) || symbol->ResolveExcludedFromSim() )
                continue;
 
            // Reset for each symbol
            reporter.Clear();
 
            SIM_LIBRARY::MODEL model = libMgr.CreateModel( &sheet, *symbol, true, 0, variant, reporter );
 
            if( reporter.HasMessage() )
            {
                wxString                  msg = reporter.GetMessages();
                std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( ERCE_SIMULATION_MODEL );
 
                //Remove \n and \r at e.o.l if any:
                msg.Trim();
 
                ercItem->SetErrorMessage( msg );
                ercItem->SetItems( symbol );
 
                markers.emplace_back( new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
            }
        }
 
        for( SCH_MARKER* marker : markers )
        {
            sheet.LastScreen()->Append( marker );
            err_count += 1;
        }
    }
 
    return err_count;
}
 
 
int ERC_TESTER::TestVariantSymbols()
{
    wxCHECK( m_schematic, 0 );
 
    SYMBOL_LIBRARY_ADAPTER* adapter = PROJECT_SCH::SymbolLibAdapter( &m_schematic->Project() );
 
    if( !adapter )
        return 0;
 
    int err_count = 0;
 
    // Flatten each alternate once per ERC run rather than once per referencing symbol.
    std::map<wxString, std::unique_ptr<LIB_SYMBOL>> flatAltCache;
 
    for( SCH_SHEET_PATH& sheet : m_sheetList )
    {
        SCH_SCREEN* screen = sheet.LastScreen();
 
        if( !screen )
            continue;
 
        std::vector<SCH_MARKER*> markers;
 
        for( SCH_ITEM* item : screen->Items().OfType( SCH_SYMBOL_T ) )
        {
            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
            SCH_SYMBOL_INSTANCE instance;
 
            if( !symbol->GetInstance( instance, sheet.Path() ) )
                continue;
 
            auto addMarker =
                    [&]( int aErrorCode, const wxString& aMessage )
                    {
                        std::shared_ptr<ERC_ITEM> ercItem = ERC_ITEM::Create( aErrorCode );
 
                        ercItem->SetItems( symbol );
                        ercItem->SetSheetSpecificPath( sheet );
                        ercItem->SetErrorMessage( aMessage );
 
                        markers.emplace_back(
                                new SCH_MARKER( std::move( ercItem ), symbol->GetPosition() ) );
                        err_count++;
                    };
 
            for( const auto& [variantName, variant] : instance.m_Variants )
            {
                if( !variant.m_SymbolOverride )
                    continue;
 
                const LIB_ID& libId = *variant.m_SymbolOverride;
                wxString      libIdStr = libId.Format();
 
                // A self-referencing override is ignored by resolution, so skip it here too.
                if( libId == symbol->GetLibId() )
                    continue;
 
                auto cacheIt = flatAltCache.find( libIdStr );
 
                if( cacheIt == flatAltCache.end() )
                {
                    std::unique_ptr<LIB_SYMBOL> flatAlt;
 
                    try
                    {
                        if( LIB_SYMBOL* altSymbol = adapter->LoadSymbol( libId ) )
                            flatAlt = altSymbol->Flatten();
                    }
                    catch( const IO_ERROR& )
                    {
                    }
 
                    cacheIt = flatAltCache.emplace( libIdStr, std::move( flatAlt ) ).first;
                }
 
                const LIB_SYMBOL* flatAlt = cacheIt->second.get();
 
                if( !flatAlt )
                {
                    if( m_settings.IsTestEnabled( ERCE_VARIANT_SYMBOL_INVALID ) )
                    {
                        addMarker( ERCE_VARIANT_SYMBOL_INVALID,
                                   wxString::Format( _( "Variant '%s': symbol '%s' not found in libraries" ),
                                                     variantName, libIdStr ) );
                    }
 
                    continue;
                }
 
                if( !m_settings.IsTestEnabled( ERCE_VARIANT_SYMBOL_INCOMPATIBLE ) )
                    continue;
 
                // The schematic's library symbol is stored flattened, so compare it directly.
                LIB_SYMBOL* baseSymbol = symbol->GetLibSymbolRef().get();
 
                if( !baseSymbol )
                    continue;
 
                std::vector<VARIANT_COMPAT_RESULT> issues =
                        ValidateVariantSymbolCompatibility( *baseSymbol, *flatAlt );
 
                for( const VARIANT_COMPAT_RESULT& issue : issues )
                {
                    addMarker( ERCE_VARIANT_SYMBOL_INCOMPATIBLE,
                               wxString::Format( _( "Variant '%s', alternate '%s': %s" ),
                                                 variantName, libIdStr, issue.detail ) );
                }
            }
        }
 
        for( SCH_MARKER* marker : markers )
            screen->Append( marker );
    }
 
    return err_count;
}
 
 
void ERC_TESTER::RunTests( DS_PROXY_VIEW_ITEM* aDrawingSheet, SCH_EDIT_FRAME* aEditFrame,
                           KIFACE* aCvPcb, PROJECT* aProject, PROGRESS_REPORTER* aProgressReporter )
{
    m_sheetList.AnnotatePowerSymbols();
 
    // Test duplicate sheet names inside a given sheet.  While one can have multiple references
    // to the same file, each must have a unique name.
    if( m_settings.IsTestEnabled( ERCE_DUPLICATE_SHEET_NAME ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking sheet names..." ) );
 
        TestDuplicateSheetNames( true );
    }
 
    // Test pin-to-pad maps for stale pins, duplicate pad targets and bad pad references (issue #2282).
    if( m_settings.IsTestEnabled( ERCE_PIN_MAP_STALE_PIN ) || m_settings.IsTestEnabled( ERCE_PIN_MAP_DUPLICATE_PAD )
        || m_settings.IsTestEnabled( ERCE_PIN_MAP_BAD_PAD ) || m_settings.IsTestEnabled( ERCE_PIN_MAP_UNMAPPED_PIN ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking pin maps..." ) );
 
        TestPinMap( aCvPcb, aProject );
    }
 
    // The connection graph has a whole set of ERC checks it can run
    if( aProgressReporter )
        aProgressReporter->AdvancePhase( _( "Checking conflicts..." ) );
 
    // If we are using the new connectivity, make sure that we do a full-rebuild
    if( aEditFrame )
    {
        if( ADVANCED_CFG::GetCfg().m_IncrementalConnectivity )
            aEditFrame->RecalculateConnections( nullptr, GLOBAL_CLEANUP );
        else
            aEditFrame->RecalculateConnections( nullptr, NO_CLEANUP );
    }
 
    m_schematic->ConnectionGraph()->RunERC();
 
    if( aProgressReporter )
        aProgressReporter->AdvancePhase( _( "Checking units..." ) );
 
    // Test is all units of each multiunit symbol have the same footprint assigned.
    if( m_settings.IsTestEnabled( ERCE_DIFFERENT_UNIT_FP ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking footprints..." ) );
 
        TestMultiunitFootprints();
    }
 
    if( m_settings.IsTestEnabled( ERCE_MISSING_UNIT )
        || m_settings.IsTestEnabled( ERCE_MISSING_INPUT_PIN )
        || m_settings.IsTestEnabled( ERCE_MISSING_POWER_INPUT_PIN )
        || m_settings.IsTestEnabled( ERCE_MISSING_BIDI_PIN ) )
    {
        TestMissingUnits();
    }
 
    if( aProgressReporter )
        aProgressReporter->AdvancePhase( _( "Checking pins..." ) );
 
    if( m_settings.IsTestEnabled( ERCE_DIFFERENT_UNIT_NET ) )
        TestMultUnitPinConflicts();
 
    if( m_settings.IsTestEnabled( ERCE_DUPLICATE_PIN_ERROR ) )
        TestDuplicatePinNets();
 
    // Test pins on each net against the pin connection table
    if( m_settings.IsTestEnabled( ERCE_PIN_TO_PIN_ERROR )
        || m_settings.IsTestEnabled( ERCE_PIN_TO_PIN_WARNING )
        || m_settings.IsTestEnabled( ERCE_POWERPIN_NOT_DRIVEN )
        || m_settings.IsTestEnabled( ERCE_PIN_NOT_DRIVEN ) )
    {
        TestPinToPin();
    }
 
    if( m_settings.IsTestEnabled( ERCE_GROUND_PIN_NOT_GROUND ) )
        TestGroundPins();
 
    if( m_settings.IsTestEnabled( ERCE_STACKED_PIN_SYNTAX ) )
        TestStackedPinNotation();
 
    // Test similar labels (i;e. labels which are identical when
    // using case insensitive comparisons)
    if( m_settings.IsTestEnabled( ERCE_SIMILAR_LABELS )
        || m_settings.IsTestEnabled( ERCE_SIMILAR_POWER )
        || m_settings.IsTestEnabled( ERCE_SIMILAR_LABEL_AND_POWER ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking similar labels..." ) );
 
        TestSimilarLabels();
    }
 
    if( m_settings.IsTestEnabled( ERCE_SAME_LOCAL_GLOBAL_LABEL )
        || m_settings.IsTestEnabled( ERCE_SAME_LOCAL_GLOBAL_POWER ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking local and global labels..." ) );
 
        TestSameLocalGlobalLabel();
    }
 
    if( m_settings.IsTestEnabled( ERCE_UNRESOLVED_VARIABLE ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking for unresolved variables..." ) );
 
        TestTextVars( aDrawingSheet );
    }
 
    if( m_settings.IsTestEnabled( ERCE_FIELD_NAME_WHITESPACE ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking field names..." ) );
 
        TestFieldNameWhitespace();
    }
 
    if( m_settings.IsTestEnabled( ERCE_EMPTY_LABEL_NAME ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking for empty label names..." ) );
 
        TestEmptyLabelNames();
    }
 
    if( m_settings.IsTestEnabled( ERCE_SIMULATION_MODEL ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking SPICE models..." ) );
 
        TestSimModelIssues();
    }
 
    if( m_settings.IsTestEnabled( ERCE_NOCONNECT_CONNECTED ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking no connect pins for connections..." ) );
 
        TestNoConnectPins();
    }
 
    if( m_settings.IsTestEnabled( ERCE_LIB_SYMBOL_ISSUES )
        || m_settings.IsTestEnabled( ERCE_LIB_SYMBOL_MISMATCH ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking for library symbol issues..." ) );
 
        TestLibSymbolIssues();
    }
 
    if( m_settings.IsTestEnabled( ERCE_FOOTPRINT_LINK_ISSUES ) && aCvPcb )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking for footprint link issues..." ) );
 
        TestFootprintLinkIssues( aCvPcb, aProject );
    }
 
    if( m_settings.IsTestEnabled( ERCE_FOOTPRINT_FILTERS ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking footprint assignments against footprint filters..." ) );
 
        TestFootprintFilters();
    }
 
    if( m_settings.IsTestEnabled( ERCE_ENDPOINT_OFF_GRID ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking for off grid pins and wires..." ) );
 
        TestOffGridEndpoints();
    }
 
    if( m_settings.IsTestEnabled( ERCE_FOUR_WAY_JUNCTION ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking for four way junctions..." ) );
 
        TestFourWayJunction();
    }
 
    if( m_settings.IsTestEnabled( ERCE_LABEL_MULTIPLE_WIRES ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking for labels on more than one wire..." ) );
 
        TestLabelMultipleWires();
    }
 
    if( m_settings.IsTestEnabled( ERCE_UNDEFINED_NETCLASS ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking for undefined netclasses..." ) );
 
        TestMissingNetclasses();
    }
 
    if( m_settings.IsTestEnabled( ERCE_VARIANT_SYMBOL_INVALID )
        || m_settings.IsTestEnabled( ERCE_VARIANT_SYMBOL_INCOMPATIBLE ) )
    {
        if( aProgressReporter )
            aProgressReporter->AdvancePhase( _( "Checking variant symbols..." ) );
 
        TestVariantSymbols();
    }
 
    m_schematic->ResolveERCExclusionsPostUpdate();
}