drc_test_provider_disallow.cpp

Go to the documentation of this file.

/*
 * This program source code file is part of KiCad, a free EDA CAD application.
 *
 * Copyright The KiCad Developers.
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
#include <atomic>
#include <common.h>
#include <board_design_settings.h>
#include <drc/drc_rtree.h>
#include <drc/drc_engine.h>
#include <drc/drc_item.h>
#include <drc/drc_rule.h>
#include <drc/drc_test_provider.h>
#include <pad.h>
#include <progress_reporter.h>
#include <thread_pool.h>
#include <zone.h>
#include <pcb_track.h>
#include <mutex>
 
 
/*
    "Disallow" test. Goes through all items, matching types/conditions drop errors.
    Errors generated:
    - DRCE_ALLOWED_ITEMS
    - DRCE_TEXT_ON_EDGECUTS
*/
 
class DRC_TEST_PROVIDER_DISALLOW : public DRC_TEST_PROVIDER
{
public:
    DRC_TEST_PROVIDER_DISALLOW()
    {}
 
    virtual ~DRC_TEST_PROVIDER_DISALLOW() = default;
 
    virtual bool Run() override;
 
    virtual const wxString GetName() const override { return wxT( "disallow" ); };
};
 
 
bool DRC_TEST_PROVIDER_DISALLOW::Run()
{
    if( !reportPhase( _( "Checking keepouts & disallow constraints..." ) ) )
        return false;   // DRC cancelled
 
    BOARD* board = m_drcEngine->GetBoard();
    int    epsilon = board->GetDesignSettings().GetDRCEpsilon();
 
    // First build out the board's cache of copper-keepout to copper-zone caches.  This is where
    // the bulk of the time is spent, and we can do this in parallel.
    //
    std::vector<ZONE*>                   antiCopperKeepouts;
    std::vector<ZONE*>                   copperZones;
    std::vector<std::pair<ZONE*, ZONE*>> toCache;
    std::atomic<size_t>                  done( 1 );
    int                                  totalCount = 0;
    std::unique_ptr<DRC_RTREE>           antiTrackKeepouts = std::make_unique<DRC_RTREE>();
 
    forEachGeometryItem( { PCB_ZONE_T }, LSET::AllLayersMask(),
            [&]( BOARD_ITEM* item ) -> bool
            {
                ZONE* zone = static_cast<ZONE*>( item );
 
                if( zone->GetIsRuleArea() )
                {
                    if( zone->GetDoNotAllowZoneFills() )
                        antiCopperKeepouts.push_back( zone );
 
                    if( zone->GetDoNotAllowTracks() )
                    {
                        for( PCB_LAYER_ID layer : zone->GetLayerSet() )
                            antiTrackKeepouts->Insert( zone, layer, CLEARANCE_CONSTRAINT );
                    }
                }
                else if( zone->IsOnCopperLayer() )
                {
                    copperZones.push_back( zone );
                }
 
                totalCount++;
 
                return true;
            } );
 
    antiTrackKeepouts->Build();
 
    for( ZONE* keepoutRuleArea : antiCopperKeepouts )
    {
        for( ZONE* copperZone : copperZones )
        {
            toCache.push_back( { keepoutRuleArea, copperZone } );
            totalCount++;
        }
    }
 
    auto query_keepouts =
            [&]( const int idx ) -> size_t
            {
                if( m_drcEngine->IsCancelled() )
                    return 0;
 
                auto [keepoutRuleArea, copperZone] = toCache[idx];
                BOX2I areaBBox = keepoutRuleArea->GetBoundingBox();
                BOX2I copperBBox = copperZone->GetBoundingBox();
                bool  isInside = false;
 
                if( copperZone->IsFilled() && areaBBox.Intersects( copperBBox ) )
                {
                    // Collisions include touching, so we need to deflate outline by enough to
                    // exclude it.  This is particularly important for detecting copper fills as
                    // they will be exactly touching along the entire exclusion border.
                    SHAPE_POLY_SET areaPoly = keepoutRuleArea->GetBoardOutline();
                    areaPoly.Fracture();
                    areaPoly.Deflate( epsilon, CORNER_STRATEGY::ALLOW_ACUTE_CORNERS, ARC_LOW_DEF );
 
                    DRC_RTREE* zoneRTree = board->GetCopperZoneRTree( copperZone );
 
                    if( zoneRTree )
                    {
                        for( size_t ii = 0; ii < keepoutRuleArea->GetLayerSet().size(); ++ii )
                        {
                            if( keepoutRuleArea->GetLayerSet().test( ii ) )
                            {
                                PCB_LAYER_ID layer = PCB_LAYER_ID( ii );
 
                                if( zoneRTree->QueryColliding( areaBBox, &areaPoly, layer ) )
                                {
                                    isInside = true;
                                    break;
                                }
 
                                if( m_drcEngine->IsCancelled() )
                                    return 0;
                            }
                        }
                    }
                }
 
                if( m_drcEngine->IsCancelled() )
                    return 0;
 
                PTR_PTR_LAYER_CACHE_KEY key = { keepoutRuleArea, copperZone, UNDEFINED_LAYER };
                board->m_IntersectsKeepoutCache.Set( key, isInside );
 
                done.fetch_add( 1 );
 
                return 1;
            };
 
    thread_pool& tp = GetKiCadThreadPool();
    auto futures = tp.submit_loop( 0, toCache.size(), query_keepouts, toCache.size() );
 
    for( auto& ret : futures )
    {
        std::future_status status = ret.wait_for( std::chrono::milliseconds( 250 ) );
 
        while( status != std::future_status::ready )
        {
            reportProgress( done, toCache.size() );
            status = ret.wait_for( std::chrono::milliseconds( 250 ) );
        }
    }
 
    if( m_drcEngine->IsCancelled() )
        return false;
 
    // Now go through all the board objects calling the DRC_ENGINE to run the actual disallow
    // tests.  These should be reasonably quick using the caches generated above.
    //
    // Collect items first, then process in parallel.
    std::vector<BOARD_ITEM*> allItems;
 
    forEachGeometryItem( {}, LSET::AllLayersMask(),
            [&]( BOARD_ITEM* item ) -> bool
            {
                allItems.push_back( item );
                return true;
            } );
 
    std::atomic<size_t> itemsDone( 0 );
    size_t              itemCount = allItems.size();
 
    auto checkTextOnEdgeCuts =
            []( BOARD_ITEM* item ) -> bool
            {
                // Items that plot geometry onto Edge.Cuts corrupt the board outline.
                // Reference images are excluded on purpose because they are never plotted.
                if( item->Type() == PCB_FIELD_T
                    || item->Type() == PCB_TEXT_T
                    || item->Type() == PCB_TEXTBOX_T
                    || BaseType( item->Type() ) == PCB_TABLE_T
                    || item->Type() == PCB_BARCODE_T
                    || BaseType( item->Type() ) == PCB_DIMENSION_T )
                {
                    return item->GetLayer() == Edge_Cuts;
                }
 
                return false;
            };
 
    auto processItem =
            [&]( const int idx ) -> size_t
            {
                if( m_drcEngine->IsCancelled() )
                {
                    itemsDone.fetch_add( 1 );
                    return 0;
                }
 
                bool testTextOnEdge = !m_drcEngine->IsErrorLimitExceeded( DRCE_TEXT_ON_EDGECUTS );
                bool testDisallow = !m_drcEngine->IsErrorLimitExceeded( DRCE_ALLOWED_ITEMS );
 
                if( !testTextOnEdge && !testDisallow )
                {
                    itemsDone.fetch_add( 1 );
                    return 0;
                }
 
                BOARD_ITEM* item = allItems[idx];
 
                if( testTextOnEdge && checkTextOnEdgeCuts( item ) )
                {
                    std::shared_ptr<DRC_ITEM> drc = DRC_ITEM::Create( DRCE_TEXT_ON_EDGECUTS );
                    drc->SetItems( item );
                    reportViolation( drc, item->GetPosition(), Edge_Cuts );
                }
 
                if( testDisallow )
                {
                    if( item->Type() == PCB_ZONE_T )
                    {
                        ZONE* zone = static_cast<ZONE*>( item );
 
                        if( zone->GetIsRuleArea() && zone->HasKeepoutParametersSet() )
                        {
                            itemsDone.fetch_add( 1 );
                            return 1;
                        }
                    }
 
                    item->ClearFlags( HOLE_PROXY );
 
                    if( item->Type() == PCB_TRACE_T || item->Type() == PCB_ARC_T )
                    {
                        PCB_TRACK*   track = static_cast<PCB_TRACK*>( item );
                        PCB_LAYER_ID layer = track->GetLayer();
 
                        antiTrackKeepouts->QueryColliding( track, layer, layer,
                                [&]( BOARD_ITEM* other ) -> bool
                                {
                                    return true;
                                },
                                [&]( BOARD_ITEM* other ) -> bool
                                {
                                    std::shared_ptr<SHAPE> shape = track->GetEffectiveShape();
                                    int                    dummyActual;
                                    VECTOR2I               pos;
                                    SHAPE_POLY_SET         zoneOutlineStorage;
                                    SHAPE_POLY_SET*        zoneOutline = &zoneOutlineStorage;
 
                                    // GetBoardOutline() is expensive.  Only use it in DRC where we have to.
                                    if( other->GetParentFootprint() )
                                        zoneOutlineStorage = static_cast<ZONE*>( other )->GetBoardOutline();
                                    else
                                        zoneOutline = static_cast<ZONE*>( other )->Outline();
 
                                    if( zoneOutline->Collide( shape.get(), 0, &dummyActual, &pos ) )
                                    {
                                        std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_ALLOWED_ITEMS );
                                        drcItem->SetItems( track );
                                        reportViolation( drcItem, pos, track->GetLayerSet().ExtractLayer() );
                                    }
 
                                    return !m_drcEngine->IsCancelled();
                                },
                                board->m_DRCMaxPhysicalClearance );
                    }
 
                    // Tracks and arcs against keepout areas that disallow tracks are already
                    // reported above via antiTrackKeepouts (which collides every crossing, not
                    // just one per rule match).  Skip the track/arc case for implicit keepout
                    // rules here to avoid duplicate markers, but still let EvalRules produce
                    // markers for all other item types against implicit keepout rules.
                    bool isTrackOrArc = ( item->Type() == PCB_TRACE_T || item->Type() == PCB_ARC_T );
 
                    auto reportDisallow =
                            [&]( const DRC_CONSTRAINT& aConstraint )
                            {
                                DRC_RULE* rule = aConstraint.GetParentRule();
 
                                if( !rule )
                                    return;
 
                                if( isTrackOrArc && rule->IsImplicit() )
                                    return;
 
                                std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_ALLOWED_ITEMS );
                                PCB_LAYER_ID              layer = item->GetLayerSet().ExtractLayer();
                                VECTOR2I                  pos = item->GetPosition();
 
                                // Provide a better location for keepout area collisions by snapping to where
                                // the item actually crosses the keepout outline.  Use the cached BOARD_ITEM*
                                // rather than a UUID lookup, since ResolveItem mutates an unsynchronized cache
                                // and this lambda runs inside the parallel DRC worker pool.
                                if( rule->IsImplicit() )
                                {
                                    if( ZONE* keepout = dynamic_cast<ZONE*>( rule->m_ImplicitItem ) )
                                    {
                                        std::shared_ptr<SHAPE> shape = item->GetEffectiveShape( layer );
                                        int dummyActual;
 
                                        // This is only done when reporting collisions, so we can afford the
                                        // more expensive GetBoardOutline().
                                        SHAPE_POLY_SET keepoutOutline = keepout->GetBoardOutline();
                                        keepoutOutline.Collide( shape.get(), 0, &dummyActual, &pos );
                                    }
                                }
 
                                drcItem->SetErrorDetail( wxString::Format( wxS( "(%s)" ), aConstraint.GetName() ) );
                                drcItem->SetItems( item );
                                drcItem->SetViolatingRule( rule );
                                reportViolation( drcItem, pos, layer );
                            };
 
                    DRC_CONSTRAINT constraint = m_drcEngine->EvalRules( DISALLOW_CONSTRAINT, item, nullptr,
                                                                        UNDEFINED_LAYER );
 
                    if( constraint.m_DisallowFlags
                        && constraint.GetSeverity() != RPT_SEVERITY_IGNORE )
                    {
                        reportDisallow( constraint );
                    }
 
                    // N.B. HOLE_PROXY is set/cleared on the item's flags for
                    // EvalRules to distinguish hole-specific disallow constraints.
                    // This is a non-atomic read-modify-write on m_flags, so this
                    // provider must run with each item processed by only one thread
                    // at a time (guaranteed by submit_loop's work partitioning).
                    if( item->HasHole() )
                    {
                        item->SetFlags( HOLE_PROXY );
 
                        constraint = m_drcEngine->EvalRules( DISALLOW_CONSTRAINT, item, nullptr, UNDEFINED_LAYER );
 
                        if( constraint.m_DisallowFlags
                            && constraint.GetSeverity() != RPT_SEVERITY_IGNORE )
                        {
                            reportDisallow( constraint );
                        }
 
                        item->ClearFlags( HOLE_PROXY );
                    }
                }
 
                itemsDone.fetch_add( 1 );
                return 1;
            };
 
    auto itemFutures = tp.submit_loop( 0, itemCount, processItem, itemCount );
 
    while( itemsDone < itemCount )
    {
        reportProgress( itemsDone, itemCount );
 
        if( m_drcEngine->IsCancelled() )
        {
            for( auto& f : itemFutures )
                f.wait();
 
            break;
        }
 
        itemFutures.wait_for( std::chrono::milliseconds( 250 ) );
    }
 
    return !m_drcEngine->IsCancelled();
}
 
 
namespace detail
{
static DRC_REGISTER_TEST_PROVIDER<DRC_TEST_PROVIDER_DISALLOW> dummy;
}