panel_drc_rule_editor.cpp

Go to the documentation of this file.

/*
 * This program source code file is part of KiCad, a free EDA CAD application.
 *
 * Copyright (C) 2024 KiCad Developers, see AUTHORS.txt for contributors.
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, you may find one here:
 * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
 * or you may search the http://www.gnu.org website for the version 2 license,
 * or you may write to the Free Software Foundation, Inc.,
 * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
 */
 
#include <widgets/std_bitmap_button.h>
#include <widgets/wx_html_report_box.h>
#include <widgets/paged_dialog.h>
#include <wx/log.h>
#include <wx/regex.h>
 
#include <pgm_base.h>
#include <settings/settings_manager.h>
#include <footprint_editor_settings.h>
#include <template_fieldnames.h>
#include <grid_tricks.h>
#include <eda_text.h>
#include <grid_layer_box_helpers.h>
#include <bitmaps.h>
#include <confirm.h>
#include <kidialog.h>
#include <layer_ids.h>
#include <layer_range.h>
#include <board.h>
#include <project/net_settings.h>
#include <idf_parser.h>
#include <scintilla_tricks.h>
#include <wx/stc/stc.h>
#include <dialogs/html_message_box.h>
#include <dialogs/rule_editor_dialog_base.h> 
#include <tools/drc_tool.h>
#include <pcbexpr_evaluator.h>
#include <string_utils.h>
#include <drc_rules_lexer.h>
 
#include <drc/drc_rule_parser.h>
#include <drc/rule_editor/panel_drc_rule_editor.h>
#include <drc/rule_editor/drc_re_custom_rule_panel.h>
#include "drc_re_condition_group_panel.h"
#include "drc_re_via_style_overlay_panel.h"
#include "drc_re_routing_width_overlay_panel.h"
#include "drc_re_rtg_diff_pair_overlay_panel.h"
#include "drc_re_min_txt_ht_th_overlay_panel.h"
#include "drc_re_abs_length_two_overlay_panel.h"
#include "drc_re_numeric_input_overlay_panel.h"
#include "drc_re_bool_input_overlay_panel.h"
#include "drc_re_allowed_orientation_overlay_panel.h"
#include "drc_re_matched_length_diff_pair_overlay_panel.h"
#include "drc_re_vias_under_smd_overlay_panel.h"
#include "drc_re_permitted_layers_overlay_panel.h"
 
#include <eda_units.h>
#include "drc_re_numeric_input_constraint_data.h"
#include "drc_re_bool_input_constraint_data.h"
#include "drc_re_via_style_constraint_data.h"
#include "drc_re_abs_length_two_constraint_data.h"
#include "drc_re_min_txt_ht_th_constraint_data.h"
#include "drc_re_rtg_diff_pair_constraint_data.h"
#include "drc_re_routing_width_constraint_data.h"
#include "drc_re_permitted_layers_constraint_data.h"
#include "drc_re_allowed_orientation_constraint_data.h"
#include "drc_re_vias_under_smd_constraint_data.h"
#include "drc_re_custom_rule_constraint_data.h"
#include "drc_re_custom_rule_panel.h"
#include <properties/property.h>
#include <properties/property_mgr.h>
 
static constexpr const wxChar* KI_TRACE_DRC_RULE_EDITOR = wxT( "KI_TRACE_DRC_RULE_EDITOR" );
 
static bool constraintNeedsTwoObjects( DRC_RULE_EDITOR_CONSTRAINT_NAME aConstraintType )
{
    switch( aConstraintType )
    {
    case MINIMUM_CLEARANCE:
    case CREEPAGE_DISTANCE:
    case COPPER_TO_HOLE_CLEARANCE:
    case PHYSICAL_CLEARANCE:
    case HOLE_TO_HOLE_DISTANCE: return true;
    default: return false;
    }
}
 
PANEL_DRC_RULE_EDITOR::PANEL_DRC_RULE_EDITOR( wxWindow* aParent, BOARD* aBoard,
                                              DRC_RULE_EDITOR_CONSTRAINT_NAME              aConstraintType,
                                              wxString*                                    aConstraintTitle,
                                              std::shared_ptr<DRC_RE_BASE_CONSTRAINT_DATA> aConstraintData ) :
        PANEL_DRC_RULE_EDITOR_BASE( aParent ),
        m_board( aBoard ),
        m_constraintTitle( aConstraintTitle ),
        m_validationSucceeded( false ),
        m_constraintData( aConstraintData ),
        m_helpWindow( nullptr )
{
    wxLogTrace( KI_TRACE_DRC_RULE_EDITOR, wxS( "[PANEL_DRC_RULE_EDITOR] ctor START" ) );
 
    SetBorders( true, false, false, false );
 
    m_constraintType = aConstraintType;
    m_constraintPanel = getConstraintPanel( this, aConstraintType );
    wxLogTrace( KI_TRACE_DRC_RULE_EDITOR, wxS( "[PANEL_DRC_RULE_EDITOR] adding constraint panel to sizer" ) );
    m_constraintContentSizer->Add( dynamic_cast<wxPanel*>( m_constraintPanel ), 0, wxEXPAND | wxTOP, 5 );
    m_layerList = m_board->GetEnabledLayers().UIOrder();
    m_constraintHeaderTitle->SetLabelText( *aConstraintTitle + " Constraint" );
 
    m_layerListChoiceCtrl = new wxChoice( this, wxID_ANY );
    m_layerCategory = DRC_RULE_EDITOR_UTILS::GetLayerCategoryForConstraint( aConstraintType );
    populateLayerSelector( m_layerCategory );
    m_LayersComboBoxSizer->Add( m_layerListChoiceCtrl, 0, wxALL | wxEXPAND, 5 );
    m_layerListChoiceCtrl->Bind( wxEVT_CHOICE,
                                 [this]( wxCommandEvent& )
                                 {
                                     RULE_EDITOR_DIALOG_BASE* dlg = RULE_EDITOR_DIALOG_BASE::GetDialog( this );
 
                                     if( dlg )
                                         dlg->SetModified();
                                 } );
 
    // Hide layer selector for constraints where it doesn't apply
    if( m_layerCategory == DRC_LAYER_CATEGORY::NO_LAYER_SELECTOR )
    {
        m_LayersComboBoxSizer->Show( false );
        m_staticText711->Show( false );
        m_staticline111->Show( false );
    }
 
    wxBoxSizer* buttonSizer = new wxBoxSizer( wxHORIZONTAL );
    m_btnShowMatches = new wxButton( this, wxID_ANY, "Show Matches" );
    buttonSizer->Add( m_btnShowMatches, 0, wxALL, 5 );
 
    bContentSizer->Add( buttonSizer, 0, wxALIGN_RIGHT | wxALL, 2 );
 
    m_btnShowMatches->Bind( wxEVT_BUTTON, &PANEL_DRC_RULE_EDITOR::onShowMatchesButtonClicked, this );
 
    m_btnShowMatches->Enable( true );
 
    m_checkSyntaxBtnCtrl->SetBitmap( KiBitmapBundle( BITMAPS::drc ) );
 
    m_scintillaTricks = std::make_unique<SCINTILLA_TRICKS>(
            m_textConditionCtrl, wxT( "()" ), false,
            // onAcceptFn
            [this]( wxKeyEvent& aEvent )
            {
                wxPostEvent( PAGED_DIALOG::GetDialog( this ), wxCommandEvent( wxEVT_COMMAND_BUTTON_CLICKED, wxID_OK ) );
            },
            // onCharFn
            [this]( wxStyledTextEvent& aEvent )
            {
                onScintillaCharAdded( aEvent );
            } );
 
    m_textConditionCtrl->AutoCompSetSeparator( '|' );
 
    // Hide the base class text control since we use the condition group panel
    m_textConditionCtrl->Hide();
 
    bool twoObjects = constraintNeedsTwoObjects( aConstraintType );
 
    // Create condition group panel (multi-condition UI)
    // Each condition row has its own custom query text control
    wxLogTrace( KI_TRACE_DRC_RULE_EDITOR, wxS( "[PANEL_DRC_RULE_EDITOR] creating conditionGroupPanel" ) );
    m_conditionGroupPanel = new DRC_RE_CONDITION_GROUP_PANEL( this, m_board, twoObjects );
    m_conditionGroupPanel->SetChangeCallback(
            [this]()
            {
                ResetShowMatchesButton();
 
                RULE_EDITOR_DIALOG_BASE* dlg = RULE_EDITOR_DIALOG_BASE::GetDialog( this );
 
                if( dlg )
                {
                    dlg->SetModified();
                    dlg->RefreshContentScrollArea();
                }
            } );
 
    wxLogTrace( KI_TRACE_DRC_RULE_EDITOR, wxS( "[PANEL_DRC_RULE_EDITOR] inserting conditionGroupPanel" ) );
    m_conditionControlsSizer->Insert( 0, m_conditionGroupPanel, 0, wxEXPAND | wxBOTTOM, 5 );
 
    if( aConstraintType == CUSTOM_RULE )
    {
        m_conditionGroupPanel->Hide();
        m_conditionHeaderTitle->Hide();
        m_syntaxHelp->Hide();
        m_staticline8->Hide();
        m_LayersComboBoxSizer->Show( false );
        m_staticText711->Hide();
        m_staticline111->Hide();
    }
 
    m_commentCtrl->Bind( wxEVT_TEXT,
                         [this]( wxCommandEvent& )
                         {
                             RULE_EDITOR_DIALOG_BASE* dlg = RULE_EDITOR_DIALOG_BASE::GetDialog( this );
 
                             if( dlg )
                                 dlg->SetModified();
                         });
 
    // Hide the base class syntax check controls since we use inline validation
    m_checkSyntaxBtnCtrl->Hide();
    m_syntaxErrorReport->Hide();
 
    m_nameCtrl->Bind( wxEVT_TEXT,
                      [this]( wxCommandEvent& )
                      {
                          RULE_EDITOR_DIALOG_BASE* dlg = RULE_EDITOR_DIALOG_BASE::GetDialog( this );
                          if( dlg )
                              dlg->SetModified();
 
                          if( m_constraintType == CUSTOM_RULE )
                          {
                              auto* customPanel = dynamic_cast<DRC_RE_CUSTOM_RULE_PANEL*>( m_constraintPanel );
 
                              if( customPanel )
                                  customPanel->UpdateRuleName( m_nameCtrl->GetValue() );
                          }
                      } );
 
    // Regex patterns are compiled as function-local statics in onScintillaCharAdded()
    // to avoid recompilation on every panel creation.
}
 
 
PANEL_DRC_RULE_EDITOR::~PANEL_DRC_RULE_EDITOR()
{
    m_board = nullptr;
    m_constraintTitle = nullptr;
 
    m_btnShowMatches->Unbind( wxEVT_BUTTON, &PANEL_DRC_RULE_EDITOR::onShowMatchesButtonClicked, this );
}
 
 
bool PANEL_DRC_RULE_EDITOR::TransferDataToWindow()
{
    if( m_constraintData )
    {
        m_nameCtrl->ChangeValue( m_constraintData->GetRuleName() );
        m_commentCtrl->ChangeValue( m_constraintData->GetComment() );
        setSelectedLayers( m_constraintData->GetLayers(), m_constraintData->GetLayerSource() );
        wxString cond = m_constraintData->GetRuleCondition();
 
        // Use the new condition group panel
        // Each row manages its own custom query text control visibility
        m_conditionGroupPanel->ParseCondition( cond );
    }
 
    if( m_constraintPanel )
        return m_constraintPanel->TransferDataToWindow();
 
    return true;
}
 
 
wxString PANEL_DRC_RULE_EDITOR::getSelectedLayerSource() const
{
    if( !m_layerListChoiceCtrl )
        return wxEmptyString;
 
    int sel = m_layerListChoiceCtrl->GetSelection();
    if( sel <= 0 )
        return wxEmptyString;
 
    int layerValue = m_layerIDs[sel - 1];
 
    switch( layerValue )
    {
    case LAYER_SEL_OUTER: return DRC_RULES_LEXER::TokenName( DRCRULE_T::T_outer );
    case LAYER_SEL_INNER: return DRC_RULES_LEXER::TokenName( DRCRULE_T::T_inner );
    case LAYER_SEL_TOP:
        switch( m_constraintType )
        {
        case COURTYARD_CLEARANCE:          return wxS( "F.CrtYd" );
        case SILK_TO_SOLDERMASK_CLEARANCE: return wxS( "F.SilkS" );
        case VIAS_UNDER_SMD:
        case ALLOWED_ORIENTATION:          return wxS( "F.Cu" );
        default:                           return m_board ? m_board->GetLayerName( F_Cu ) : wxString();
        }
 
    case LAYER_SEL_BOTTOM:
        switch( m_constraintType )
        {
        case COURTYARD_CLEARANCE:          return wxS( "B.CrtYd" );
        case SILK_TO_SOLDERMASK_CLEARANCE: return wxS( "B.SilkS" );
        case VIAS_UNDER_SMD:
        case ALLOWED_ORIENTATION:          return wxS( "B.Cu" );
        default:                           return m_board ? m_board->GetLayerName( B_Cu ) : wxString();
        }
    default:
        if( layerValue >= 0 && m_board )
            return m_board->GetLayerName( static_cast<PCB_LAYER_ID>( layerValue ) );
        return wxEmptyString;
    }
}
 
 
bool PANEL_DRC_RULE_EDITOR::TransferDataFromWindow()
{
    if( m_constraintPanel )
        m_constraintPanel->TransferDataFromWindow();
 
    m_constraintData->SetRuleName( m_nameCtrl->GetValue() );
    m_constraintData->SetComment( m_commentCtrl->GetValue() );
    m_constraintData->SetLayers( getSelectedLayers() );
    m_constraintData->SetLayerSource( getSelectedLayerSource() );
 
    // Use the new condition group panel
    wxString combined = m_conditionGroupPanel->BuildCondition();
    m_constraintData->SetRuleCondition( combined );
 
    RULE_GENERATION_CONTEXT context;
    context.ruleName = m_nameCtrl->GetValue();
    context.comment = m_commentCtrl->GetValue();
    context.conditionExpression = combined;
    context.layerClause = buildLayerClause();
    context.constraintCode = m_constraintData->GetConstraintCode();
 
    wxString generatedRule = m_constraintPanel->GenerateRule( context );
    m_constraintData->SetGeneratedRule( generatedRule );
 
    wxLogTrace( KI_TRACE_DRC_RULE_EDITOR, wxS( "Generated rule '%s':\n%s" ),
                context.ruleName, generatedRule );
 
    return true;
}
 
 
DRC_RULE_EDITOR_CONTENT_PANEL_BASE*
PANEL_DRC_RULE_EDITOR::getConstraintPanel( wxWindow* aParent, const DRC_RULE_EDITOR_CONSTRAINT_NAME& aConstraintType )
{
    EDA_UNITS units = EDA_UNITS::MM;
 
    for( wxWindow* win = GetParent(); win; win = win->GetParent() )
    {
        if( auto* frame = dynamic_cast<EDA_BASE_FRAME*>( win ) )
        {
            units = frame->GetUserUnits();
            break;
        }
    }
 
    switch( aConstraintType )
    {
    case VIA_STYLE:
        return new DRC_RE_VIA_STYLE_OVERLAY_PANEL(
                aParent,
                dynamic_pointer_cast<DRC_RE_VIA_STYLE_CONSTRAINT_DATA>( m_constraintData ).get(),
                units );
 
    case MINIMUM_TEXT_HEIGHT_AND_THICKNESS:
        return new DRC_RE_MIN_TXT_HT_TH_OVERLAY_PANEL(
                aParent,
                dynamic_pointer_cast<DRC_RE_MINIMUM_TEXT_HEIGHT_THICKNESS_CONSTRAINT_DATA>( m_constraintData ).get(),
                units );
 
    case ROUTING_DIFF_PAIR:
        return new DRC_RE_ROUTING_DIFF_PAIR_OVERLAY_PANEL(
                aParent,
                dynamic_pointer_cast<DRC_RE_ROUTING_DIFF_PAIR_CONSTRAINT_DATA>( m_constraintData ).get(),
                units );
 
    case ROUTING_WIDTH:
        return new DRC_RE_ROUTING_WIDTH_OVERLAY_PANEL(
                aParent,
                dynamic_pointer_cast<DRC_RE_ROUTING_WIDTH_CONSTRAINT_DATA>( m_constraintData ).get(),
                units );
 
    case PERMITTED_LAYERS:
        return new DRC_RE_PERMITTED_LAYERS_OVERLAY_PANEL(
                aParent,
                dynamic_pointer_cast<DRC_RE_PERMITTED_LAYERS_CONSTRAINT_DATA>( m_constraintData ).get() );
 
    case ALLOWED_ORIENTATION:
        return new DRC_RE_ALLOWED_ORIENTATION_OVERLAY_PANEL(
                aParent,
                dynamic_pointer_cast<DRC_RE_ALLOWED_ORIENTATION_CONSTRAINT_DATA>( m_constraintData ).get() );
 
    case VIAS_UNDER_SMD:
        return new DRC_RE_VIAS_UNDER_SMD_OVERLAY_PANEL(
                aParent, dynamic_pointer_cast<DRC_RE_VIAS_UNDER_SMD_CONSTRAINT_DATA>( m_constraintData ).get() );
 
    case CUSTOM_RULE:
        return new DRC_RE_CUSTOM_RULE_PANEL(
                aParent, dynamic_pointer_cast<DRC_RE_CUSTOM_RULE_CONSTRAINT_DATA>( m_constraintData ) );
 
    case MATCHED_LENGTH_DIFF_PAIR:
        return new DRC_RE_MATCHED_LENGTH_DIFF_PAIR_OVERLAY_PANEL(
                aParent,
                dynamic_pointer_cast<DRC_RE_MATCHED_LENGTH_DIFF_PAIR_CONSTRAINT_DATA>( m_constraintData ).get(),
                units );
 
    case ABSOLUTE_LENGTH:
        return new DRC_RE_ABS_LENGTH_TWO_OVERLAY_PANEL(
                aParent,
                dynamic_pointer_cast<DRC_RE_ABSOLUTE_LENGTH_TWO_CONSTRAINT_DATA>( m_constraintData ).get(),
                units );
 
    default:
        if( DRC_RULE_EDITOR_UTILS::IsNumericInputType( aConstraintType ) )
        {
            return new DRC_RE_NUMERIC_INPUT_OVERLAY_PANEL(
                    aParent,
                    dynamic_pointer_cast<DRC_RE_NUMERIC_INPUT_CONSTRAINT_DATA>( m_constraintData ).get(),
                    units );
        }
        else if( DRC_RULE_EDITOR_UTILS::IsBoolInputType( aConstraintType ) )
        {
            return new DRC_RE_BOOL_INPUT_OVERLAY_PANEL(
                    aParent,
                    dynamic_pointer_cast<DRC_RE_BOOL_INPUT_CONSTRAINT_DATA>( m_constraintData ).get() );
        }
        else
        {
            return nullptr;
        };
    }
}
 
 
bool PANEL_DRC_RULE_EDITOR::ValidateInputs( int* aErrorCount, wxString* aValidationMessage )
{
    if( !m_callBackRuleNameValidation( m_constraintData->GetId(), m_nameCtrl->GetValue() ) )
    {
        m_validationSucceeded = false;
        ( *aErrorCount )++;
        m_validationMessage +=
                DRC_RULE_EDITOR_UTILS::FormatErrorMessage( *aErrorCount, _( "Rule name must be unique." ) );
    }
 
    if( m_layerListChoiceCtrl->GetSelection() == wxNOT_FOUND )
    {
        m_validationSucceeded = false;
        ( *aErrorCount )++;
        m_validationMessage +=
                DRC_RULE_EDITOR_UTILS::FormatErrorMessage( *aErrorCount, _( "Layer selection is required." ) );
    }
 
    return m_validationSucceeded;
}
 
 
wxString PANEL_DRC_RULE_EDITOR::GenerateRule( const RULE_GENERATION_CONTEXT& aContext )
{
    return m_constraintPanel->GenerateRule( aContext );
}
 
 
void PANEL_DRC_RULE_EDITOR::onSaveButtonClicked( wxCommandEvent& aEvent )
{
    m_validationSucceeded = true;
    int errorCount = 0;
    m_validationMessage.Clear();
 
    ValidateInputs( &errorCount, &m_validationMessage );
 
    if( !m_constraintPanel->ValidateInputs( &errorCount, &m_validationMessage ) )
    {
        m_validationSucceeded = false;
    }
 
    if( m_callBackSave )
    {
        m_callBackSave( m_constraintData->GetId() );
    }
 
    if( m_validationSucceeded )
        m_btnShowMatches->Enable( true );
}
 
 
void PANEL_DRC_RULE_EDITOR::OnEnterKey( wxCommandEvent& aEvent )                                                      
{
    onSaveButtonClicked( aEvent );
}
 
 
void PANEL_DRC_RULE_EDITOR::Save( wxCommandEvent& aEvent )
{
    onSaveButtonClicked( aEvent );
}
 
 
void PANEL_DRC_RULE_EDITOR::onRemoveButtonClicked( wxCommandEvent& aEvent )
{
    if( m_callBackRemove && m_constraintData )
        m_callBackRemove( m_constraintData->GetId() );
}
 
 
void PANEL_DRC_RULE_EDITOR::Cancel( wxCommandEvent& aEvent )
{
    if( m_constraintData && m_constraintData->IsNew() )
        onRemoveButtonClicked( aEvent );
    else
        onCloseButtonClicked( aEvent );
}
 
 
void PANEL_DRC_RULE_EDITOR::onCloseButtonClicked( wxCommandEvent& aEvent )
{
    if( m_callBackClose && m_constraintData )
        m_callBackClose( m_constraintData->GetId() );
}
 
 
void PANEL_DRC_RULE_EDITOR::onScintillaCharAdded( wxStyledTextEvent& aEvent )
{
    if( aEvent.GetModifiers() == wxMOD_CONTROL && aEvent.GetKey() == ' ' )
    {
        // This is just a short-cut for do-auto-complete
    }
 
    m_textConditionCtrl->SearchAnchor();
 
    int currentPos = m_textConditionCtrl->GetCurrentPos();
    int startPos = 0;
 
    for( int line = m_textConditionCtrl->LineFromPosition( currentPos ); line > 0; line-- )
    {
        int      lineStart = m_textConditionCtrl->PositionFromLine( line );
        wxString beginning = m_textConditionCtrl->GetTextRange( lineStart, lineStart + 10 );
 
        if( beginning.StartsWith( wxT( "(condition " ) ) )
        {
            startPos = lineStart;
            break;
        }
    }
 
    enum class EXPR_CONTEXT_T : int
    {
        NONE,
        STRING,
        SEXPR_OPEN,
        SEXPR_TOKEN,
        SEXPR_STRING,
        STRUCT_REF
    };
 
    std::stack<wxString> sexprs;
    wxString             partial;
    wxString             last;
    EXPR_CONTEXT_T       context = EXPR_CONTEXT_T::NONE;
    EXPR_CONTEXT_T       expr_context = EXPR_CONTEXT_T::NONE;
 
    for( int i = startPos; i < currentPos; ++i )
    {
        wxChar c = m_textConditionCtrl->GetCharAt( i );
 
        if( c == '\\' )
        {
            i++; // skip escaped char
        }
        else if( context == EXPR_CONTEXT_T::STRING )
        {
            if( c == '"' )
            {
                context = EXPR_CONTEXT_T::NONE;
            }
            else
            {
                if( expr_context == EXPR_CONTEXT_T::STRING )
                {
                    if( c == '\'' )
                        expr_context = EXPR_CONTEXT_T::NONE;
                    else
                        partial += c;
                }
                else if( c == '\'' )
                {
                    last = partial;
                    partial = wxEmptyString;
                    expr_context = EXPR_CONTEXT_T::STRING;
                }
                else if( c == '.' )
                {
                    partial = wxEmptyString;
                    expr_context = EXPR_CONTEXT_T::STRUCT_REF;
                }
                else
                {
                    partial += c;
                }
            }
        }
        else if( c == '"' )
        {
            last = partial;
            partial = wxEmptyString;
            context = EXPR_CONTEXT_T::STRING;
        }
        else if( c == '(' )
        {
            if( context == EXPR_CONTEXT_T::SEXPR_OPEN && !partial.IsEmpty() )
            {
                m_textConditionCtrl->AutoCompCancel();
                sexprs.push( partial );
            }
 
            partial = wxEmptyString;
            context = EXPR_CONTEXT_T::SEXPR_OPEN;
        }
        else if( c == ')' )
        {
            context = EXPR_CONTEXT_T::NONE;
        }
        else if( c == ' ' )
        {
            if( context == EXPR_CONTEXT_T::SEXPR_OPEN && !partial.IsEmpty() )
            {
                m_textConditionCtrl->AutoCompCancel();
                sexprs.push( partial );
 
                if( partial == wxT( "condition" ) )
                {
                    context = EXPR_CONTEXT_T::SEXPR_STRING;
                }
                else
                {
                    context = EXPR_CONTEXT_T::NONE;
                }
 
                partial = wxEmptyString;
                continue;
            }
 
            context = EXPR_CONTEXT_T::NONE;
        }
        else
        {
            partial += c;
        }
    }
 
    wxString tokens;
 
    if( context == EXPR_CONTEXT_T::SEXPR_OPEN )
    {
        if( sexprs.empty() )
        {
            tokens = wxT( "condition" );
        }
    }
    else if( context == EXPR_CONTEXT_T::SEXPR_TOKEN )
    {
        if( sexprs.empty() )
        {
            /* badly formed grammar */
        }
    }
    else if( context == EXPR_CONTEXT_T::SEXPR_STRING && !sexprs.empty() && sexprs.top() == wxT( "condition" ) )
    {
        m_textConditionCtrl->AddText( wxT( "\"" ) );
    }
    else if( context == EXPR_CONTEXT_T::STRING && !sexprs.empty() && sexprs.top() == wxT( "condition" ) )
    {
        if( expr_context == EXPR_CONTEXT_T::STRUCT_REF )
        {
            PROPERTY_MANAGER&  propMgr = PROPERTY_MANAGER::Instance();
            std::set<wxString> propNames;
 
            for( const PROPERTY_MANAGER::CLASS_INFO& cls : propMgr.GetAllClasses() )
            {
                const std::vector<PROPERTY_BASE*>& props = propMgr.GetProperties( cls.type );
 
                for( PROPERTY_BASE* prop : props )
                {
                    // TODO: It would be nice to replace IsHiddenFromRulesEditor with a nickname
                    // system, so that two different properies don't need to be created.  This is
                    // a bigger change than I want to make right now, though.
                    if( prop->IsHiddenFromRulesEditor() )
                        continue;
 
                    wxString ref( prop->Name() );
                    ref.Replace( wxT( " " ), wxT( "_" ) );
                    propNames.insert( ref );
                }
            }
 
            for( const wxString& propName : propNames )
                tokens += wxT( "|" ) + propName;
 
            PCBEXPR_BUILTIN_FUNCTIONS& functions = PCBEXPR_BUILTIN_FUNCTIONS::Instance();
 
            for( const wxString& funcSig : functions.GetSignatures() )
            {
                if( !funcSig.Contains( "DEPRECATED" ) )
                    tokens += wxT( "|" ) + funcSig;
            }
        }
        else if( expr_context == EXPR_CONTEXT_T::STRING )
        {
            static wxRegEx netClassRegex( wxS( "^NetClass\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx netNameRegex( wxS( "^NetName\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx typeRegex( wxS( "^Type\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx viaTypeRegex( wxS( "^Via_Type\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx padTypeRegex( wxS( "^Pad_Type\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx pinTypeRegex( wxS( "^Pin_Type\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx fabPropRegex( wxS( "^Fabrication_Property\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx shapeRegex( wxS( "^Shape\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx padShapeRegex( wxS( "^Pad_Shape\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx padConnectionsRegex( wxS( "^Pad_Connections\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx zoneConnStyleRegex( wxS( "^Zone_Connection_Style\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx lineStyleRegex( wxS( "^Line_Style\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx hJustRegex( wxS( "^Horizontal_Justification\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
            static wxRegEx vJustRegex( wxS( "^Vertical_Justification\\s*[!=]=\\s*$" ), wxRE_ADVANCED );
 
            if( netClassRegex.Matches( last ) )
            {
                BOARD_DESIGN_SETTINGS&         bds = m_board->GetDesignSettings();
                std::shared_ptr<NET_SETTINGS>& netSettings = bds.m_NetSettings;
 
                for( const auto& [name, netclass] : netSettings->GetNetclasses() )
                    tokens += wxT( "|" ) + name;
            }
            else if( netNameRegex.Matches( last ) )
            {
                for( const wxString& netnameCandidate : m_board->GetNetClassAssignmentCandidates() )
                    tokens += wxT( "|" ) + netnameCandidate;
            }
            else if( typeRegex.Matches( last ) )
            {
                tokens = wxT( "Bitmap|"
                              "Dimension|"
                              "Footprint|"
                              "Graphic|"
                              "Group|"
                              "Leader|"
                              "Pad|"
                              "Target|"
                              "Text|"
                              "Text Box|"
                              "Track|"
                              "Via|"
                              "Zone" );
            }
            else if( viaTypeRegex.Matches( last ) )
            {
                tokens = wxT( "Through|"
                              "Blind/buried|"
                              "Micro" );
            }
            else if( padTypeRegex.Matches( last ) )
            {
                tokens = wxT( "Through-hole|"
                              "SMD|"
                              "Edge connector|"
                              "NPTH, mechanical" );
            }
            else if( pinTypeRegex.Matches( last ) )
            {
                tokens = wxT( "Input|"
                              "Output|"
                              "Bidirectional|"
                              "Tri-state|"
                              "Passive|"
                              "Free|"
                              "Unspecified|"
                              "Power input|"
                              "Power output|"
                              "Open collector|"
                              "Open emitter|"
                              "Unconnected" );
            }
            else if( fabPropRegex.Matches( last ) )
            {
                tokens = wxT( "None|"
                              "BGA pad|"
                              "Fiducial, global to board|"
                              "Fiducial, local to footprint|"
                              "Test point pad|"
                              "Heatsink pad|"
                              "Castellated pad" );
            }
            else if( shapeRegex.Matches( last ) )
            {
                tokens = wxT( "Segment|"
                              "Rectangle|"
                              "Arc|"
                              "Circle|"
                              "Polygon|"
                              "Bezier" );
            }
            else if( padShapeRegex.Matches( last ) )
            {
                tokens = wxT( "Circle|"
                              "Rectangle|"
                              "Oval|"
                              "Trapezoid|"
                              "Rounded rectangle|"
                              "Chamfered rectangle|"
                              "Custom" );
            }
            else if( padConnectionsRegex.Matches( last ) )
            {
                tokens = wxT( "Inherited|"
                              "None|"
                              "Solid|"
                              "Thermal reliefs|"
                              "Thermal reliefs for PTH" );
            }
            else if( zoneConnStyleRegex.Matches( last ) )
            {
                tokens = wxT( "Inherited|"
                              "None|"
                              "Solid|"
                              "Thermal reliefs" );
            }
            else if( lineStyleRegex.Matches( last ) )
            {
                tokens = wxT( "Default|"
                              "Solid|"
                              "Dashed|"
                              "Dotted|"
                              "Dash-Dot|"
                              "Dash-Dot-Dot" );
            }
            else if( hJustRegex.Matches( last ) )
            {
                tokens = wxT( "Left|"
                              "Center|"
                              "Right" );
            }
            else if( vJustRegex.Matches( last ) )
            {
                tokens = wxT( "Top|"
                              "Center|"
                              "Bottom" );
            }
        }
    }
 
    if( !tokens.IsEmpty() )
        m_scintillaTricks->DoAutocomplete( partial, wxSplit( tokens, '|' ) );
}
 
 
void PANEL_DRC_RULE_EDITOR::onSyntaxHelp( wxHyperlinkEvent& aEvent )
{
    if( m_helpWindow )
    {
        m_helpWindow->ShowModeless();
        return;
    }
 
    std::vector<wxString> msg;
    msg.clear();
 
    wxString t =
#include <panel_setup_condition_help_1clauses.h>
            ;
    msg.emplace_back( t );
 
    t =
#include <panel_setup_rules_help_3items.h>
            ;
    msg.emplace_back( t );
 
    t =
#include "dialogs/panel_setup_rules_help_5examples.h"
            ;
    msg.emplace_back( t );
 
    t =
#include "dialogs/panel_setup_rules_help_6notes.h"
            ;
    msg.emplace_back( t );
 
    t =
#include "dialogs/panel_setup_rules_help_7properties.h"
            ;
    msg.emplace_back( t );
 
    t =
#include "dialogs/panel_setup_rules_help_8expression_functions.h"
            ;
    msg.emplace_back( t );
 
    t =
#include "dialogs/panel_setup_rules_help_9more_examples.h"
            ;
    msg.emplace_back( t );
 
    t =
#include "dialogs/panel_setup_rules_help_10documentation.h"
            ;
    msg.emplace_back( t );
 
 
    wxString msg_txt = wxEmptyString;
 
    for( wxString i : msg )
        msg_txt << wxGetTranslation( i );
 
#ifdef __WXMAC__
    msg_txt.Replace( wxT( "Ctrl+" ), wxT( "Cmd+" ) );
#endif
    const wxString& msGg_txt = msg_txt;
 
    m_helpWindow = new HTML_MESSAGE_BOX( this, _( "Syntax Help" ) );
    m_helpWindow->SetDialogSizeInDU( 420, 320 );
 
    wxString html_txt = wxEmptyString;
    ConvertMarkdown2Html( msGg_txt, html_txt );
 
    html_txt.Replace( wxS( "<td" ), wxS( "<td valign=top" ) );
    m_helpWindow->AddHTML_Text( html_txt );
 
    m_helpWindow->ShowModeless();
}
 
 
void PANEL_DRC_RULE_EDITOR::onCheckSyntax( wxCommandEvent& event )
{
    m_syntaxErrorReport->Clear();
 
    // Get the complete condition from the condition group panel
    wxString condition = m_conditionGroupPanel->BuildCondition();
 
    if( condition.IsEmpty() )
    {
        wxString msg = _( "ERROR: No condition text provided for validation." );
        m_syntaxErrorReport->Report( msg, RPT_SEVERITY_ERROR );
        m_syntaxErrorReport->Flush();
        return;
    }
 
    try
    {
        std::vector<std::shared_ptr<DRC_RULE>> dummyRules;
        wxString ruleTemplate = L"(version 1)\n(rule default\n   (condition \"%s\")\n)";
        wxString formattedRule = wxString::Format( ruleTemplate, condition );
        DRC_RULES_PARSER ruleParser( formattedRule, _( "DRC rule" ) );
        ruleParser.Parse( dummyRules, m_syntaxErrorReport );
    }
    catch( PARSE_ERROR& pe )
    {
        wxString msg = wxString::Format( wxT( "%s <a href='%d:%d'>%s</a>" ),
                                         _( "ERROR:" ),
                                         pe.lineNumber, pe.byteIndex, pe.ParseProblem() );
 
        m_syntaxErrorReport->Report( msg, RPT_SEVERITY_ERROR );
    }
 
    m_syntaxErrorReport->Flush();
}
 
 
void PANEL_DRC_RULE_EDITOR::onErrorLinkClicked( wxHtmlLinkEvent& event )
{
    wxString      link = event.GetLinkInfo().GetHref();
    wxArrayString parts;
    long          line = 0, offset = 0;
 
    wxStringSplit( link, parts, ':' );
 
    if( parts.size() > 1 )
    {
        parts[0].ToLong( &line );
        parts[1].ToLong( &offset );
    }
 
    int pos = m_textConditionCtrl->PositionFromLine( line - 1 ) + ( offset - 1 );
 
    m_textConditionCtrl->GotoPos( pos );
 
    m_textConditionCtrl->SetFocus();
}
 
 
void PANEL_DRC_RULE_EDITOR::onContextMenu( wxMouseEvent& event )
{
    wxMenu menu;
 
    menu.Append( wxID_UNDO, _( "Undo" ) );
    menu.Append( wxID_REDO, _( "Redo" ) );
 
    menu.AppendSeparator();
 
    menu.Append( 1, _( "Cut" ) );  // Don't use wxID_CUT, wxID_COPY, etc.  On Mac (at least),
    menu.Append( 2, _( "Copy" ) ); // wxWidgets never delivers them to us.
    menu.Append( 3, _( "Paste" ) );
    menu.Append( 4, _( "Delete" ) );
 
    menu.AppendSeparator();
 
    menu.Append( 5, _( "Select All" ) );
 
    menu.AppendSeparator();
 
    menu.Append( wxID_ZOOM_IN, _( "Zoom In" ) );
    menu.Append( wxID_ZOOM_OUT, _( "Zoom Out" ) );
 
 
    switch( GetPopupMenuSelectionFromUser( menu ) )
    {
    case wxID_UNDO: m_textConditionCtrl->Undo(); break;
    case wxID_REDO: m_textConditionCtrl->Redo(); break;
 
    case 1: m_textConditionCtrl->Cut(); break;
    case 2: m_textConditionCtrl->Copy(); break;
    case 3: m_textConditionCtrl->Paste(); break;
    case 4:
    {
        long from, to;
        m_textConditionCtrl->GetSelection( &from, &to );
 
        if( to > from )
            m_textConditionCtrl->DeleteRange( from, to );
 
        break;
    }
 
    case 5: m_textConditionCtrl->SelectAll(); break;
 
    case wxID_ZOOM_IN: m_textConditionCtrl->ZoomIn(); break;
    case wxID_ZOOM_OUT: m_textConditionCtrl->ZoomOut(); break;
    }
}
 
 
void PANEL_DRC_RULE_EDITOR::onShowMatchesButtonClicked( wxCommandEvent& event )
{
    if( !m_constraintData )
    {
        wxLogTrace( KI_TRACE_DRC_RULE_EDITOR, wxS( "Show Matches clicked: no constraint data" ) );
        return;
    }
 
    wxLogTrace( KI_TRACE_DRC_RULE_EDITOR,
                wxS( "Show Matches clicked: nodeId=%d, rule='%s', code='%s'" ),
                m_constraintData->GetId(), m_constraintData->GetRuleName(),
                m_constraintData->GetConstraintCode() );
 
    if( m_callBackShowMatches )
    {
        int matchCount = m_callBackShowMatches( m_constraintData->GetId() );
 
        if( matchCount < 0 )
        {
            m_btnShowMatches->SetLabel( _( "Show Matches (error)" ) );
        }
        else
        {
            m_btnShowMatches->SetLabel( wxString::Format( _( "Show Matches (%d)" ), matchCount ) );
        }
    }
}
 
 
void PANEL_DRC_RULE_EDITOR::ResetShowMatchesButton()
{
    m_btnShowMatches->SetLabel( _( "Show Matches" ) );
}
 
 
void PANEL_DRC_RULE_EDITOR::populateLayerSelector( DRC_LAYER_CATEGORY aCategory )
{
    m_layerListChoiceCtrl->Clear();
    m_layerIDs.clear();
 
    m_layerListChoiceCtrl->Append( _( "Any" ) );
 
    switch( aCategory )
    {
    case DRC_LAYER_CATEGORY::COPPER_ONLY:
        m_layerListChoiceCtrl->Append( DRC_RULES_LEXER::TokenName( DRCRULE_T::T_outer ) );
        m_layerIDs.push_back( LAYER_SEL_OUTER );
        m_layerListChoiceCtrl->Append( DRC_RULES_LEXER::TokenName( DRCRULE_T::T_inner ) );
        m_layerIDs.push_back( LAYER_SEL_INNER );
 
        for( PCB_LAYER_ID id : m_board->GetEnabledLayers().CuStack() )
        {
            m_layerListChoiceCtrl->Append( m_board->GetLayerName( id ) );
            m_layerIDs.push_back( static_cast<int>( id ) );
        }
 
        break;
 
    case DRC_LAYER_CATEGORY::SILKSCREEN_ONLY:
        m_layerListChoiceCtrl->Append( m_board->GetLayerName( F_SilkS ) );
        m_layerIDs.push_back( static_cast<int>( F_SilkS ) );
        m_layerListChoiceCtrl->Append( m_board->GetLayerName( B_SilkS ) );
        m_layerIDs.push_back( static_cast<int>( B_SilkS ) );
        break;
 
    case DRC_LAYER_CATEGORY::SOLDERMASK_ONLY:
        m_layerListChoiceCtrl->Append( m_board->GetLayerName( F_Mask ) );
        m_layerIDs.push_back( static_cast<int>( F_Mask ) );
        m_layerListChoiceCtrl->Append( m_board->GetLayerName( B_Mask ) );
        m_layerIDs.push_back( static_cast<int>( B_Mask ) );
        break;
 
    case DRC_LAYER_CATEGORY::SOLDERPASTE_ONLY:
        m_layerListChoiceCtrl->Append( m_board->GetLayerName( F_Paste ) );
        m_layerIDs.push_back( static_cast<int>( F_Paste ) );
        m_layerListChoiceCtrl->Append( m_board->GetLayerName( B_Paste ) );
        m_layerIDs.push_back( static_cast<int>( B_Paste ) );
        break;
 
    case DRC_LAYER_CATEGORY::TOP_BOTTOM_ANY:
        m_layerListChoiceCtrl->Append( _( "Top" ) );
        m_layerIDs.push_back( LAYER_SEL_TOP );
        m_layerListChoiceCtrl->Append( _( "Bottom" ) );
        m_layerIDs.push_back( LAYER_SEL_BOTTOM );
        break;
 
    case DRC_LAYER_CATEGORY::GENERAL_ANY_LAYER:
        m_layerListChoiceCtrl->Append( _( "outer" ) );
        m_layerIDs.push_back( LAYER_SEL_OUTER );
        m_layerListChoiceCtrl->Append( _( "inner" ) );
        m_layerIDs.push_back( LAYER_SEL_INNER );
 
        for( PCB_LAYER_ID id : m_board->GetEnabledLayers().UIOrder() )
        {
            m_layerListChoiceCtrl->Append( m_board->GetLayerName( id ) );
            m_layerIDs.push_back( static_cast<int>( id ) );
        }
 
        break;
 
    case DRC_LAYER_CATEGORY::NO_LAYER_SELECTOR:
        // No layers to add - selector will be hidden
        break;
    }
 
    m_layerListChoiceCtrl->SetSelection( 0 );
}
 
 
wxString PANEL_DRC_RULE_EDITOR::buildLayerClause() const
{
    if( !m_layerListChoiceCtrl || !m_board )
        return wxEmptyString;
 
    int selection = m_layerListChoiceCtrl->GetSelection();
 
    if( selection <= 0 )
        return wxEmptyString;
 
    size_t index = static_cast<size_t>( selection - 1 );
 
    if( index >= m_layerIDs.size() )
        return wxEmptyString;
 
    int layerValue = m_layerIDs[index];
 
    // Handle synthetic layers
    if( layerValue < 0 )
    {
        switch( layerValue )
        {
        case LAYER_SEL_OUTER:
            return wxString::Format( wxS( "(layer %s)" ), DRC_RULES_LEXER::TokenName( DRCRULE_T::T_outer ) );
 
        case LAYER_SEL_INNER:
            return wxString::Format( wxS( "(layer %s)" ), DRC_RULES_LEXER::TokenName( DRCRULE_T::T_inner ) );
 
        case LAYER_SEL_TOP:
            return DRC_RULE_EDITOR_UTILS::TranslateTopBottomLayer( m_constraintType, true );
 
        case LAYER_SEL_BOTTOM:
            return DRC_RULE_EDITOR_UTILS::TranslateTopBottomLayer( m_constraintType, false );
 
        default:
            return wxEmptyString;
        }
    }
 
    // Real layer ID
    PCB_LAYER_ID layerId = static_cast<PCB_LAYER_ID>( layerValue );
    wxString clause = wxString::Format( wxS( "(layer \"%s\")" ), m_board->GetLayerName( layerId ) );
    wxLogTrace( KI_TRACE_DRC_RULE_EDITOR, wxS( "Layer clause: %s" ), clause );
    return clause;
}
 
std::vector<PCB_LAYER_ID> PANEL_DRC_RULE_EDITOR::getSelectedLayers()
{
    int sel = m_layerListChoiceCtrl->GetSelection();
 
    if( sel <= 0 )
    {
        if( m_layerCategory == DRC_LAYER_CATEGORY::SILKSCREEN_ONLY )
            return { F_SilkS, B_SilkS };
 
        return {};
    }
 
    int layerValue = m_layerIDs[sel - 1];
 
    // Translate pseudo-IDs to real layer IDs
    if( layerValue < 0 )
    {
        switch( layerValue )
        {
        case LAYER_SEL_OUTER:  return { F_Cu, B_Cu };
        case LAYER_SEL_INNER:  return { In1_Cu };
        case LAYER_SEL_TOP:    return { F_Cu };
        case LAYER_SEL_BOTTOM: return { B_Cu };
        default:               return {};
        }
    }
 
    return { static_cast<PCB_LAYER_ID>( layerValue ) };
}
 
 
void PANEL_DRC_RULE_EDITOR::setSelectedLayers( const std::vector<PCB_LAYER_ID>& aLayers,
                                                const wxString& aLayerSource )
{
    // Check for synthetic layer keywords first (for round-trip preservation)
    if( aLayerSource == DRC_RULES_LEXER::TokenName( DRCRULE_T::T_outer ) )
    {
        for( size_t i = 0; i < m_layerIDs.size(); ++i )
        {
            if( m_layerIDs[i] == LAYER_SEL_OUTER )
            {
                m_layerListChoiceCtrl->SetSelection( static_cast<int>( i ) + 1 );
                return;
            }
        }
    }
 
    if( aLayerSource == DRC_RULES_LEXER::TokenName( DRCRULE_T::T_inner ) )
    {
        for( size_t i = 0; i < m_layerIDs.size(); ++i )
        {
            if( m_layerIDs[i] == LAYER_SEL_INNER )
            {
                m_layerListChoiceCtrl->SetSelection( static_cast<int>( i ) + 1 );
                return;
            }
        }
    }
 
    // Map real layer IDs to Top/Bottom pseudo-entries (for TOP_BOTTOM_ANY dropdowns)
    if( !aLayers.empty() )
    {
        PCB_LAYER_ID target = aLayers.front();
        bool         isFront = IsFrontLayer( target );
        bool         isBack = IsBackLayer( target );
 
        if( isFront || isBack )
        {
            int pseudoId = isFront ? LAYER_SEL_TOP : LAYER_SEL_BOTTOM;
 
            for( size_t i = 0; i < m_layerIDs.size(); ++i )
            {
                if( m_layerIDs[i] == pseudoId )
                {
                    m_layerListChoiceCtrl->SetSelection( static_cast<int>( i ) + 1 );
                    return;
                }
            }
        }
    }
 
    // Handle empty layers (default to "Any")
    if( aLayers.empty() )
    {
        m_layerListChoiceCtrl->SetSelection( 0 );
        return;
    }
 
    // Find and select the matching layer
    int target = static_cast<int>( aLayers.front() );
 
    for( size_t i = 0; i < m_layerIDs.size(); ++i )
    {
        if( m_layerIDs[i] == target )
        {
            m_layerListChoiceCtrl->SetSelection( static_cast<int>( i ) + 1 );
            return;
        }
    }
 
    m_layerListChoiceCtrl->SetSelection( 0 );
}