dialog_drc_rule_editor.cpp

Go to the documentation of this file.

/*
 * This program source code file is part of KiCad, a free EDA CAD application.
 *
 * Copyright (C) 2024 KiCad Developers, see AUTHORS.txt for contributors.
 *
 * This program is free software: you can redistribute it and/or modify it
 * under the terms of the GNU General Public License as published by the
 * Free Software Foundation, either version 3 of the License, or (at your
 * option) any later version.
 *
 * This program is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
 
#include <drc/drc_engine.h>
#include <widgets/wx_infobar.h>
#include <widgets/wx_progress_reporters.h>
#include <widgets/appearance_controls.h>
 
#include <wx/log.h>
#include <confirm.h>
#include <pcb_edit_frame.h>
#include <kiface_base.h>
#include <drc/drc_rule_parser.h>
 
#include "dialog_drc_rule_editor.h"
#include "panel_drc_rule_editor.h"
#include "drc_rule_editor_enums.h"
#include "drc_re_base_constraint_data.h"
#include "drc_re_numeric_input_constraint_data.h"
#include "drc_re_bool_input_constraint_data.h"
#include "drc_re_via_style_constraint_data.h"
#include "drc_re_abs_length_two_constraint_data.h"
#include "drc_re_min_txt_ht_th_constraint_data.h"
#include "drc_re_rtg_diff_pair_constraint_data.h"
#include "drc_re_routing_width_constraint_data.h"
#include "drc_re_permitted_layers_constraint_data.h"
#include "drc_re_allowed_orientation_constraint_data.h"
#include "drc_re_custom_rule_constraint_data.h"
#include "drc_re_vias_under_smd_constraint_data.h"
#include "drc_re_rule_loader.h"
#include "drc_re_rule_saver.h"
#include <drc/drc_engine.h>
#include <drc/drc_rule_condition.h>
#include <tool/tool_manager.h>
#include <tool/actions.h>
#include <wx/ffile.h>
#include <functional>
#include <memory>
#include <set>
 
 
const RULE_TREE_NODE* FindNodeById( const std::vector<RULE_TREE_NODE>& aNodes, int aTargetId )
{
    auto it = std::find_if( aNodes.begin(), aNodes.end(),
                            [aTargetId]( const RULE_TREE_NODE& node )
                            {
                                return node.m_nodeId == aTargetId;
                            } );
 
    if( it != aNodes.end() )
    {
        return &( *it );
    }
 
    return nullptr;
}
 
 
DIALOG_DRC_RULE_EDITOR::DIALOG_DRC_RULE_EDITOR( PCB_EDIT_FRAME* aEditorFrame, wxWindow* aParent ) :
        RULE_EDITOR_DIALOG_BASE( aParent, _( "Design Rule Editor" ), wxSize( 980, 800 ) ),
        PROGRESS_REPORTER_BASE( 1 ),
        m_reporter( nullptr ),
        m_nodeId( 0 )
{
    m_frame = aEditorFrame;
    m_currentBoard = m_frame->GetBoard();
    m_ruleEditorPanel = nullptr;
 
    m_ruleTreeCtrl->DeleteAllItems();
 
    m_ruleTreeNodeDatas = GetDefaultRuleTreeItems();
 
    SetName( DIALOG_DRC_RULE_EDITOR_WINDOW_NAME );
 
    InitRuleTreeItems( m_ruleTreeNodeDatas );
 
    LoadExistingRules();
 
    if( Prj().IsReadOnly() )
    {
        m_infoBar->ShowMessage( _( "Project is missing or read-only. Settings will not be "
                                   "editable." ),
                                wxICON_WARNING );
    }
 
    m_severities = 0;
 
    m_markersProvider = std::make_shared<DRC_ITEMS_PROVIDER>( m_currentBoard, MARKER_BASE::MARKER_DRC,
                                                              MARKER_BASE::MARKER_DRAWING_SHEET );
 
    m_markerDataView =
            new wxDataViewCtrl( this, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxDV_ROW_LINES | wxDV_SINGLE );
 
    m_markersTreeModel = new RC_TREE_MODEL( m_frame, m_markerDataView );
    m_markerDataView->AssociateModel( m_markersTreeModel );
    m_markersTreeModel->Update( m_markersProvider, m_severities );
 
    m_markerDataView->Hide();
}
 
 
DIALOG_DRC_RULE_EDITOR::~DIALOG_DRC_RULE_EDITOR()
{
}
 
 
bool DIALOG_DRC_RULE_EDITOR::TransferDataToWindow()
{
    bool ok = RULE_EDITOR_DIALOG_BASE::TransferDataToWindow();
 
    Layout();
    SetMinSize( wxSize( 400, 500 ) );
    SetSize( m_initialSize );
 
    wxLogTrace( "debug_dlg_size", "DRC TransferDataToWindow: size=%s minSize=%s",
                GetSize().IsFullySpecified() ? wxString::Format( "%dx%d", GetSize().x, GetSize().y )
                                             : wxString( "default" ),
                GetMinSize().IsFullySpecified()
                        ? wxString::Format( "%dx%d", GetMinSize().x, GetMinSize().y )
                        : wxString( "default" ) );
 
    return ok;
}
 
 
bool DIALOG_DRC_RULE_EDITOR::TransferDataFromWindow()
{
    if( !RULE_EDITOR_DIALOG_BASE::TransferDataFromWindow() )
        return false;
 
    SaveRulesToFile();
 
    return true;
}
 
 
std::vector<RULE_TREE_NODE> DIALOG_DRC_RULE_EDITOR::GetDefaultRuleTreeItems()
{
    std::vector<RULE_TREE_NODE> result;
 
    int lastParentId;
    int electricalItemId;
    int manufacturabilityItemId;
    int highSpeedDesignId;
    int footprintItemId;
 
    result.push_back( buildRuleTreeNodeData( "Design Rules", DRC_RULE_EDITOR_ITEM_TYPE::ROOT ) );
    lastParentId = m_nodeId;
 
    result.push_back( buildRuleTreeNodeData( "Electrical", DRC_RULE_EDITOR_ITEM_TYPE::CATEGORY, lastParentId ) );
    electricalItemId = m_nodeId;
 
    result.push_back( buildRuleTreeNodeData( "Manufacturability", DRC_RULE_EDITOR_ITEM_TYPE::CATEGORY, lastParentId ) );
    manufacturabilityItemId = m_nodeId;
 
    result.push_back( buildRuleTreeNodeData( "Highspeed design", DRC_RULE_EDITOR_ITEM_TYPE::CATEGORY, lastParentId ) );
    highSpeedDesignId = m_nodeId;
 
    result.push_back( buildRuleTreeNodeData( "Footprints", DRC_RULE_EDITOR_ITEM_TYPE::CATEGORY, lastParentId ) );
    footprintItemId = m_nodeId;
 
    std::vector<RULE_TREE_NODE> subItemNodes = buildElectricalRuleTreeNodes( electricalItemId );
    result.insert( result.end(), subItemNodes.begin(), subItemNodes.end() );
 
    subItemNodes = buildManufacturabilityRuleTreeNodes( manufacturabilityItemId );
    result.insert( result.end(), subItemNodes.begin(), subItemNodes.end() );
 
    subItemNodes = buildHighspeedDesignRuleTreeNodes( highSpeedDesignId );
    result.insert( result.end(), subItemNodes.begin(), subItemNodes.end() );
 
    subItemNodes = buildFootprintsRuleTreeNodes( footprintItemId );
    result.insert( result.end(), subItemNodes.begin(), subItemNodes.end() );
 
    // Custom rules category
    result.push_back( buildRuleTreeNodeData( "Custom", DRC_RULE_EDITOR_ITEM_TYPE::CATEGORY, lastParentId ) );
    int customItemId = m_nodeId;
    result.push_back(
            buildRuleTreeNodeData( "Custom rule", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, customItemId, CUSTOM_RULE ) );
 
    return result;
}
 
void DIALOG_DRC_RULE_EDITOR::LoadExistingRules()
{
    if( !m_frame->GetBoard() )
        return;
 
    wxFileName rulesFile( m_frame->GetBoard()->GetDesignRulesPath() );
 
    if( !rulesFile.FileExists() )
        return;
 
    DRC_RULE_LOADER loader;
    std::vector<DRC_RE_LOADED_PANEL_ENTRY> entries = loader.LoadFile( rulesFile.GetFullPath() );
 
    if( entries.empty() )
        return;
 
    wxLogTrace( wxS( "KI_TRACE_DRC_RULE_EDITOR" ),
                wxS( "[LoadExistingRules] Loaded %zu entries from %s" ),
                entries.size(), rulesFile.GetFullPath() );
 
    // Build lookup maps before the loading loop to avoid O(n) scans per rule.
    // constraintTypeToNodeId maps panel type → parent node ID (from m_ruleTreeNodeDatas).
    // m_treeHistoryData already maps node ID → wxTreeItemId (populated by InitRuleTreeItems).
    std::unordered_map<int, int> constraintTypeToNodeId;
 
    for( const RULE_TREE_NODE& node : m_ruleTreeNodeDatas )
    {
        if( node.m_nodeType == CONSTRAINT && node.m_nodeTypeMap )
        {
            constraintTypeToNodeId[*node.m_nodeTypeMap] = node.m_nodeId;
 
            wxLogTrace( wxS( "KI_TRACE_DRC_RULE_EDITOR" ),
                        wxS( "[LoadExistingRules]   Node '%s': nodeId=%d, m_nodeTypeMap=%d" ),
                        wxString( node.m_nodeName ), node.m_nodeId,
                        static_cast<int>( *node.m_nodeTypeMap ) );
        }
    }
 
    // Suppress selection-change events and repaint during bulk loading. Without this,
    // each AppendNewRuleTreeItem triggers SelectItem which creates and immediately
    // destroys a full PANEL_DRC_RULE_EDITOR (regex compilation, Scintilla, layout)
    // for every rule. On Windows this causes >11s load times for moderate rule sets.
    m_ruleTreeCtrl->Freeze();
    m_suppressSelectionEvents = true;
 
    for( DRC_RE_LOADED_PANEL_ENTRY& entry : entries )
    {
        DRC_RULE_EDITOR_CONSTRAINT_NAME type = entry.panelType;
 
        wxLogTrace( wxS( "KI_TRACE_DRC_RULE_EDITOR" ),
                    wxS( "[LoadExistingRules] Processing entry: rule='%s', panelType=%d" ),
                    entry.ruleName, static_cast<int>( type ) );
 
        auto typeIt = constraintTypeToNodeId.find( static_cast<int>( type ) );
 
        if( typeIt == constraintTypeToNodeId.end() )
        {
            wxLogTrace( wxS( "KI_TRACE_DRC_RULE_EDITOR" ),
                        wxS( "[LoadExistingRules] No parent found for panelType=%d, skipping" ),
                        static_cast<int>( type ) );
            continue;
        }
 
        int parentId = typeIt->second;
 
        auto histIt = m_treeHistoryData.find( parentId );
 
        if( histIt == m_treeHistoryData.end() )
        {
            wxLogTrace( wxS( "KI_TRACE_DRC_RULE_EDITOR" ),
                        wxS( "[LoadExistingRules] Tree item not found for parentId=%d, skipping" ),
                        parentId );
            continue;
        }
 
        wxTreeItemId parentItem = std::get<2>( histIt->second );
 
        if( !parentItem.IsOk() )
        {
            wxLogTrace( wxS( "KI_TRACE_DRC_RULE_EDITOR" ),
                        wxS( "[LoadExistingRules] Tree item not valid for parentId=%d, skipping" ),
                        parentId );
            continue;
        }
 
        wxLogTrace( wxS( "KI_TRACE_DRC_RULE_EDITOR" ),
                    wxS( "[LoadExistingRules] Found parent node: parentId=%d" ), parentId );
 
        RULE_TREE_NODE node =
                buildRuleTreeNodeData( entry.ruleName, RULE, parentId, type );
 
        auto ruleData = std::dynamic_pointer_cast<DRC_RE_BASE_CONSTRAINT_DATA>( entry.constraintData );
 
        if( ruleData )
        {
            ruleData->SetId( node.m_nodeData->GetId() );
            ruleData->SetParentId( parentId );
            ruleData->SetOriginalRuleText( entry.originalRuleText );
            ruleData->SetWasEdited( entry.wasEdited );
            ruleData->SetLayerSource( entry.layerSource );
 
            if( !entry.layerSource.IsEmpty() )
                ruleData->SetLayers( entry.layerCondition.Seq() );
 
            ruleData->SetSeverity( entry.severity );
            node.m_nodeData = ruleData;
        }
 
        m_ruleTreeNodeDatas.push_back( node );
        AppendNewRuleTreeItem( node, parentItem );
 
        wxLogTrace( wxS( "KI_TRACE_DRC_RULE_EDITOR" ),
                    wxS( "[LoadExistingRules] Appended rule '%s' to tree under parentId=%d" ),
                    entry.ruleName, parentId );
    }
 
    m_suppressSelectionEvents = false;
    m_ruleTreeCtrl->Thaw();
}
 
 
void DIALOG_DRC_RULE_EDITOR::AddNewRule( RULE_TREE_ITEM_DATA* aRuleTreeItemData )
{
    wxTreeItemId    treeItemId;
    RULE_TREE_NODE* nodeDetail = getRuleTreeNodeInfo( aRuleTreeItemData->GetNodeId() );
 
    if( nodeDetail->m_nodeType == CONSTRAINT )
    {
        treeItemId = aRuleTreeItemData->GetTreeItemId();
    }
    else
    {
        treeItemId = aRuleTreeItemData->GetParentTreeItemId();
    }
 
    AppendNewRuleTreeItem( buildRuleTreeNode( aRuleTreeItemData ), treeItemId );
    SetModified();
}
 
 
void DIALOG_DRC_RULE_EDITOR::DuplicateRule( RULE_TREE_ITEM_DATA* aRuleTreeItemData )
{                                                                                                                     
    RULE_TREE_NODE* sourceTreeNode = getRuleTreeNodeInfo( aRuleTreeItemData->GetNodeId() );                           
 
    auto sourceDataPtr = dynamic_pointer_cast<RULE_EDITOR_DATA_BASE>( sourceTreeNode->m_nodeData );
 
    if( !sourceDataPtr )
        return;
 
    // Strip any trailing " <number>" suffix so the number increments
    wxString baseName = sourceDataPtr->GetRuleName();
    int      lastSpace = baseName.Find( ' ', true );
 
    if( lastSpace != wxNOT_FOUND )
    {
        wxString suffix = baseName.Mid( lastSpace + 1 );
        long     num;
 
        if( suffix.ToLong( &num ) )
            baseName = baseName.Left( lastSpace );
    }
 
    RULE_TREE_NODE targetTreeNode = buildRuleTreeNode( aRuleTreeItemData, baseName );
    targetTreeNode.m_nodeData->CopyFrom( *sourceDataPtr );
 
    wxTreeItemId treeItemId = aRuleTreeItemData->GetParentTreeItemId();
    AppendNewRuleTreeItem( targetTreeNode, treeItemId );
    SetModified();
}
 
 
void DIALOG_DRC_RULE_EDITOR::RuleTreeItemSelectionChanged( RULE_TREE_ITEM_DATA* aCurrentRuleTreeItemData )
{
    RULE_TREE_NODE* nodeDetail = getRuleTreeNodeInfo( aCurrentRuleTreeItemData->GetNodeId() );
 
    // Freeze so panel creation and data population happen off-screen.
    m_scrolledContentWin->Freeze();
 
    if( nodeDetail->m_nodeType == ROOT || nodeDetail->m_nodeType == CATEGORY || nodeDetail->m_nodeType == CONSTRAINT )
    {
        std::vector<RULE_TREE_NODE*> ruleNodes;
        collectChildRuleNodes( nodeDetail->m_nodeId, ruleNodes );
 
        std::vector<DRC_RULE_ROW> rows;
        rows.reserve( ruleNodes.size() );
 
        for( RULE_TREE_NODE* ruleNode : ruleNodes )
        {
            RULE_TREE_NODE* parentNode = getRuleTreeNodeInfo( ruleNode->m_nodeData->GetParentId() );
            wxString        type = parentNode ? parentNode->m_nodeName : wxString{};
            rows.push_back( { type, ruleNode->m_nodeData->GetRuleName(), ruleNode->m_nodeData->GetComment() } );
        }
 
        m_groupHeaderPanel = new PANEL_DRC_GROUP_HEADER( m_scrolledContentWin, rows );
        SetContentPanel( m_groupHeaderPanel );
        m_ruleEditorPanel = nullptr;
    }
    else if( nodeDetail->m_nodeType == RULE )
    {
        RULE_TREE_ITEM_DATA* parentItemData = dynamic_cast<RULE_TREE_ITEM_DATA*>(
                m_ruleTreeCtrl->GetItemData( aCurrentRuleTreeItemData->GetParentTreeItemId() ) );
        RULE_TREE_NODE* paretNodeDetail = getRuleTreeNodeInfo( parentItemData->GetNodeId() );
        wxString        constraintName = paretNodeDetail->m_nodeName;
 
        m_ruleEditorPanel = new PANEL_DRC_RULE_EDITOR(
                m_scrolledContentWin, m_frame->GetBoard(),
                static_cast<DRC_RULE_EDITOR_CONSTRAINT_NAME>( nodeDetail->m_nodeTypeMap.value_or( -1 ) ),
                &constraintName, dynamic_pointer_cast<DRC_RE_BASE_CONSTRAINT_DATA>( nodeDetail->m_nodeData ) );
 
        SetContentPanel( m_ruleEditorPanel );
        m_ruleEditorPanel->TransferDataToWindow();
 
        m_ruleEditorPanel->SetSaveCallback(
                [this]( int aNodeId )
                {
                    this->saveRule( aNodeId );
                } );
 
        m_ruleEditorPanel->SetRemoveCallback(
                [this]( int aNodeId )
                {
                    this->RemoveRule( aNodeId );
                } );
 
        m_ruleEditorPanel->SetCloseCallback(
                [this]( int aNodeId )
                {
                    this->closeRuleEntryView( aNodeId );
                } );
 
        m_ruleEditorPanel->SetRuleNameValidationCallback(
                [this]( int aNodeId, wxString aRuleName )
                {
                    return this->validateRuleName( aNodeId, aRuleName );
                } );
 
        m_ruleEditorPanel->SetShowMatchesCallBack(
                [this]( int aNodeId ) -> int
                {
                    return this->highlightMatchingItems( aNodeId );
                } );
 
        m_groupHeaderPanel = nullptr;
    }
 
    m_scrolledContentWin->Thaw();
}
 
 
void DIALOG_DRC_RULE_EDITOR::OnSave( wxCommandEvent& aEvent )
{
    if( m_ruleEditorPanel )
        m_ruleEditorPanel->Save( aEvent );
}
 
 
void DIALOG_DRC_RULE_EDITOR::OnCancel( wxCommandEvent& aEvent )
{
    // If currently editing a panel, cancel that first
    if( m_ruleEditorPanel )
    {
        auto data = m_ruleEditorPanel->GetConstraintData();
        bool isNew = data && data->IsNew();
 
        m_ruleEditorPanel->Cancel( aEvent );
 
        if( isNew )
        {
            // After canceling a new rule, check if there are any remaining modified rules
            std::vector<RULE_TREE_NODE*> modifiedRules;
            collectModifiedRules( modifiedRules );
 
            if( modifiedRules.empty() )
                ClearModified();
 
            return;
        }
    }
 
    // If there are unsaved changes, prompt the user
    if( IsModified() )
    {
        int result = promptUnsavedChanges();
 
        if( result == wxID_CANCEL )
            return;
 
        if( result == wxID_YES )
        {
            // Validate all rules before saving
            std::map<wxString, wxString> errors;
 
            if( !validateAllRules( errors ) )
            {
                // Find the first rule with an error and select it
                for( RULE_TREE_NODE& node : m_ruleTreeNodeDatas )
                {
                    if( errors.find( node.m_nodeName ) != errors.end() )
                    {
                        selectRuleNode( node.m_nodeId );
 
                        wxString msg = wxString::Format(
                                _( "Cannot save due to validation errors in rule '%s':\n\n%s" ),
                                node.m_nodeName, errors[node.m_nodeName] );
                        DisplayErrorMessage( this, msg );
                        return;
                    }
                }
 
                return;
            }
 
            SaveRulesToFile();
            ClearModified();
        }
    }
 
    // Purge unsaved new rules from memory so they don't reappear on reopen
    std::vector<int> newRuleNodeIds;
 
    for( const RULE_TREE_NODE& node : m_ruleTreeNodeDatas )
    {
        if( node.m_nodeType == RULE && node.m_nodeData && node.m_nodeData->IsNew() )
            newRuleNodeIds.push_back( node.m_nodeId );
    }
 
    for( int nodeId : newRuleNodeIds )
    {
        auto it = m_treeHistoryData.find( nodeId );
 
        if( it != m_treeHistoryData.end() )
            DeleteRuleTreeItem( std::get<2>( it->second ), nodeId );
 
        deleteTreeNodeData( nodeId );
    }
 
    aEvent.Skip();
}
 
 
void DIALOG_DRC_RULE_EDITOR::UpdateRuleTypeTreeItemData( RULE_TREE_ITEM_DATA* aRuleTreeItemData )
{
    RULE_TREE_NODE* nodeDetail = getRuleTreeNodeInfo( aRuleTreeItemData->GetNodeId() );
 
    if( nodeDetail->m_nodeType == DRC_RULE_EDITOR_ITEM_TYPE::RULE && m_ruleEditorPanel )
    {
        m_ruleEditorPanel->TransferDataFromWindow();
 
        nodeDetail->m_nodeName = nodeDetail->m_nodeData->GetRuleName();
        nodeDetail->m_nodeData->SetIsNew( false );
 
        // Mark as edited so the rule gets regenerated instead of using original text
        auto constraintData =
                std::dynamic_pointer_cast<DRC_RE_BASE_CONSTRAINT_DATA>( nodeDetail->m_nodeData );
 
        if( constraintData )
            constraintData->SetWasEdited( true );
 
        UpdateRuleTreeItemText( aRuleTreeItemData->GetTreeItemId(), nodeDetail->m_nodeName );
    }
}
 
 
bool DIALOG_DRC_RULE_EDITOR::isEnabled( RULE_TREE_ITEM_DATA*         aRuleTreeItemData,
                                                                      RULE_EDITOR_TREE_CONTEXT_OPT aOption )
{
    RULE_TREE_NODE* nodeDetail = getRuleTreeNodeInfo( aRuleTreeItemData->GetNodeId() );
 
    switch( aOption )
    {
    case RULE_EDITOR_TREE_CONTEXT_OPT::ADD_RULE:
        return nodeDetail->m_nodeType == DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT
               || nodeDetail->m_nodeType == DRC_RULE_EDITOR_ITEM_TYPE::RULE;
    case RULE_EDITOR_TREE_CONTEXT_OPT::DUPLICATE_RULE:
    case RULE_EDITOR_TREE_CONTEXT_OPT::DELETE_RULE: return nodeDetail->m_nodeType == DRC_RULE_EDITOR_ITEM_TYPE::RULE;
    case RULE_EDITOR_TREE_CONTEXT_OPT::MOVE_UP:
    case RULE_EDITOR_TREE_CONTEXT_OPT::MOVE_DOWN:
        return nodeDetail->m_nodeType == DRC_RULE_EDITOR_ITEM_TYPE::RULE;
    default: return true;
    }
}
 
 
void DIALOG_DRC_RULE_EDITOR::RemoveRule( int aNodeId )
{
    RULE_TREE_ITEM_DATA* itemData = dynamic_cast<RULE_TREE_ITEM_DATA*>(
            m_ruleTreeCtrl->GetItemData( GetCurrentlySelectedRuleTreeItemData()->GetTreeItemId() ) );
    RULE_TREE_NODE* nodeDetail = getRuleTreeNodeInfo( itemData->GetNodeId() );
 
    if( !nodeDetail->m_nodeData->IsNew() )
    {
        if( OKOrCancelDialog( this, _( "Confirmation" ), "", _( "Are you sure you want to delete?" ), _( "Delete" ) )
            != wxID_OK )
        {
            return;
        }
    }
 
    if( itemData )
    {
        int nodeId = itemData->GetNodeId();
 
        SetModified();
        DeleteRuleTreeItem( GetCurrentlySelectedRuleTreeItemData()->GetTreeItemId(), nodeId );
        deleteTreeNodeData( nodeId );
        SaveRulesToFile();
        ClearModified();
    }
 
    SetControlsEnabled( true );
}
 
 
std::vector<RULE_TREE_NODE> DIALOG_DRC_RULE_EDITOR::buildElectricalRuleTreeNodes( int& aParentId )
{
    std::vector<RULE_TREE_NODE> result;
    int                         lastParentId;
 
    result.push_back( buildRuleTreeNodeData( "Clearance", DRC_RULE_EDITOR_ITEM_TYPE::CATEGORY, aParentId ) );
    lastParentId = m_nodeId;
 
    result.push_back( buildRuleTreeNodeData( "Minimum clearance", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, lastParentId,
                                             MINIMUM_CLEARANCE ) );
    result.push_back( buildRuleTreeNodeData( "Copper to edge clearance", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                             lastParentId, COPPER_TO_EDGE_CLEARANCE ) );
    result.push_back( buildRuleTreeNodeData( "Courtyard clearance", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, lastParentId,
                                             COURTYARD_CLEARANCE ) );
    result.push_back( buildRuleTreeNodeData( "Physical clearance", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, lastParentId,
                                             PHYSICAL_CLEARANCE ) );
    result.push_back( buildRuleTreeNodeData( "Creepage distance", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, lastParentId,
                                             CREEPAGE_DISTANCE ) );
 
    result.push_back( buildRuleTreeNodeData( "Minimum connection width", CONSTRAINT, aParentId,
                                             MINIMUM_CONNECTION_WIDTH ) );
    result.push_back( buildRuleTreeNodeData( "Copper to hole clearance", CONSTRAINT, aParentId,
                                             COPPER_TO_HOLE_CLEARANCE ) );
    result.push_back( buildRuleTreeNodeData( "Minimum thermal relief spoke count", CONSTRAINT, aParentId,
                                             MINIMUM_THERMAL_RELIEF_SPOKE_COUNT ) );
 
    return result;
}
 
 
std::vector<RULE_TREE_NODE> DIALOG_DRC_RULE_EDITOR::buildManufacturabilityRuleTreeNodes( int& aParentId )
{
    std::vector<RULE_TREE_NODE> result;
    int                         lastParentId;
 
    result.push_back( buildRuleTreeNodeData( "Minimum annular width", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                              aParentId, MINIMUM_ANNULAR_WIDTH ) );
 
    result.push_back( buildRuleTreeNodeData( "Hole", DRC_RULE_EDITOR_ITEM_TYPE::CATEGORY, aParentId ) );
    lastParentId = m_nodeId;
    result.push_back( buildRuleTreeNodeData( "Minimum drill size", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                             lastParentId, MINIMUM_DRILL_SIZE ) );
    result.push_back( buildRuleTreeNodeData( "Hole to hole distance", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                             lastParentId, HOLE_TO_HOLE_DISTANCE ) );
    result.push_back(
            buildRuleTreeNodeData( "Via style", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, lastParentId, VIA_STYLE ) );
 
    result.push_back( buildRuleTreeNodeData( "Microvia", DRC_RULE_EDITOR_ITEM_TYPE::CATEGORY, aParentId ) );
    lastParentId = m_nodeId;
    result.push_back( buildRuleTreeNodeData( "Maximum stack depth", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, lastParentId,
                                             MICROVIA_STACK_DEPTH ) );
    result.push_back( buildRuleTreeNodeData( "Maximum aspect ratio", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                             lastParentId, MICROVIA_ASPECT_RATIO ) );
 
    result.push_back( buildRuleTreeNodeData( "Minimum text height and thickness", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                             aParentId, MINIMUM_TEXT_HEIGHT_AND_THICKNESS ) );
 
    result.push_back( buildRuleTreeNodeData( "Silk to silk clearance", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                             aParentId, SILK_TO_SILK_CLEARANCE ) );
    result.push_back( buildRuleTreeNodeData( "Silk to soldermask clearance", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                             aParentId, SILK_TO_SOLDERMASK_CLEARANCE ) );
 
    result.push_back( buildRuleTreeNodeData( "Minimum soldermask sliver", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                             aParentId, MINIMUM_SOLDERMASK_SLIVER ) );
    result.push_back( buildRuleTreeNodeData( "Soldermask expansion", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                             aParentId, SOLDERMASK_EXPANSION ) );
 
    result.push_back( buildRuleTreeNodeData( "Solderpaste expansion", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                             aParentId, SOLDERPASTE_EXPANSION ) );
 
    return result;
}
 
 
std::vector<RULE_TREE_NODE> DIALOG_DRC_RULE_EDITOR::buildHighspeedDesignRuleTreeNodes( int& aParentId )
{
    std::vector<RULE_TREE_NODE> result;
 
    result.push_back(
            buildRuleTreeNodeData( "Routing width", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, aParentId, ROUTING_WIDTH ) );
    result.push_back( buildRuleTreeNodeData( "Maximum via count", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, aParentId,
                                             MAXIMUM_VIA_COUNT ) );
    result.push_back( buildRuleTreeNodeData( "Routing diff pair", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, aParentId,
                                             ROUTING_DIFF_PAIR ) );
    result.push_back( buildRuleTreeNodeData( "Matched length diff pair", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT,
                                             aParentId, MATCHED_LENGTH_DIFF_PAIR ) );
    result.push_back( buildRuleTreeNodeData( "Absolute length", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, aParentId,
                                             ABSOLUTE_LENGTH ) );
 
    return result;
}
 
 
std::vector<RULE_TREE_NODE> DIALOG_DRC_RULE_EDITOR::buildFootprintsRuleTreeNodes( int& aParentId )
{
    std::vector<RULE_TREE_NODE> result;
    result.push_back( buildRuleTreeNodeData( "Permitted layers", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, aParentId,
                                             PERMITTED_LAYERS ) );
    result.push_back( buildRuleTreeNodeData( "Allowed orientation", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, aParentId,
                                             ALLOWED_ORIENTATION ) );
    result.push_back( buildRuleTreeNodeData( "Vias under SMD", DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, aParentId,
                                             VIAS_UNDER_SMD ) );
 
    return result;
}
 

bool nodeExists( const RULE_TREE_NODE& aRuleTreeNode, const wxString& aTargetName )
{
    if( aRuleTreeNode.m_nodeName == aTargetName )
    {
        return true;
    }
 
    for( const auto& child : aRuleTreeNode.m_childNodes )
    {
        if( nodeExists( child, aTargetName ) )
        {
            return true;
        }
    }
 
    return false;
}
 

bool nodeExists( const std::vector<RULE_TREE_NODE>& aRuleTreeNodes, const wxString& aTargetName )
{
    for( const auto& node : aRuleTreeNodes )
    {
        if( nodeExists( node, aTargetName ) )
        {
            return true;
        }
    }
 
    return false;
}
 
 
RULE_TREE_NODE DIALOG_DRC_RULE_EDITOR::buildRuleTreeNode( RULE_TREE_ITEM_DATA* aRuleTreeItemData,
                                                           const wxString& aBaseName )
{
    // Factory function type for creating constraint data objects
    using ConstraintDataFactory =
            std::function<std::shared_ptr<DRC_RE_BASE_CONSTRAINT_DATA>( const DRC_RE_BASE_CONSTRAINT_DATA& )>;
 
    // Factory map for constraint data creation
    static const std::unordered_map<DRC_RULE_EDITOR_CONSTRAINT_NAME, ConstraintDataFactory> s_constraintFactories = {
        { DRC_RULE_EDITOR_CONSTRAINT_NAME::VIA_STYLE,
          []( const DRC_RE_BASE_CONSTRAINT_DATA& data )
          {
              return std::make_shared<DRC_RE_VIA_STYLE_CONSTRAINT_DATA>( data );
          } },
        { DRC_RULE_EDITOR_CONSTRAINT_NAME::MINIMUM_TEXT_HEIGHT_AND_THICKNESS,
          []( const DRC_RE_BASE_CONSTRAINT_DATA& data )
          {
              return std::make_shared<DRC_RE_MINIMUM_TEXT_HEIGHT_THICKNESS_CONSTRAINT_DATA>( data );
          } },
        { DRC_RULE_EDITOR_CONSTRAINT_NAME::ROUTING_DIFF_PAIR,
          []( const DRC_RE_BASE_CONSTRAINT_DATA& data )
          {
              return std::make_shared<DRC_RE_ROUTING_DIFF_PAIR_CONSTRAINT_DATA>( data );
          } },
        { DRC_RULE_EDITOR_CONSTRAINT_NAME::ROUTING_WIDTH,
          []( const DRC_RE_BASE_CONSTRAINT_DATA& data )
          {
              return std::make_shared<DRC_RE_ROUTING_WIDTH_CONSTRAINT_DATA>( data );
          } },
        { DRC_RULE_EDITOR_CONSTRAINT_NAME::PERMITTED_LAYERS,
          []( const DRC_RE_BASE_CONSTRAINT_DATA& data )
          {
              return std::make_shared<DRC_RE_PERMITTED_LAYERS_CONSTRAINT_DATA>( data );
          } },
        { DRC_RULE_EDITOR_CONSTRAINT_NAME::ALLOWED_ORIENTATION,
          []( const DRC_RE_BASE_CONSTRAINT_DATA& data )
          {
              return std::make_shared<DRC_RE_ALLOWED_ORIENTATION_CONSTRAINT_DATA>( data );
          } },
        { DRC_RULE_EDITOR_CONSTRAINT_NAME::CUSTOM_RULE,
          []( const DRC_RE_BASE_CONSTRAINT_DATA& data )
          {
              return std::make_shared<DRC_RE_CUSTOM_RULE_CONSTRAINT_DATA>( data );
          } },
        { DRC_RULE_EDITOR_CONSTRAINT_NAME::ABSOLUTE_LENGTH,
          []( const DRC_RE_BASE_CONSTRAINT_DATA& data )
          {
              return std::make_shared<DRC_RE_ABSOLUTE_LENGTH_TWO_CONSTRAINT_DATA>( data );
          } },
        { DRC_RULE_EDITOR_CONSTRAINT_NAME::MATCHED_LENGTH_DIFF_PAIR,
          []( const DRC_RE_BASE_CONSTRAINT_DATA& data )
          {
              return std::make_shared<DRC_RE_MATCHED_LENGTH_DIFF_PAIR_CONSTRAINT_DATA>( data );
          } },
        { DRC_RULE_EDITOR_CONSTRAINT_NAME::VIAS_UNDER_SMD,
          []( const DRC_RE_BASE_CONSTRAINT_DATA& data )
          {
              return std::make_shared<DRC_RE_VIAS_UNDER_SMD_CONSTRAINT_DATA>( data );
          } }
    };
 
    RULE_TREE_ITEM_DATA* treeItemData;
    RULE_TREE_NODE*      nodeDetail = getRuleTreeNodeInfo( aRuleTreeItemData->GetNodeId() );
 
    if( nodeDetail->m_nodeType == CONSTRAINT )
    {
        treeItemData = aRuleTreeItemData;
    }
    else
    {
        treeItemData = dynamic_cast<RULE_TREE_ITEM_DATA*>(
                m_ruleTreeCtrl->GetItemData( aRuleTreeItemData->GetParentTreeItemId() ) );
        nodeDetail = getRuleTreeNodeInfo( treeItemData->GetNodeId() );
    }
 
    m_nodeId++;
 
    wxString base = aBaseName.IsEmpty() ? nodeDetail->m_nodeName : aBaseName;
    wxString nodeName = base + " 1";
 
    int  loop = 2;
    bool check = false;
 
    do
    {
        check = false;
 
        if( nodeExists( m_ruleTreeNodeDatas, nodeName ) )
        {
            nodeName = base + wxString::Format( " %d", loop );
            loop++;
            check = true;
        }
    } while( check );
 
    RULE_TREE_NODE newRuleNode = buildRuleTreeNodeData(
            nodeName, RULE, nodeDetail->m_nodeId,
            static_cast<DRC_RULE_EDITOR_CONSTRAINT_NAME>( nodeDetail->m_nodeTypeMap.value_or( 0 ) ), {}, m_nodeId );
 
    auto nodeType = static_cast<DRC_RULE_EDITOR_CONSTRAINT_NAME>( newRuleNode.m_nodeTypeMap.value_or( -1 ) );
 
    DRC_RE_BASE_CONSTRAINT_DATA clearanceData( m_nodeId, nodeDetail->m_nodeData->GetId(), newRuleNode.m_nodeName );
 
    if( s_constraintFactories.find( nodeType ) != s_constraintFactories.end() )
    {
        newRuleNode.m_nodeData = s_constraintFactories.at( nodeType )( clearanceData );
    }
    else if( DRC_RULE_EDITOR_UTILS::IsNumericInputType( nodeType ) )
    {
        newRuleNode.m_nodeData = DRC_RULE_EDITOR_UTILS::CreateNumericConstraintData( nodeType, clearanceData );
    }
    else if( DRC_RULE_EDITOR_UTILS::IsBoolInputType( nodeType ) )
    {
        newRuleNode.m_nodeData = std::make_shared<DRC_RE_BOOL_INPUT_CONSTRAINT_DATA>( clearanceData );
    }
    else
    {
        wxLogWarning( "No factory found for constraint type: %d", nodeType );
        newRuleNode.m_nodeData = std::make_shared<DRC_RE_BASE_CONSTRAINT_DATA>( clearanceData );
    }
 
    std::static_pointer_cast<DRC_RE_BASE_CONSTRAINT_DATA>( newRuleNode.m_nodeData )
            ->SetConstraintCode( DRC_RULE_EDITOR_UTILS::ConstraintToKicadDrc( nodeType ) );
    newRuleNode.m_nodeData->SetIsNew( true );
 
    m_ruleTreeNodeDatas.push_back( newRuleNode );
 
    return newRuleNode;
}
 
 
RULE_TREE_NODE* DIALOG_DRC_RULE_EDITOR::getRuleTreeNodeInfo( const int& aNodeId )
{
    auto it = std::find_if( m_ruleTreeNodeDatas.begin(), m_ruleTreeNodeDatas.end(),
                            [aNodeId]( const RULE_TREE_NODE& node )
                            {
                                return node.m_nodeId == aNodeId;
                            } );
 
    if( it != m_ruleTreeNodeDatas.end() )
    {
        return &( *it ); // Return pointer to the found node
    }
    else
        return nullptr;
}
 
 
void DIALOG_DRC_RULE_EDITOR::saveRule( int aNodeId )
{
    if( !m_ruleEditorPanel->GetIsValidationSucceeded() )
    {
        wxString validationMessage = m_ruleEditorPanel->GetValidationMessage();
 
        DisplayErrorMessage( this, validationMessage );
    }
    else
    {
        RULE_TREE_ITEM_DATA* itemData = dynamic_cast<RULE_TREE_ITEM_DATA*>(
                m_ruleTreeCtrl->GetItemData( GetCurrentlySelectedRuleTreeItemData()->GetTreeItemId() ) );
 
        if( itemData )
        {
            UpdateRuleTypeTreeItemData( itemData );
        }
 
        SaveRulesToFile();
        ClearModified();
 
        SetControlsEnabled( true );
    }
}
 
 
void DIALOG_DRC_RULE_EDITOR::closeRuleEntryView( int aNodeId )
{
    SetControlsEnabled( true );
}
 
 
int DIALOG_DRC_RULE_EDITOR::highlightMatchingItems( int aNodeId )
{
    (void) aNodeId;
 
    if( !m_ruleEditorPanel )
        return -1;
 
    // Ensure we use the latest text from the condition editor
    m_ruleEditorPanel->TransferDataFromWindow();
 
    std::shared_ptr<DRC_RE_BASE_CONSTRAINT_DATA> constraintData = m_ruleEditorPanel->GetConstraintData();
    std::shared_ptr<DRC_RULE>                    selectedRule;
    wxString                                     condition;
    wxString                                     ruleText = constraintData->GetGeneratedRule();
 
    if( ruleText.IsEmpty() )
    {
        m_frame->FocusOnItems( {} );
        Raise();
        return 0;
    }
 
    wxString fullText = wxS( "(version 2)\n" ) + ruleText;
 
    try
    {
        std::vector<std::shared_ptr<DRC_RULE>> rules;
        DRC_RULES_PARSER                       parser( fullText, wxS( "ShowMatches" ) );
        parser.Parse( rules, nullptr );
 
        if( rules.empty() )
        {
            m_frame->FocusOnItems( {} );
            Raise();
            return 0;
        }
 
        selectedRule = rules[0];
        condition = selectedRule->m_Condition ? selectedRule->m_Condition->GetExpression() : wxString();
 
        if( selectedRule->m_Condition && !selectedRule->m_Condition->GetExpression().IsEmpty()
            && !selectedRule->m_Condition->Compile( nullptr ) )
        {
            return -1;
        }
    }
    catch( PARSE_ERROR& )
    {
        return -1;
    }
 
    wxLogTrace( wxS( "KI_TRACE_DRC_RULE_EDITOR" ), wxS( "[ShowMatches] nodeId=%d, condition='%s'" ), aNodeId,
                condition );
 
    m_drcTool = m_frame->GetToolManager()->GetTool<DRC_TOOL>();
 
    std::vector<BOARD_ITEM*> allMatches;
 
    allMatches = m_drcTool->GetDRCEngine()->GetItemsMatchingRule( selectedRule, m_reporter );
 
    // Filter out items without visible geometry
    std::vector<BOARD_ITEM*> matches;
 
    for( BOARD_ITEM* item : allMatches )
    {
        switch( item->Type() )
        {
        case PCB_NETINFO_T:
        case PCB_GENERATOR_T:
        case PCB_GROUP_T:
            continue;
 
        default:
            matches.push_back( item );
            break;
        }
    }
 
    int matchCount = static_cast<int>( matches.size() );
 
    wxLogTrace( wxS( "KI_TRACE_DRC_RULE_EDITOR" ), wxS( "[ShowMatches] matched_count=%d (filtered from %zu)" ),
                matchCount, allMatches.size() );
 
    // Clear any existing selection and select matched items
    m_frame->GetToolManager()->RunAction( ACTIONS::selectionClear );
 
    if( matches.size() > 0 )
    {
        std::vector<EDA_ITEM*> selectItems;
 
        for( BOARD_ITEM* item : matches )
            selectItems.push_back( item );
 
        m_frame->GetToolManager()->RunAction( ACTIONS::selectItems, &selectItems );
        m_frame->GetToolManager()->RunAction( ACTIONS::zoomFitSelection );
    }
 
    // Also brighten items to provide additional visual feedback
    m_frame->FocusOnItems( matches );
    Raise();
 
    return matchCount;
}
 
 
bool DIALOG_DRC_RULE_EDITOR::validateRuleName( int aNodeId, const wxString& aRuleName )
{
    auto it = std::find_if( m_ruleTreeNodeDatas.begin(), m_ruleTreeNodeDatas.end(),
                            [aNodeId, aRuleName]( const RULE_TREE_NODE& node )
                            {
                                return node.m_nodeName == aRuleName && node.m_nodeId != aNodeId
                                       && node.m_nodeType == RULE;
                            } );
 
    if( it != m_ruleTreeNodeDatas.end() )
    {
        return false;
    }
 
    return true;
}
 
 
bool DIALOG_DRC_RULE_EDITOR::deleteTreeNodeData( const int& aNodeId )
{
    size_t initial_size = m_ruleTreeNodeDatas.size();
 
    m_ruleTreeNodeDatas.erase( std::remove_if( m_ruleTreeNodeDatas.begin(), m_ruleTreeNodeDatas.end(),
                                               [aNodeId]( const RULE_TREE_NODE& node )
                                               {
                                                   return node.m_nodeId == aNodeId;
                                               } ),
                               m_ruleTreeNodeDatas.end() );
 
    if( m_ruleTreeNodeDatas.size() < initial_size )
        return true;
    else
        return false;
}
 
 
void DIALOG_DRC_RULE_EDITOR::collectChildRuleNodes( int aParentId, std::vector<RULE_TREE_NODE*>& aResult )
{
    std::vector<RULE_TREE_NODE> children;
    getRuleTreeChildNodes( m_ruleTreeNodeDatas, aParentId, children );
 
    for( const auto& child : children )
    {
        RULE_TREE_NODE* childNode = getRuleTreeNodeInfo( child.m_nodeId );
 
        if( childNode->m_nodeType == RULE )
            aResult.push_back( childNode );
 
        collectChildRuleNodes( childNode->m_nodeId, aResult );
    }
}
 
 
void DIALOG_DRC_RULE_EDITOR::collectModifiedRules( std::vector<RULE_TREE_NODE*>& aResult )
{
    for( RULE_TREE_NODE& node : m_ruleTreeNodeDatas )
    {
        if( node.m_nodeType != RULE )
            continue;
 
        if( node.m_nodeData && node.m_nodeData->IsNew() )
        {
            aResult.push_back( &node );
            continue;
        }
 
        auto constraintData = std::dynamic_pointer_cast<DRC_RE_BASE_CONSTRAINT_DATA>( node.m_nodeData );
 
        if( constraintData && constraintData->WasEdited() )
            aResult.push_back( &node );
    }
}
 
 
bool DIALOG_DRC_RULE_EDITOR::validateAllRules( std::map<wxString, wxString>& aErrors )
{
    bool allValid = true;
 
    // Track (ruleName, layerSource) pairs and their conditions to detect conflicts.
    // Rules with the same name and same layer scope must share the same condition to be
    // merged correctly. Rules with different layer scopes are saved as separate rules and
    // are allowed to have different conditions.
    std::map<std::pair<wxString, wxString>, std::set<wxString>> ruleConditions;
 
    for( RULE_TREE_NODE& node : m_ruleTreeNodeDatas )
    {
        if( node.m_nodeType != RULE )
            continue;
 
        if( node.m_nodeData && node.m_nodeData->IsNew() )
            continue;
 
        auto constraintData = std::dynamic_pointer_cast<DRC_RE_BASE_CONSTRAINT_DATA>( node.m_nodeData );
 
        if( constraintData )
        {
            // Individual constraint validation
            VALIDATION_RESULT result = constraintData->Validate();
 
            if( !result.isValid )
            {
                wxString errorMsg;
 
                for( const wxString& err : result.errors )
                {
                    if( !errorMsg.IsEmpty() )
                        errorMsg += wxS( "\n" );
 
                    errorMsg += err;
                }
 
                aErrors[node.m_nodeName] = errorMsg;
                allValid = false;
            }
 
            wxString ruleName = constraintData->GetRuleName();
            wxString condition = constraintData->GetRuleCondition();
            wxString layerSource = constraintData->GetLayerSource();
            ruleConditions[std::make_pair( ruleName, layerSource )].insert( condition );
        }
    }
 
    // Check for same-name same-layer different-condition conflicts
    for( const auto& [key, conditions] : ruleConditions )
    {
        if( conditions.size() > 1 )
        {
            wxString errorMsg = _( "Multiple rules with the same name have different conditions. "
                                   "Rules with the same name must have identical conditions to be merged." );
            aErrors[key.first] = errorMsg;
            allValid = false;
        }
    }
 
    return allValid;
}
 
 
int DIALOG_DRC_RULE_EDITOR::promptUnsavedChanges()
{
    std::vector<RULE_TREE_NODE*> modifiedRules;
    collectModifiedRules( modifiedRules );
 
    if( modifiedRules.empty() )
        return wxID_NO;
 
    wxString message = _( "The following rules have unsaved changes:\n\n" );
 
    for( RULE_TREE_NODE* rule : modifiedRules )
        message += wxString::Format( wxS( "  \u2022 %s\n" ), rule->m_nodeName );
 
    message += _( "\nDo you want to save your changes?" );
 
    int result = wxMessageBox( message, _( "Save Changes?" ),
                               wxYES_NO | wxCANCEL | wxICON_QUESTION, this );
 
    if( result == wxYES )
        return wxID_YES;
    else if( result == wxNO )
        return wxID_NO;
    else
        return wxID_CANCEL;
}
 
 
void DIALOG_DRC_RULE_EDITOR::selectRuleNode( int aNodeId )
{
    // Find the tree item ID for this node
    wxTreeItemIdValue cookie;
    wxTreeItemId root = m_ruleTreeCtrl->GetRootItem();
 
    std::function<wxTreeItemId( wxTreeItemId )> findItem =
            [&]( wxTreeItemId parent ) -> wxTreeItemId
            {
                wxTreeItemId item = m_ruleTreeCtrl->GetFirstChild( parent, cookie );
 
                while( item.IsOk() )
                {
                    RULE_TREE_ITEM_DATA* data =
                            dynamic_cast<RULE_TREE_ITEM_DATA*>( m_ruleTreeCtrl->GetItemData( item ) );
 
                    if( data && data->GetNodeId() == aNodeId )
                        return item;
 
                    wxTreeItemId found = findItem( item );
 
                    if( found.IsOk() )
                        return found;
 
                    item = m_ruleTreeCtrl->GetNextSibling( item );
                }
 
                return wxTreeItemId();
            };
 
    wxTreeItemId itemId = findItem( root );
 
    if( itemId.IsOk() )
        m_ruleTreeCtrl->SelectItem( itemId );
}
 
 
RULE_TREE_NODE DIALOG_DRC_RULE_EDITOR::buildRuleTreeNodeData(
        const wxString& aName, const DRC_RULE_EDITOR_ITEM_TYPE& aNodeType, const std::optional<int>& aParentId,
        const std::optional<DRC_RULE_EDITOR_CONSTRAINT_NAME>& aConstraintType,
        const std::vector<RULE_TREE_NODE>& aChildNodes, const std::optional<int>& id )
{
    unsigned int newId;
 
    if( id )
    {
        newId = *id; // Use provided ID
    }
    else
    {
        newId = 1;
 
        if( m_nodeId )
            newId = m_nodeId + 1;
    }
 
    m_nodeId = newId;
 
    RULE_EDITOR_DATA_BASE baseData;
    baseData.SetId( newId );
 
    if( aParentId )
    {
        baseData.SetParentId( *aParentId );
    }
 
    return { .m_nodeId = m_nodeId,
             .m_nodeName = aName,
             .m_nodeType = aNodeType,
             .m_nodeLevel = -1,
             .m_nodeTypeMap = aConstraintType,
             .m_childNodes = aChildNodes,
             .m_nodeData = std::make_shared<RULE_EDITOR_DATA_BASE>( baseData ) };
}
 
 
RULE_TREE_NODE DIALOG_DRC_RULE_EDITOR::buildRuleNodeFromKicadDrc( const wxString& aName, const wxString& aCode,
                                                                  const std::optional<int>& aParentId )
{
    auto           typeOpt = DRC_RULE_EDITOR_UTILS::GetConstraintTypeFromCode( aCode );
    RULE_TREE_NODE node =
            buildRuleTreeNodeData( aName, DRC_RULE_EDITOR_ITEM_TYPE::CONSTRAINT, aParentId, typeOpt );
 
    auto baseData = std::dynamic_pointer_cast<DRC_RE_BASE_CONSTRAINT_DATA>( node.m_nodeData );
    DRC_RULE_EDITOR_UTILS::ConstraintFromKicadDrc( aCode, baseData.get() );
    node.m_nodeData = baseData;
    return node;
}
 
 
bool DIALOG_DRC_RULE_EDITOR::updateUI()
{
    return !m_cancelled;
}
 
 
void DIALOG_DRC_RULE_EDITOR::AdvancePhase( const wxString& aMessage )
{
    PROGRESS_REPORTER_BASE::AdvancePhase( aMessage );
    SetCurrentProgress( 0.0 );
}
 
 
void DIALOG_DRC_RULE_EDITOR::UpdateData()
{
    m_markersTreeModel->Update( m_markersProvider, m_severities );
}
 
void DIALOG_DRC_RULE_EDITOR::SaveRulesToFile()
{
    std::vector<DRC_RE_LOADED_PANEL_ENTRY> entries;
 
    for( const RULE_TREE_NODE& node : m_ruleTreeNodeDatas )
    {
        if( node.m_nodeType != RULE )
            continue;
 
        auto data = std::dynamic_pointer_cast<DRC_RE_BASE_CONSTRAINT_DATA>( node.m_nodeData );
 
        if( !data )
            continue;
 
        if( node.m_nodeData->IsNew() )
            continue;
 
        DRC_RE_LOADED_PANEL_ENTRY entry;
 
        if( node.m_nodeTypeMap )
            entry.panelType = static_cast<DRC_RULE_EDITOR_CONSTRAINT_NAME>( *node.m_nodeTypeMap );
        else
            entry.panelType = CUSTOM_RULE;
 
        entry.constraintData = data;
        entry.ruleName = data->GetRuleName();
        entry.condition = data->GetRuleCondition();
        entry.originalRuleText = data->GetOriginalRuleText();
        entry.wasEdited = data->WasEdited();
        entry.severity = data->GetSeverity();
        entry.layerCondition = LSET( data->GetLayers() );
        entry.layerSource = data->GetLayerSource();
 
        entries.push_back( entry );
    }
 
    DRC_RULE_SAVER saver;
    saver.SaveFile( m_frame->GetBoard()->GetDesignRulesPath(), entries, m_currentBoard );
 
    try
    {
        m_frame->GetBoard()->GetDesignSettings().m_DRCEngine->InitEngine( m_frame->GetBoard()->GetDesignRulesPath() );
    }
    catch( PARSE_ERROR& pe )
    {
        wxLogError( _( "Failed to reload DRC rules: %s" ), pe.What() );
    }
}