test_issue22620_group_annotation.cpp

Go to the documentation of this file.

/*
 * This program source code file is part of KiCad, a free EDA CAD application.
 *
 * Copyright The KiCad Developers, see AUTHORS.txt for contributors.
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

 
#include <boost/test/unit_test.hpp>
 
#include <lib_symbol.h>
#include <refdes_tracker.h>
#include <sch_group.h>
#include <sch_reference_list.h>
#include <sch_screen.h>
#include <sch_sheet_path.h>
#include <sch_symbol.h>
#include <schematic.h>
#include <settings/settings_manager.h>
#include <tools/sch_selection.h>
 
#include <qa_utils/wx_utils/unit_test_utils.h>
 
#include <wx/filename.h>
#include <wx/stdpaths.h>
 
 
struct GROUP_ANNOTATION_FIXTURE
{
    GROUP_ANNOTATION_FIXTURE() :
            m_settingsManager()
    {
        wxString tempDir = wxStandardPaths::Get().GetTempDir();
        wxString projectPath = tempDir + wxFileName::GetPathSeparator()
                               + wxT( "test_group_annotation.kicad_pro" );
        m_tempFiles.push_back( projectPath );
 
        m_settingsManager.LoadProject( projectPath.ToStdString() );
        m_schematic = std::make_unique<SCHEMATIC>( nullptr );
        m_project = &m_settingsManager.Prj();
        m_schematic->SetProject( m_project );
    }
 
    ~GROUP_ANNOTATION_FIXTURE()
    {
        for( const wxString& file : m_tempFiles )
        {
            if( wxFileExists( file ) )
                wxRemoveFile( file );
        }
 
        m_schematic.reset();
    }
 
    SETTINGS_MANAGER m_settingsManager;
    std::unique_ptr<SCHEMATIC> m_schematic;
    PROJECT* m_project;
    std::vector<wxString> m_tempFiles;
};
 
 
std::unordered_set<SCH_SYMBOL*> getInferredSymbols( const SCH_SELECTION& aSelection );
 
 
BOOST_FIXTURE_TEST_SUITE( Issue22620GroupAnnotation, GROUP_ANNOTATION_FIXTURE )
 
 

BOOST_AUTO_TEST_CASE( TestGroupRunOnChildrenFindsSymbols )
{
    m_schematic->CreateDefaultScreens();
 
    std::vector<SCH_SHEET*> topSheets = m_schematic->GetTopLevelSheets();
    BOOST_REQUIRE( !topSheets.empty() );
 
    SCH_SCREEN* screen = topSheets[0]->GetScreen();
    BOOST_REQUIRE( screen != nullptr );
 
    // Create two simple symbols
    SCH_SYMBOL* symbol1 = new SCH_SYMBOL();
    symbol1->SetPosition( VECTOR2I( 0, 0 ) );
    screen->Append( symbol1 );
 
    SCH_SYMBOL* symbol2 = new SCH_SYMBOL();
    symbol2->SetPosition( VECTOR2I( 1000000, 0 ) );
    screen->Append( symbol2 );
 
    // Create a group containing both symbols
    SCH_GROUP* group = new SCH_GROUP( screen );
    group->SetName( wxT( "DesignBlock" ) );
    group->AddItem( symbol1 );
    group->AddItem( symbol2 );
    screen->Append( group );
 
    // Use RunOnChildren to find symbols in the group
    std::unordered_set<SCH_SYMBOL*> foundSymbols;
 
    group->RunOnChildren(
            [&foundSymbols]( SCH_ITEM* aChild )
            {
                if( aChild->Type() == SCH_SYMBOL_T )
                    foundSymbols.insert( static_cast<SCH_SYMBOL*>( aChild ) );
            },
            RECURSE_MODE::RECURSE );
 
    // Verify both symbols were found
    BOOST_CHECK_EQUAL( foundSymbols.size(), 2 );
    BOOST_CHECK( foundSymbols.count( symbol1 ) == 1 );
    BOOST_CHECK( foundSymbols.count( symbol2 ) == 1 );
 
    BOOST_TEST_MESSAGE( "Test passed: RunOnChildren correctly finds symbols in groups" );
}
 

BOOST_AUTO_TEST_CASE( TestGroupRunOnChildrenWithNestedGroups )
{
    m_schematic->CreateDefaultScreens();
 
    std::vector<SCH_SHEET*> topSheets = m_schematic->GetTopLevelSheets();
    BOOST_REQUIRE( !topSheets.empty() );
 
    SCH_SCREEN* screen = topSheets[0]->GetScreen();
    BOOST_REQUIRE( screen != nullptr );
 
    // Create symbols
    SCH_SYMBOL* symbol1 = new SCH_SYMBOL();
    symbol1->SetPosition( VECTOR2I( 0, 0 ) );
    screen->Append( symbol1 );
 
    SCH_SYMBOL* symbol2 = new SCH_SYMBOL();
    symbol2->SetPosition( VECTOR2I( 1000000, 0 ) );
    screen->Append( symbol2 );
 
    SCH_SYMBOL* symbol3 = new SCH_SYMBOL();
    symbol3->SetPosition( VECTOR2I( 2000000, 0 ) );
    screen->Append( symbol3 );
 
    // Create an inner group with symbol1
    SCH_GROUP* innerGroup = new SCH_GROUP( screen );
    innerGroup->SetName( wxT( "InnerGroup" ) );
    innerGroup->AddItem( symbol1 );
    screen->Append( innerGroup );
 
    // Create an outer group containing the inner group and symbol2
    SCH_GROUP* outerGroup = new SCH_GROUP( screen );
    outerGroup->SetName( wxT( "OuterGroup" ) );
    outerGroup->AddItem( innerGroup );
    outerGroup->AddItem( symbol2 );
    screen->Append( outerGroup );
 
    // Use RunOnChildren with RECURSE to find all symbols in nested groups
    std::unordered_set<SCH_SYMBOL*> foundSymbols;
 
    outerGroup->RunOnChildren(
            [&foundSymbols]( SCH_ITEM* aChild )
            {
                if( aChild->Type() == SCH_SYMBOL_T )
                    foundSymbols.insert( static_cast<SCH_SYMBOL*>( aChild ) );
            },
            RECURSE_MODE::RECURSE );
 
    // Verify both symbol1 (in nested group) and symbol2 were found
    BOOST_CHECK_EQUAL( foundSymbols.size(), 2 );
    BOOST_CHECK( foundSymbols.count( symbol1 ) == 1 );
    BOOST_CHECK( foundSymbols.count( symbol2 ) == 1 );
    BOOST_CHECK( foundSymbols.count( symbol3 ) == 0 ); // symbol3 is not in any group
 
    BOOST_TEST_MESSAGE( "Test passed: RunOnChildren correctly handles nested groups" );
}
 

BOOST_AUTO_TEST_CASE( Issue23519_GroupSelectionReannotatesPowerSymbols )
{
    m_schematic->CreateDefaultScreens();
    m_schematic->Settings().m_refDesTracker = std::make_shared<REFDES_TRACKER>( false );
 
    std::vector<SCH_SHEET*> topSheets = m_schematic->GetTopLevelSheets();
    BOOST_REQUIRE( !topSheets.empty() );
 
    SCH_SHEET*  rootSheet = topSheets[0];
    SCH_SCREEN* screen = rootSheet->GetScreen();
    BOOST_REQUIRE( screen != nullptr );
 
    SCH_SHEET_PATH sheetPath;
    sheetPath.push_back( rootSheet );
 
    LIB_SYMBOL powerLib( wxT( "PWR" ), nullptr );
    powerLib.SetGlobalPower();
 
    SCH_SYMBOL* existingPowerSymbol =
            new SCH_SYMBOL( powerLib, powerLib.GetLibId(), &sheetPath, 0, 0, VECTOR2I( -1000000, 0 ) );
    existingPowerSymbol->SetRef( &sheetPath, wxT( "#PWR01" ) );
    existingPowerSymbol->SetValueFieldText( wxT( "+3V3" ), &sheetPath );
    screen->Append( existingPowerSymbol );
 
    LIB_SYMBOL  normalLib( wxT( "R" ), nullptr );
    SCH_SYMBOL* normalSymbol = new SCH_SYMBOL( normalLib, normalLib.GetLibId(), &sheetPath, 0, 0, VECTOR2I( 0, 0 ) );
    normalSymbol->SetRef( &sheetPath, wxT( "R123" ) );
    normalSymbol->SetValueFieldText( wxT( "10k" ), &sheetPath );
    screen->Append( normalSymbol );
 
    SCH_SYMBOL* powerSymbol = new SCH_SYMBOL( powerLib, powerLib.GetLibId(), &sheetPath, 0, 0, VECTOR2I( 1000000, 0 ) );
    powerSymbol->SetRef( &sheetPath, wxT( "#PWR01" ) );
    powerSymbol->SetValueFieldText( wxT( "+5V" ), &sheetPath );
    screen->Append( powerSymbol );
 
    SCH_GROUP* group = new SCH_GROUP( screen );
    group->SetName( wxT( "DesignBlock" ) );
    group->AddItem( normalSymbol );
    group->AddItem( powerSymbol );
    screen->Append( group );
 
    SCH_SELECTION selection( screen );
    selection.Add( group );
 
    std::unordered_set<SCH_SYMBOL*> selectedSymbols = getInferredSymbols( selection );
 
    BOOST_REQUIRE_EQUAL( selectedSymbols.size(), 2 );
 
    SCH_REFERENCE_LIST           references;
    SCH_REFERENCE_LIST           allReferences;
    SCH_MULTI_UNIT_REFERENCE_MAP lockedSymbols;
 
    // Mirror the design-block placement flow when normal symbol annotation is skipped:
    // only the power-only selection pass runs.
    for( SCH_SYMBOL* symbol : selectedSymbols )
        sheetPath.AppendSymbol( references, symbol, SYMBOL_FILTER_POWER, true );
 
    SCH_REFERENCE_LIST additionalRefs;
 
    sheetPath.GetSymbols( allReferences, SYMBOL_FILTER_ALL );
 
    for( unsigned i = 0; i < allReferences.GetCount(); ++i )
    {
        if( !references.Contains( allReferences[i] ) )
            additionalRefs.AddItem( allReferences[i] );
    }
 
    references.RemoveAnnotation();
    references.SetRefDesTracker( m_schematic->Settings().m_refDesTracker );
    references.SplitReferences();
    references.Annotate( false, 0, 0, lockedSymbols, additionalRefs );
    references.UpdateAnnotation();
 
    BOOST_CHECK_EQUAL( references.GetCount(), 1u );
    BOOST_CHECK_EQUAL( normalSymbol->GetRef( &sheetPath ), wxT( "R123" ) );
    BOOST_CHECK_EQUAL( existingPowerSymbol->GetRef( &sheetPath ), wxT( "#PWR01" ) );
    BOOST_CHECK_EQUAL( powerSymbol->GetRef( &sheetPath ), wxT( "#PWR02" ) );
}
 
 
BOOST_AUTO_TEST_SUITE_END()