KiCad PCB EDA Suite
Loading...
Searching...
No Matches
erc_settings.cpp
Go to the documentation of this file.
1/*
2 * This program source code file is part of KiCad, a free EDA CAD application.
3 *
4 * Copyright (C) 2024 CERN
5 * Copyright The KiCad Developers, see AUTHORS.txt for contributors.
6 * @author Jon Evans <[email protected]>
7 *
8 * This program is free software: you can redistribute it and/or modify it
9 * under the terms of the GNU General Public License as published by the
10 * Free Software Foundation, either version 3 of the License, or (at your
11 * option) any later version.
12 *
13 * This program is distributed in the hope that it will be useful, but
14 * WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16 * General Public License for more details.
17 *
18 * You should have received a copy of the GNU General Public License along
19 * with this program. If not, see <http://www.gnu.org/licenses/>.
20 */
21
22#include <erc/erc_item.h>
23#include <erc/erc_settings.h>
24#include <schematic.h>
25#include <sch_marker.h>
26#include <sch_screen.h>
28#include <settings/parameters.h>
29
30
32
33
34
35#define OK PIN_ERROR::OK
36#define ERR PIN_ERROR::PP_ERROR
37#define WAR PIN_ERROR::WARNING
38
43{
44/* I, O, Bi, 3S, Pas, NIC, UnS, PwrI, PwrO, OC, OE, NC */
45/* I */ { OK, OK, OK, OK, OK, OK, WAR, OK, OK, OK, OK, ERR },
46/* O */ { OK, ERR, OK, WAR, OK, OK, WAR, OK, ERR, ERR, ERR, ERR },
47/* Bi */ { OK, OK, OK, OK, OK, OK, WAR, OK, WAR, OK, WAR, ERR },
48/* 3S */ { OK, WAR, OK, OK, OK, OK, WAR, WAR, ERR, WAR, WAR, ERR },
49/*Pas */ { OK, OK, OK, OK, OK, OK, WAR, OK, OK, OK, OK, ERR },
50/*NIC */ { OK, OK, OK, OK, OK, OK, OK, OK, OK, OK, OK, ERR },
51/*UnS */ { WAR, WAR, WAR, WAR, WAR, OK, WAR, WAR, WAR, WAR, WAR, ERR },
52/*PwrI*/ { OK, OK, OK, WAR, OK, OK, WAR, OK, OK, OK, OK, ERR },
53/*PwrO*/ { OK, ERR, WAR, ERR, OK, OK, WAR, OK, ERR, ERR, ERR, ERR },
54/* OC */ { OK, ERR, OK, WAR, OK, OK, WAR, OK, ERR, OK, OK, ERR },
55/* OE */ { OK, ERR, WAR, WAR, OK, OK, WAR, OK, ERR, OK, OK, ERR },
56/* NC */ { ERR, ERR, ERR, ERR, ERR, ERR, ERR, ERR, ERR, ERR, ERR, ERR }
57};
58
59
71{
72/* I, O, Bi, 3S, Pas, NIC, UnS, PwrI, PwrO, OC, OE, NC */
73/* I */ { NOD, DRV, DRV, DRV, DRV, NOD, DRV, NOD, DRV, DRV, DRV, NPI },
74/* O */ { DRV, DRV, DRV, DRV, DRV, NOD, DRV, DRV, DRV, DRV, DRV, NPI },
75/* Bi */ { DRV, DRV, DRV, DRV, DRV, NOD, DRV, NOD, DRV, DRV, DRV, NPI },
76/* 3S */ { DRV, DRV, DRV, DRV, DRV, NOD, DRV, NOD, DRV, DRV, DRV, NPI },
77/*Pas */ { DRV, DRV, DRV, DRV, DRV, NOD, DRV, NOD, DRV, DRV, DRV, NPI },
78/*NIC */ { NOD, NOD, NOD, NOD, NOD, NOD, NOD, NOD, NOD, NOD, NOD, NPI },
79/*UnS */ { DRV, DRV, DRV, DRV, DRV, NOD, DRV, NOD, DRV, DRV, DRV, NPI },
80/*PwrI*/ { NOD, DRV, NOD, NOD, NOD, NOD, NOD, NOD, DRV, NOD, NOD, NPI },
81/*PwrO*/ { DRV, DRV, DRV, DRV, DRV, NOD, DRV, DRV, DRV, DRV, DRV, NPI },
82/* OC */ { DRV, DRV, DRV, DRV, DRV, NOD, DRV, NOD, DRV, DRV, DRV, NPI },
83/* OE */ { DRV, DRV, DRV, DRV, DRV, NOD, DRV, NOD, DRV, DRV, DRV, NPI },
84/* NC */ { NPI, NPI, NPI, NPI, NPI, NPI, NPI, NPI, NPI, NPI, NPI, NPI }
85};
86
87
88ERC_SETTINGS::ERC_SETTINGS( JSON_SETTINGS* aParent, const std::string& aPath ) :
89 NESTED_SETTINGS( "erc", ercSettingsSchemaVersion, aParent, aPath )
90{
92
93 for( int i = ERCE_FIRST; i <= ERCE_LAST; ++i )
95
96 // Error is the default setting so set non-error priorities here.
121
122 m_params.emplace_back( new PARAM_LAMBDA<nlohmann::json>( "rule_severities",
123 [&]() -> nlohmann::json
124 {
125 nlohmann::json ret = {};
126
127 for( const RC_ITEM& item : ERC_ITEM::GetItemsWithSeverities() )
128 {
129 wxString name = item.GetSettingsKey();
130 int code = item.GetErrorCode();
131
132 if( name.IsEmpty() || m_ERCSeverities.count( code ) == 0 )
133 continue;
134
135 ret[std::string( name.ToUTF8() )] = SeverityToString( m_ERCSeverities[code] );
136 }
137
138 return ret;
139 },
140 [&]( const nlohmann::json& aJson )
141 {
142 if( !aJson.is_object() )
143 return;
144
145 for( const RC_ITEM& item : ERC_ITEM::GetItemsWithSeverities() )
146 {
147 int code = item.GetErrorCode();
148 wxString name = item.GetSettingsKey();
149
150 std::string key( name.ToUTF8() );
151
152 if( aJson.contains( key ) )
153 m_ERCSeverities[code] = SeverityFromString( aJson[key] );
154 }
155 },
156 {} ) );
157
158 m_params.emplace_back( new PARAM_LAMBDA<nlohmann::json>( "erc_exclusions",
159 [&]() -> nlohmann::json
160 {
161 nlohmann::json js = nlohmann::json::array();
162
163 for( const wxString& entry : m_ErcExclusions )
164 js.push_back( { entry, m_ErcExclusionComments[ entry ] } );
165
166 return js;
167 },
168 [&]( const nlohmann::json& aObj )
169 {
170 m_ErcExclusions.clear();
171
172 if( !aObj.is_array() )
173 return;
174
175 for( const nlohmann::json& entry : aObj )
176 {
177 if( entry.is_array() )
178 {
179 wxString serialized = entry[0].get<wxString>();
180 m_ErcExclusions.insert( serialized );
181 m_ErcExclusionComments[ serialized ] = entry[1].get<wxString>();
182 }
183 else if( entry.is_string() )
184 {
185 m_ErcExclusions.insert( entry.get<wxString>() );
186 }
187 }
188 },
189 {} ) );
190
191 m_params.emplace_back( new PARAM_LAMBDA<nlohmann::json>( "pin_map",
192 [&]() -> nlohmann::json
193 {
194 nlohmann::json ret = nlohmann::json::array();
195
196 for( int i = 0; i < ELECTRICAL_PINTYPES_TOTAL; i++ )
197 {
198 nlohmann::json inner = nlohmann::json::array();
199
200 for( int j = 0; j < ELECTRICAL_PINTYPES_TOTAL; j++ )
201 inner.push_back( static_cast<int>( GetPinMapValue( i, j ) ) );
202
203 ret.push_back( inner );
204 }
205
206 return ret;
207 },
208 [&]( const nlohmann::json& aJson )
209 {
210 if( !aJson.is_array() || aJson.size() != ELECTRICAL_PINTYPES_TOTAL )
211 return;
212
213 for( size_t i = 0; i < ELECTRICAL_PINTYPES_TOTAL; i++ )
214 {
215 if( i > aJson.size() - 1 )
216 break;
217
218 nlohmann::json inner = aJson[i];
219
220 if( !inner.is_array() || inner.size() != ELECTRICAL_PINTYPES_TOTAL )
221 return;
222
223 for( size_t j = 0; j < ELECTRICAL_PINTYPES_TOTAL; j++ )
224 {
225 if( inner[j].is_number_integer() )
226 {
227 int val = inner[j].get<int>();
228
229 if( val >= 0 && val <= static_cast<int>( PIN_ERROR::UNCONNECTED ) )
230 SetPinMapValue( i, j, static_cast<PIN_ERROR>( val ) );
231 }
232 }
233 }
234 },
235 {} ) );
236
237 // Pin weights used for sorting. Take care, sorting is descending!
238 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_NIC, 11 );
239 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_UNSPECIFIED, 10 );
240 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_PASSIVE, 9 );
241 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_OPENCOLLECTOR, 8 );
242 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_OPENEMITTER, 7 );
243 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_INPUT, 6 );
244 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_TRISTATE, 5 );
245 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_BIDI, 4 );
246 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_OUTPUT, 3 );
247 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_POWER_IN, 2 );
248 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_POWER_OUT, 1 );
249 m_PinTypeWeights.emplace( ELECTRICAL_PINTYPE::PT_NC, 0 );
250
251 m_ERCSortingMetric = ERC_PIN_SORTING_METRIC::SM_HEURISTICS;
252}
253
254
256{
257 if( m_parent )
258 {
260 m_parent = nullptr;
261 }
262}
263
264
265SEVERITY ERC_SETTINGS::GetSeverity( int aErrorCode ) const
266{
267 // Special-case duplicate pin error. Unique pin names are required by KiCad, so this
268 // is always an error.
269 if( aErrorCode == ERCE_DUPLICATE_PIN_ERROR )
270 {
271 return RPT_SEVERITY_ERROR;
272 }
273 // Special-case pin-to-pin errors:
274 // Ignore-or-not is controlled by ERCE_PIN_TO_PIN_WARNING (for both)
275 // Warning-or-error is controlled by which errorCode it is
276 else if( aErrorCode == ERCE_PIN_TO_PIN_ERROR )
277 {
278 wxASSERT( m_ERCSeverities.count( ERCE_PIN_TO_PIN_WARNING ) );
279
281 return RPT_SEVERITY_IGNORE;
282 else
283 return RPT_SEVERITY_ERROR;
284 }
285 else if( aErrorCode == ERCE_PIN_TO_PIN_WARNING )
286 {
287 wxASSERT( m_ERCSeverities.count( ERCE_PIN_TO_PIN_WARNING ) );
288
290 return RPT_SEVERITY_IGNORE;
291 else
293 }
294 else if( aErrorCode == ERCE_GENERIC_WARNING )
295 {
297 }
298 else if( aErrorCode == ERCE_GENERIC_ERROR )
299 {
300 return RPT_SEVERITY_ERROR;
301 }
302
303 wxCHECK_MSG( m_ERCSeverities.count( aErrorCode ), RPT_SEVERITY_IGNORE,
304 wxS( "Missing severity from map in ERC_SETTINGS!" ) );
305
306 return m_ERCSeverities.at( aErrorCode );
307}
308
309
310void ERC_SETTINGS::SetSeverity( int aErrorCode, SEVERITY aSeverity )
311{
312 m_ERCSeverities[ aErrorCode ] = aSeverity;
313}
314
315
317{
318 memcpy( m_PinMap, m_defaultPinMap, sizeof( m_PinMap ) );
319}
320
321
322void SHEETLIST_ERC_ITEMS_PROVIDER::visitMarkers( std::function<void( SCH_MARKER* )> aVisitor ) const
323{
324 std::set<SCH_SCREEN*> seenScreens;
325
326 for( const SCH_SHEET_PATH& sheet : m_schematic->BuildUnorderedSheetList() )
327 {
328 bool firstTime = seenScreens.count( sheet.LastScreen() ) == 0;
329
330 if( firstTime )
331 seenScreens.insert( sheet.LastScreen() );
332
333 for( SCH_ITEM* item : sheet.LastScreen()->Items().OfType( SCH_MARKER_T ) )
334 {
335 SCH_MARKER* marker = static_cast<SCH_MARKER*>( item );
336
337 if( marker->GetMarkerType() != MARKER_BASE::MARKER_ERC )
338 continue;
339
340 std::shared_ptr<const ERC_ITEM> ercItem =
341 std::static_pointer_cast<const ERC_ITEM>( marker->GetRCItem() );
342
343 // Only show sheet-specific markers on the owning sheet
344 if( ercItem->IsSheetSpecific() )
345 {
346 if( ercItem->GetSpecificSheetPath() != sheet )
347 continue;
348 }
349
350 // Don't show non-specific markers more than once
351 if( !firstTime && !ercItem->IsSheetSpecific() )
352 continue;
353
354 aVisitor( marker );
355 }
356 }
357}
358
359
361{
362 m_severities = aSeverities;
363
364 m_filteredMarkers.clear();
365
366 ERC_SETTINGS& settings = m_schematic->ErcSettings();
367
369 [&]( SCH_MARKER* aMarker )
370 {
371 SEVERITY markerSeverity;
372
373 if( aMarker->IsExcluded() )
374 markerSeverity = RPT_SEVERITY_EXCLUSION;
375 else
376 markerSeverity = settings.GetSeverity( aMarker->GetRCItem()->GetErrorCode() );
377
378 if( markerSeverity & m_severities )
379 m_filteredMarkers.push_back( aMarker );
380 } );
381}
382
383
385{
386 if( aSeverity < 0 )
387 return m_filteredMarkers.size();
388
389 int count = 0;
390
391 const ERC_SETTINGS& settings = m_schematic->ErcSettings();
392
394 [&]( SCH_MARKER* aMarker )
395 {
396 SEVERITY markerSeverity;
397
398 if( aMarker->IsExcluded() )
399 markerSeverity = RPT_SEVERITY_EXCLUSION;
400 else
401 markerSeverity = settings.GetSeverity( aMarker->GetRCItem()->GetErrorCode() );
402
403 if( ( markerSeverity & aSeverity ) > 0 )
404 count++;
405 } );
406
407 return count;
408}
409
410
411std::shared_ptr<ERC_ITEM> SHEETLIST_ERC_ITEMS_PROVIDER::GetERCItem( int aIndex ) const
412{
413 SCH_MARKER* marker = m_filteredMarkers[ aIndex ];
414
415 return marker ? std::static_pointer_cast<ERC_ITEM>( marker->GetRCItem() ) : nullptr;
416}
417
418
419std::shared_ptr<RC_ITEM> SHEETLIST_ERC_ITEMS_PROVIDER::GetItem( int aIndex ) const
420{
421 return GetERCItem( aIndex );
422}
423
424
425void SHEETLIST_ERC_ITEMS_PROVIDER::DeleteItem( int aIndex, bool aDeep )
426{
427 SCH_MARKER* marker = m_filteredMarkers[ aIndex ];
428 m_filteredMarkers.erase( m_filteredMarkers.begin() + aIndex );
429
430 if( aDeep )
431 {
432 SCH_SCREENS screens( m_schematic->Root() );
433 screens.DeleteMarker( marker );
434 }
435}
436
437
const char * name
Definition: DXF_plotter.cpp:59
static std::vector< std::reference_wrapper< RC_ITEM > > GetItemsWithSeverities()
Definition: erc_item.h:76
Container for ERC settings.
Definition: erc_settings.h:135
ERC_PIN_SORTING_METRIC m_ERCSortingMetric
The type of sorting used by the ERC checker to resolve multi-pin errors.
Definition: erc_settings.h:235
std::map< wxString, wxString > m_ErcExclusionComments
Definition: erc_settings.h:214
std::map< ELECTRICAL_PINTYPE, int > m_PinTypeWeights
Weights for electrical pins used in ERC to decide which pin gets the marker in case of a multi-pin er...
Definition: erc_settings.h:229
static PIN_ERROR m_defaultPinMap[ELECTRICAL_PINTYPES_TOTAL][ELECTRICAL_PINTYPES_TOTAL]
Default Look up table which gives the ERC error level for a pair of connected pins.
Definition: erc_settings.h:222
SEVERITY GetSeverity(int aErrorCode) const
ERC_SETTINGS(JSON_SETTINGS *aParent, const std::string &aPath)
void ResetPinMap()
void SetSeverity(int aErrorCode, SEVERITY aSeverity)
virtual ~ERC_SETTINGS()
PIN_ERROR GetPinMapValue(int aFirstType, int aSecondType) const
Definition: erc_settings.h:180
std::map< int, SEVERITY > m_ERCSeverities
Definition: erc_settings.h:212
std::set< wxString > m_ErcExclusions
Definition: erc_settings.h:213
static int m_PinMinDrive[ELECTRICAL_PINTYPES_TOTAL][ELECTRICAL_PINTYPES_TOTAL]
Look up table which gives the minimal drive for a pair of connected pins on a net.
Definition: erc_settings.h:218
void SetPinMapValue(int aFirstType, int aSecondType, PIN_ERROR aValue)
Definition: erc_settings.h:192
PIN_ERROR m_PinMap[ELECTRICAL_PINTYPES_TOTAL][ELECTRICAL_PINTYPES_TOTAL]
Definition: erc_settings.h:216
std::vector< PARAM_BASE * > m_params
The list of parameters (owned by this object)
void ReleaseNestedSettings(NESTED_SETTINGS *aSettings)
Saves and frees a nested settings object, if it exists within this one.
bool IsExcluded() const
Definition: marker_base.h:98
std::shared_ptr< RC_ITEM > GetRCItem() const
Definition: marker_base.h:112
enum MARKER_T GetMarkerType() const
Definition: marker_base.h:96
NESTED_SETTINGS is a JSON_SETTINGS that lives inside a JSON_SETTINGS.
JSON_SETTINGS * m_parent
A pointer to the parent object to load and store from.
Like a normal param, but with custom getter and setter functions.
Definition: parameters.h:295
A holder for a rule check item, DRC in Pcbnew or ERC in Eeschema.
Definition: rc_item.h:79
SCH_SHEET_LIST BuildUnorderedSheetList() const
Definition: schematic.h:111
SCH_SHEET & Root() const
Definition: schematic.h:130
ERC_SETTINGS & ErcSettings() const
Definition: schematic.cpp:319
Base class for any item which can be embedded within the SCHEMATIC container class,...
Definition: sch_item.h:167
Container class that holds multiple SCH_SCREEN objects in a hierarchy.
Definition: sch_screen.h:712
void DeleteMarker(SCH_MARKER *aMarker)
Delete a specific marker.
Handle access to a stack of flattened SCH_SHEET objects by way of a path for creating a flattened sch...
int GetCount(int aSeverity=-1) const override
void SetSeverities(int aSeverities) override
void visitMarkers(std::function< void(SCH_MARKER *)> aVisitor) const
void DeleteItem(int aIndex, bool aDeep) override
Remove (and optionally deletes) the indexed item from the list.
std::shared_ptr< ERC_ITEM > GetERCItem(int aIndex) const
std::vector< SCH_MARKER * > m_filteredMarkers
Definition: erc_settings.h:248
std::shared_ptr< RC_ITEM > GetItem(int aIndex) const override
Retrieve a RC_ITEM by index.
const int ercSettingsSchemaVersion
#define ERR
#define WAR
#define OK
#define DRV
Definition: erc_settings.h:123
@ ERCE_UNSPECIFIED
Definition: erc_settings.h:38
@ ERCE_DRIVER_CONFLICT
Conflicting drivers (labels, etc) on a subgraph.
Definition: erc_settings.h:66
@ ERCE_SIMILAR_POWER
2 power pins are equal for case insensitive comparisons.
Definition: erc_settings.h:52
@ ERCE_UNCONNECTED_WIRE_ENDPOINT
A label is connected to more than one wire.
Definition: erc_settings.h:89
@ ERCE_SIMILAR_LABELS
2 labels are equal for case insensitive comparisons.
Definition: erc_settings.h:51
@ ERCE_FIRST
Definition: erc_settings.h:39
@ ERCE_ENDPOINT_OFF_GRID
Pin or wire-end off grid.
Definition: erc_settings.h:41
@ ERCE_SAME_LOCAL_GLOBAL_LABEL
2 labels are equal for case insensitive comparisons.
Definition: erc_settings.h:55
@ ERCE_LAST
Definition: erc_settings.h:92
@ ERCE_SIMILAR_LABEL_AND_POWER
label and pin are equal for case insensitive comparisons.
Definition: erc_settings.h:53
@ ERCE_BUS_ENTRY_CONFLICT
A wire connected to a bus doesn't match the bus.
Definition: erc_settings.h:67
@ ERCE_FOOTPRINT_LINK_ISSUES
The footprint link is invalid, or points to a missing (or inactive) footprint or library.
Definition: erc_settings.h:79
@ ERCE_DUPLICATE_PIN_ERROR
Definition: erc_settings.h:96
@ ERCE_NOCONNECT_NOT_CONNECTED
A no connect symbol is not connected to anything.
Definition: erc_settings.h:49
@ ERCE_FOUR_WAY_JUNCTION
A four-way junction was found.
Definition: erc_settings.h:87
@ ERCE_GLOBLABEL_DANGLING
A global label is dangling.
Definition: erc_settings.h:72
@ ERCE_SIMULATION_MODEL
An error was found in the simulation model.
Definition: erc_settings.h:75
@ ERCE_LIB_SYMBOL_MISMATCH
Symbol doesn't match copy in library.
Definition: erc_settings.h:78
@ ERCE_GENERIC_ERROR
Definition: erc_settings.h:102
@ ERCE_NOCONNECT_CONNECTED
A no connect symbol is connected to more than 1 pin.
Definition: erc_settings.h:48
@ ERCE_PIN_TO_PIN_WARNING
Definition: erc_settings.h:97
@ ERCE_MISSING_INPUT_PIN
Symbol has input pins that are not placed.
Definition: erc_settings.h:60
@ ERCE_MISSING_UNIT
Symbol has units that are not placed on the schematic.
Definition: erc_settings.h:62
@ ERCE_MISSING_BIDI_PIN
Symbol has bi-directional pins that are not placed.
Definition: erc_settings.h:61
@ ERCE_LIB_SYMBOL_ISSUES
Symbol not found in active libraries.
Definition: erc_settings.h:77
@ ERCE_FOOTPRINT_FILTERS
The assigned footprint doesn't match the footprint filters.
Definition: erc_settings.h:81
@ ERCE_GENERIC_WARNING
Definition: erc_settings.h:101
@ ERCE_SINGLE_GLOBAL_LABEL
A global label only exists once in the schematic.
Definition: erc_settings.h:54
@ ERCE_LABEL_MULTIPLE_WIRES
A label is connected to more than one wire.
Definition: erc_settings.h:88
@ ERCE_PIN_TO_PIN_ERROR
Definition: erc_settings.h:98
PIN_ERROR
The values a pin-to-pin entry in the pin matrix can take on.
Definition: erc_settings.h:107
#define NOD
Definition: erc_settings.h:125
#define NPI
Types of drive on a net (used for legacy ERC)
Definition: erc_settings.h:122
#define ELECTRICAL_PINTYPES_TOTAL
Definition: pin_type.h:54
SEVERITY
@ RPT_SEVERITY_WARNING
@ RPT_SEVERITY_ERROR
@ RPT_SEVERITY_UNDEFINED
@ RPT_SEVERITY_EXCLUSION
@ RPT_SEVERITY_IGNORE
@ SCH_MARKER_T
Definition: typeinfo.h:158
wxString SeverityToString(const SEVERITY &aSeverity)
Definition: ui_common.cpp:66