test_sch_io_database_cycle.cpp

Go to the documentation of this file.

/*
 * This program source code file is part of KiCad, a free EDA CAD application.
 *
 * Copyright The KiCad Developers, see AUTHORS.txt for contributors.
 *
 * This program is free software: you can redistribute it and/or modify it
 * under the terms of the GNU General Public License as published by the
 * Free Software Foundation, either version 3 of the License, or (at your
 * option) any later version.
 *
 * This program is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along
 * with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
#include <boost/test/unit_test.hpp>
 
#include <database/database_lib_settings.h>
#include <lib_symbol.h>
#include <libraries/library_manager.h>
#include <libraries/symbol_library_adapter.h>
#include <reporter.h>
 
// We need access to private members of SCH_IO_DATABASE to drive the cycle-detection
// state directly. The plugin declares SCH_IO_DATABASE_CYCLE_DETECTION_FIXTURE as a friend.
#include <eeschema/sch_io/database/sch_io_database.h>
 

class SCH_IO_DATABASE_CYCLE_DETECTION_FIXTURE
{
public:
    SCH_IO_DATABASE_CYCLE_DETECTION_FIXTURE()
    {
        // s_inProgressLoads is static per thread, make sure any prior tests tidied up
        // after themselves.
        BOOST_REQUIRE_MESSAGE( SCH_IO_DATABASE::s_inProgressLoads.empty(),
                               "s_inProgressLoads is not empty at test start" );
    }
 
    ~SCH_IO_DATABASE_CYCLE_DETECTION_FIXTURE()
    {
        // Do not leak our in-progress loads into subsequent tests.
        SCH_IO_DATABASE::s_inProgressLoads.clear();
    }

    std::unique_ptr<LIB_SYMBOL> InvokeWithCycle( SCH_IO_DATABASE& aPlugin,
                                                 const wxString&  aSymbolName,
                                                 const DATABASE_LIB_TABLE& aTable,
                                                 const DATABASE_CONNECTION::ROW& aRow,
                                                 const wxString& aInProgressKey )
    {
        aPlugin.s_inProgressLoads.insert( aInProgressKey );
        return aPlugin.loadSymbolFromRow( aSymbolName, aTable, aRow );
    }

    std::unique_ptr<LIB_SYMBOL> Invoke( SCH_IO_DATABASE& aPlugin,
                                        const wxString& aSymbolName,
                                        const DATABASE_LIB_TABLE& aTable,
                                        const DATABASE_CONNECTION::ROW& aRow )
    {
        return aPlugin.loadSymbolFromRow( aSymbolName, aTable, aRow );
    }
 
    bool IsInProgressEmpty( const SCH_IO_DATABASE& aPlugin ) const
    {
        return aPlugin.s_inProgressLoads.empty();
    }
 
    std::size_t InProgressSize( const SCH_IO_DATABASE& aPlugin ) const
    {
        return aPlugin.s_inProgressLoads.size();
    }
};
 
 
BOOST_AUTO_TEST_SUITE( SchIoDatabaseCycle )
 
 
// m_adapter is deliberately left null: if the cycle short-circuit fails, loadSymbolFromRow
// dereferences the null adapter and crashes the test. So this fails on revert of the fix.
BOOST_AUTO_TEST_CASE( DetectsAlreadyInProgressLibId )
{
    SCH_IO_DATABASE plugin;
 
    DATABASE_LIB_TABLE table;
    table.name        = "SelfRefDB";
    table.table       = "Parts";
    table.key_col     = "Part ID";
    table.symbols_col = "Symbols";
 
    DATABASE_CONNECTION::ROW row;
    row[table.symbols_col] = std::string( "SelfRefDB:R-001" );
 
    SCH_IO_DATABASE_CYCLE_DETECTION_FIXTURE fixture;
 
    std::unique_ptr<LIB_SYMBOL> symbol =
            fixture.InvokeWithCycle( plugin, wxS( "R-001" ), table, row, wxS( "SelfRefDB:R-001" ) );
 
    BOOST_REQUIRE( symbol );
    BOOST_CHECK( symbol->GetName() == wxS( "R-001" ) );
 
    // The re-insert of the already-seeded key must observe it as present and so must not erase
    // the fixture's entry on the way out.
    BOOST_CHECK_EQUAL( fixture.InProgressSize( plugin ), 1u );
}
 
 
// A leaked in-progress entry would make a later load of the same LIB_ID a false positive cycle.
// Drive two loads through a real (empty) adapter and require the set to be empty after each, so
// a broken RAII removal is caught.
BOOST_AUTO_TEST_CASE( RaiiGuardBalancesInProgressSet )
{
    LIBRARY_MANAGER        libManager;
    SYMBOL_LIBRARY_ADAPTER adapter( libManager );
 
    SCH_IO_DATABASE plugin;
    plugin.SetLibraryManagerAdapter( &adapter );
 
    DATABASE_LIB_TABLE table;
    table.name        = "SelfRefDB";
    table.table       = "Parts";
    table.key_col     = "Part ID";
    table.symbols_col = "Symbols";
 
    DATABASE_CONNECTION::ROW row;
    // Valid LIB_ID that will be tracked. The adapter has no libraries loaded so its LoadSymbol
    // returns null without ever re-entering SCH_IO_DATABASE.
    row[table.symbols_col] = std::string( "SomeLib:R-001" );
 
    SCH_IO_DATABASE_CYCLE_DETECTION_FIXTURE fixture;
 
    std::unique_ptr<LIB_SYMBOL> symbol = fixture.Invoke( plugin, wxS( "R-001" ), table, row );
 
    BOOST_REQUIRE( symbol );
    BOOST_CHECK( fixture.IsInProgressEmpty( plugin ) );
 
    // A second call on the same row must not see leftover state from the first.
    symbol = fixture.Invoke( plugin, wxS( "R-001" ), table, row );
    BOOST_REQUIRE( symbol );
    BOOST_CHECK( fixture.IsInProgressEmpty( plugin ) );
}
 
 
// Tokens of the Symbols column that are not Library:Symbol must be reported, not silently dropped.
BOOST_AUTO_TEST_CASE( ReportsMalformedSymbolReference )
{
    LIBRARY_MANAGER        libManager;
    SYMBOL_LIBRARY_ADAPTER adapter( libManager );
 
    SCH_IO_DATABASE plugin;
    plugin.SetLibraryManagerAdapter( &adapter );
 
    WX_STRING_REPORTER reporter;
    plugin.SetReporter( &reporter );
 
    DATABASE_LIB_TABLE table;
    table.name        = "Parts";
    table.table       = "Parts";
    table.key_col     = "Part ID";
    table.symbols_col = "Symbols";
 
    SCH_IO_DATABASE_CYCLE_DETECTION_FIXTURE fixture;
 
    DATABASE_CONNECTION::ROW row;
    row[table.symbols_col] = std::string( "SomeLib:R-001" );
 
    fixture.Invoke( plugin, wxS( "R-001" ), table, row );
    BOOST_CHECK( reporter.GetMessages().IsEmpty() );
 
    row[table.symbols_col] = std::string( "NotASymbol;SomeLib:R-001" );
 
    fixture.Invoke( plugin, wxS( "R-001" ), table, row );
    BOOST_CHECK_EQUAL( reporter.GetMessages(),
                       wxString( "'NotASymbol' is not a symbol; expected Library:Symbol.\n" ) );
}
 
 
BOOST_AUTO_TEST_SUITE_END()